[GitHub] incubator-weex pull request #1356: [WEEX-495][iOS] Fix class_replaceMethod p...

2018-07-27 Thread xuyouyang
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1356 ---

[GitHub] incubator-weex pull request #1357: [WEEX-524][iOS] Try to fix a crash operat...

2018-07-22 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1357 [WEEX-524][iOS] Try to fix a crash operating mutable array in multi-thread Try to fix a crash: Terminating app due to uncaught exception 'NSRangeException

[GitHub] incubator-weex pull request #1356: [WEEX-495][iOS] Fix class_replaceMethod p...

2018-07-22 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1356 [WEEX-495][iOS] Fix class_replaceMethod param error in WXSwizzleInstanceMethod Fix class_replaceMethod param error in WXSwizzleInstanceMethod You can merge this pull request into a Git

[GitHub] incubator-weex pull request #1352: [WEEX-524][iOS]Try to fix a crash when re...

2018-07-19 Thread xuyouyang
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1352 ---

[GitHub] incubator-weex pull request #1193: [WEEX-394] [iOS] Add license

2018-07-05 Thread xuyouyang
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1193 ---

[GitHub] incubator-weex issue #1234: [iOS] Fix loading component

2018-06-02 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1234 @snail-Lin Thank you for your contribution!!As the [development process](http://weex.apache.org/development-process.html)shows, we need create a jira issue in [apache](https

[GitHub] incubator-weex issue #1221: [android] modify playground app camera runtime p...

2018-06-01 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1221 @shawnlinboy Thank you for your contribution!!As the [development process shows](http://weex.apache.org/development-process.html), we need create a jira issue in [apache](https

[GitHub] incubator-weex pull request #1193: [WEEX-394] [iOS] Add license

2018-05-22 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1193 [WEEX-394] [iOS] Add license Add license for some iOS files. • ./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreFlexEnum.h • ./incubator-weex-7102479

[GitHub] incubator-weex pull request #1121: [WEEX-298][iOS]fix WXIndicatorView invoke...

2018-04-23 Thread xuyouyang
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1121 ---

[GitHub] incubator-weex issue #1127: WXImageComponent: set imageview in completion bl...

2018-04-23 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1127 @xiayun200825 thank you for your contributions. Can you give us some testcase through 'http://dotwe.org/vue' ? ---

[GitHub] incubator-weex pull request #1123: [WEEX-294][iOS]use NSTimer to implement s...

2018-04-21 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1123 [WEEX-294][iOS]use NSTimer to implement setTimeout Use NSTimer to implement setTimeout. testcast:http://dotwe.org/vue/5e897eb8621fbb35cdbe49c41cf7c9dd You can merge this pull

[GitHub] incubator-weex pull request #1121: [WEEX-298][IOS]fix WXIndicatorView invoke...

2018-04-20 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1121 [WEEX-298][IOS]fix WXIndicatorView invoke setNeedsDisplay not on main thread fix WXIndicatorView invoke setNeedsDisplay not on main thread You can merge this pull request into a Git

[GitHub] incubator-weex pull request #1111: * [iOS] Bind instanceId to jscontext and ...

2018-04-12 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/ * [iOS] Bind instanceId to jscontext and post notice when jscontext created Bind instanceId to jscontext and post notice when jscontext created. You can merge this pull request into a

[GitHub] incubator-weex issue #1072: [WEEX-249][iOS]fix WXRuleManager multi-thread cr...

2018-03-15 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1072 hi @acton393 if we change fontFamilyDic type to NSMutableDictionary,will it also cause multi-thread problem? For example, other thread operate object in fontFamilyDic. And I

[GitHub] incubator-weex pull request #1072: [WEEX-249][iOS]fix WXRuleManager multi-th...

2018-03-14 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1072 [WEEX-249][iOS]fix WXRuleManager multi-thread crash fontFamilyDic type is WXThreadSafeMutableDictionary in WXUtility.m but the real type is NSMutableDictionary created in WXRuleManager.m

[GitHub] incubator-weex issue #1051: [WEEX-241][iOS] add WXVideoComponent "poster" at...

2018-03-08 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 @acton393 Ha, it's sorry that I am not familiar with Android develop very much.😂 ---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 OK. Thank you very much! @acton393 ---

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

2018-03-07 Thread xuyouyang
Github user xuyouyang commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1051#discussion_r173046770 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m --- @@ -85,6 +89,13 @@ - (id)init } [self

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-06 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 NO. The poster attribute specifies an image to be shown while the video is downloading, or until the user hits the play button. If this is not included, the first frame of the video

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

2018-03-06 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1051 + [iOS] add WXVideoComponent "poster" attribute. + [iOS] add WXVideoComponent poster feature and add support "poster" attribute to testcase:

[GitHub] incubator-weex pull request #1038: *[iOS]fix annotation spell error.

2018-02-24 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1038 *[iOS]fix annotation spell error. *[iOS]fix annotation spell error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang

[GitHub] incubator-weex pull request #930: * [ios] fix WXSDKInstance retain cycle

2017-12-05 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/930 * [ios] fix WXSDKInstance retain cycle * [ios] fix WXSDKInstance retain cycle You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-weex pull request #388: * [ios] fix WXBridgeContext.h annotation

2017-05-23 Thread xuyouyang
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/388 * [ios] fix WXBridgeContext.h annotation You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex dev Alternatively