Repository: incubator-weex Updated Branches: refs/heads/master 38f43eccd -> 0935d64e5
[WEEX-342][android] ava.util.ConcurrentModificationException at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:573)at com.taobao.weex.ui.component.WXComponent.applyEvents(WXComponent.java:290) Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/a0dacda5 Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/a0dacda5 Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/a0dacda5 Branch: refs/heads/master Commit: a0dacda5b0c8901b4798710aea0597a66850bd84 Parents: a13225f Author: jianbai.gbj <jianbai....@alibaba-inc.com> Authored: Thu Jun 14 10:56:48 2018 +0800 Committer: jianbai.gbj <jianbai....@alibaba-inc.com> Committed: Thu Jun 14 10:56:48 2018 +0800 ---------------------------------------------------------------------- .../java/com/taobao/weex/ui/component/WXComponent.java | 10 ++++------ .../java/com/taobao/weex/ui/view/gesture/WXGesture.java | 3 ++- 2 files changed, 6 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/a0dacda5/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java index cba19d3..9572986 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java @@ -290,11 +290,7 @@ public abstract class WXComponent<T extends View> extends WXBasicComponent imple if (getEvents() == null || getEvents().isEmpty()) return; WXEvent event = getEvents(); - int size = event.size(); - for(int i=0; i<size; i++){ - if(i >= event.size()){ - break; - } + for(int i=0; i<event.size(); i++){ String type = event.get(i); addEvent(type); } @@ -1450,7 +1446,9 @@ public abstract class WXComponent<T extends View> extends WXBasicComponent imple if (getEvents().size() < 1) { return; } - for (String event : getEvents()) { + WXEvent events = getEvents(); + for (int i=0; i<events.size(); i++) { + String event = events.get(i); if (event == null) { continue; } http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/a0dacda5/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java index a27090b..be114a9 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java @@ -140,7 +140,8 @@ public class WXGesture extends GestureDetector.SimpleOnGestureListener implement if(event == null){ return false; } - for(String type : event){ + for(int i=0; i<event.size(); i++){ + String type = event.get(i); if(isStopPropagation(type)){ return true; }
