Repository: incubator-weex Updated Branches: refs/heads/master 7f79916c8 -> cbf071975
* [android] clear box-shadow when component has recycled close #917 Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/cbf07197 Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/cbf07197 Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/cbf07197 Branch: refs/heads/master Commit: cbf071975838d04fb6870d89e14b36d16b0d7ced Parents: 7f79916 Author: misakuo <misa...@apache.org> Authored: Mon Nov 13 11:37:08 2017 +0800 Committer: acton393 <zhangxing610...@gmail.com> Committed: Tue Nov 28 14:29:23 2017 +0800 ---------------------------------------------------------------------- .../main/java/com/taobao/weex/ui/component/WXComponent.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/cbf07197/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java index 07b692b..78a2bf3 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java @@ -895,8 +895,8 @@ public abstract class WXComponent<T extends View> implements IWXObject, IWXActi float quality = WXUtils.getFloat(shadowQuality, 0.5f); int viewPort = getInstance().getInstanceViewPortWidth(); String token = new StringBuilder(boxShadow.toString()).append(" / [") - .append(getDomObject().getStyles().getWidth(viewPort)).append(",") - .append(getDomObject().getStyles().getHeight(viewPort)).append("] / ") + .append(target.getMeasuredWidth()).append(",") + .append(target.getMeasuredHeight()).append("] / ") .append(quality).toString(); if (mLastBoxShadowId != null && mLastBoxShadowId.equals(token)) { @@ -947,7 +947,6 @@ public abstract class WXComponent<T extends View> implements IWXObject, IWXActi if (getDomObject() != null && getDomObject().getStyles() != null) { Object obj = getDomObject().getStyles().get(Constants.Name.BOX_SHADOW); if (obj == null) { - WXLogUtils.d("BoxShadow", "no box-shadow"); return; } } @@ -963,6 +962,7 @@ public abstract class WXComponent<T extends View> implements IWXObject, IWXActi overlay.clear(); } } + mLastBoxShadowId = null; } @TargetApi(Build.VERSION_CODES.JELLY_BEAN) @@ -1606,10 +1606,12 @@ public abstract class WXComponent<T extends View> implements IWXObject, IWXActi /******************************** * end hook Activity life cycle callback ********************************************************/ + @CallSuper public void recycled() { if(mDomObj.isFixed()) return; + clearBoxShadow(); } public void destroy() {
