[jira] [Closed] (WICKET-5394) DefaultDataTable should use factory methods for toolbars

2013-10-24 Thread Sven Meier (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier closed WICKET-5394. -- Resolution: Invalid Assignee: Sven Meier As you've written, just subclass DataTable. > DefaultD

[jira] [Commented] (WICKET-5394) DefaultDataTable should use factory methods for toolbars

2013-10-24 Thread Oliver B. Fischer (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804340#comment-13804340 ] Oliver B. Fischer commented on WICKET-5394: --- I got it, I have to inherit from D

[jira] [Created] (WICKET-5394) DefaultDataTable should use factory methods for toolbars

2013-10-24 Thread Oliver B. Fischer (JIRA)
Oliver B. Fischer created WICKET-5394: - Summary: DefaultDataTable should use factory methods for toolbars Key: WICKET-5394 URL: https://issues.apache.org/jira/browse/WICKET-5394 Project: Wicket

git commit: WICKET-5393 Remove 'final' from InlineFrame#onComponentTag()

2013-10-24 Thread mgrigorov
Updated Branches: refs/heads/master 3168927cb -> 060a2d84c WICKET-5393 Remove 'final' from InlineFrame#onComponentTag() Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/060a2d84 Tree: http://git-wip-us.apache.org/repos/as

[jira] [Resolved] (WICKET-5393) Remove 'final' from InlineFrame#onComponentTag()

2013-10-24 Thread Martin Grigorov (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5393. - Resolution: Fixed Fix Version/s: 6.12.0 7.0.0 The method is no

git commit: WICKET-5393 Remove 'final' from InlineFrame#onComponentTag()

2013-10-24 Thread mgrigorov
Updated Branches: refs/heads/wicket-6.x fc8163d84 -> 9696bf9d2 WICKET-5393 Remove 'final' from InlineFrame#onComponentTag() Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9696bf9d Tree: http://git-wip-us.apache.org/repo

[jira] [Created] (WICKET-5393) Remove 'final' from InlineFrame#onComponentTag()

2013-10-24 Thread Martin Grigorov (JIRA)
Martin Grigorov created WICKET-5393: --- Summary: Remove 'final' from InlineFrame#onComponentTag() Key: WICKET-5393 URL: https://issues.apache.org/jira/browse/WICKET-5393 Project: Wicket Issue

[jira] [Commented] (WICKET-5392) Responses for package resources cannot be compressed

2013-10-24 Thread Martin Grigorov (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804076#comment-13804076 ] Martin Grigorov commented on WICKET-5392: - I have never did it. But it is not imp

[jira] [Commented] (WICKET-5392) Responses for package resources cannot be compressed

2013-10-24 Thread Sven Meier (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804073#comment-13804073 ] Sven Meier commented on WICKET-5392: Extending a settings object is rather unusual in

[jira] [Updated] (WICKET-5392) Responses for package resources cannot be compressed

2013-10-24 Thread Martin Grigorov (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated WICKET-5392: Attachment: WICKET-5392.patch Here is a new patch for master branch. It passes the Abstrac

[jira] [Commented] (WICKET-5392) Responses for package resources cannot be compressed

2013-10-24 Thread Martin Grigorov (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803965#comment-13803965 ] Martin Grigorov commented on WICKET-5392: - I'll apply an improvement only in mast

[jira] [Commented] (WICKET-5392) Responses for package resources cannot be compressed

2013-10-24 Thread Sven Meier (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803957#comment-13803957 ] Sven Meier commented on WICKET-5392: I didn't find the originating commit, but I agre