[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510844#comment-17510844 ] ASF GitHub Bot commented on WICKET-6965: martin-g commented on pull request #505: URL:

[GitHub] [wicket] martin-g commented on pull request #505: WICKET-6965 Memory leak in WicketEndpoint

2022-03-22 Thread GitBox
martin-g commented on pull request #505: URL: https://github.com/apache/wicket/pull/505#issuecomment-1075546529 Good catch! I've simplified it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510843#comment-17510843 ] ASF subversion and git services commented on WICKET-6965: - Commit

[wicket] branch wicket-6944-make-application-listeners-static updated (f333ec0 -> 3f15cdc)

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a change to branch wicket-6944-make-application-listeners-static in repository https://gitbox.apache.org/repos/asf/wicket.git. from f333ec0 WICKET-6965 Memory leak in WicketEndpoint add 3f15cdc

[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510758#comment-17510758 ] ASF GitHub Bot commented on WICKET-6965: theigl commented on pull request #505: URL:

[GitHub] [wicket] theigl commented on pull request #505: WICKET-6965 Memory leak in WicketEndpoint

2022-03-22 Thread GitBox
theigl commented on pull request #505: URL: https://github.com/apache/wicket/pull/505#issuecomment-1075387541 @martin-g: I just realized that this won't work. The `AtomicBoolean` would need to be static as well. Otherwise, only the very first endpoint that registered the listener will get

[wicket] 02/02: Update grunt-contrib-jshint, npm and Node.js

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git commit 7c322028f5b955306d75ba5c633e90f107bb8ad6 Author: Martin Tzvetanov Grigorov AuthorDate: Tue Mar 22 16:12:28 2022

[wicket] 01/02: Revert "Temporarily disable TravisCI caches of M2_REPO"

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git commit 78196efbb425619e7d14a8bb81c9b26f4e8fb8ca Author: Martin Tzvetanov Grigorov AuthorDate: Tue Mar 22 16:08:27 2022

[wicket] branch master updated (a54277a -> 7c32202)

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git. from a54277a Temporarily disable TravisCI caches of M2_REPO new 78196ef Revert "Temporarily disable TravisCI

[GitHub] [wicket] papegaaij commented on pull request #504: Guarantee order of listener notifications

2022-03-22 Thread GitBox
papegaaij commented on pull request #504: URL: https://github.com/apache/wicket/pull/504#issuecomment-1075149447 I wouldn't recommend to depend on listeners being added in a specific order, especially when they are added automatically, for example via a service loader. However, if you add

[jira] [Updated] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov updated WICKET-6965: -- Affects Version/s: 9.8.0 (was: 9.7.0) >

[GitHub] [wicket] martin-g commented on pull request #504: Guarantee order of listener notifications

2022-03-22 Thread GitBox
martin-g commented on pull request #504: URL: https://github.com/apache/wicket/pull/504#issuecomment-1075117102 I remember @ivaynberg having a conversation with someone on the mailing lists about depending on order. His wise advice was to never rely on someone/something else to provide it

[wicket] branch master updated: Temporarily disable TravisCI caches of M2_REPO

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new a54277a Temporarily disable TravisCI caches

[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510434#comment-17510434 ] ASF GitHub Bot commented on WICKET-6965: martin-g opened a new pull request #505: URL:

[GitHub] [wicket] martin-g opened a new pull request #505: WICKET-6965 Memory leak in WicketEndpoint

2022-03-22 Thread GitBox
martin-g opened a new pull request #505: URL: https://github.com/apache/wicket/pull/505 Make WicketEndpoint#REGISTERED_LISTENERS a static field. Unregister the listener at Application#onBeforeDestroyed() Signed-off-by: Martin Tzvetanov Grigorov -- This is an automated message

[jira] [Commented] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510433#comment-17510433 ] ASF subversion and git services commented on WICKET-6965: - Commit

[wicket] 01/01: WICKET-6965 Memory leak in WicketEndpoint

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch wicket-6944-make-application-listeners-static in repository https://gitbox.apache.org/repos/asf/wicket.git commit f333ec0ff16e56756433ff66a4f5ddd12b1a984b Author: Martin Tzvetanov Grigorov

[wicket] branch wicket-6944-make-application-listeners-static created (now f333ec0)

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a change to branch wicket-6944-make-application-listeners-static in repository https://gitbox.apache.org/repos/asf/wicket.git. at f333ec0 WICKET-6965 Memory leak in WicketEndpoint This branch includes

[jira] [Created] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
Martin Tzvetanov Grigorov created WICKET-6965: - Summary: Memory leak in WicketEndpoint Key: WICKET-6965 URL: https://issues.apache.org/jira/browse/WICKET-6965 Project: Wicket

[jira] [Updated] (WICKET-6965) Memory leak in WicketEndpoint

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov updated WICKET-6965: -- Fix Version/s: (was: 10.0.0) (was: 8.14.0)

[GitHub] [wicket] papegaaij opened a new pull request #504: Guarantee order of listener notifications

2022-03-22 Thread GitBox
papegaaij opened a new pull request #504: URL: https://github.com/apache/wicket/pull/504 `ListenerCollection` has a note that states that the order is not guaranteed. This seems strange as the collection is simply a list and it even has a method to notify the listeners in reverse order. I

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510383#comment-17510383 ] Martin Tzvetanov Grigorov commented on WICKET-6944: --- Such kind of changes should

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-22 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510378#comment-17510378 ] Thomas Heigl commented on WICKET-6944: -- Since {{JavaxWebSocketProcessor}} has a reference to the

[jira] [Commented] (WICKET-6964) Do not allocate when escaping empty string

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510357#comment-17510357 ] ASF subversion and git services commented on WICKET-6964: - Commit

[jira] [Commented] (WICKET-6964) Do not allocate when escaping empty string

2022-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510358#comment-17510358 ] ASF GitHub Bot commented on WICKET-6964: theigl merged pull request #502: URL:

[GitHub] [wicket] theigl merged pull request #502: WICKET-6964 Do not allocate when escaping empty string

2022-03-22 Thread GitBox
theigl merged pull request #502: URL: https://github.com/apache/wicket/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[wicket] branch master updated: WICKET-6964 Do not allocate when escaping empty string (#502)

2022-03-22 Thread theigl
This is an automated email from the ASF dual-hosted git repository. theigl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new 28cda68 WICKET-6964 Do not allocate when

[jira] [Resolved] (WICKET-6962) Use singletons for PanelMarkupSourcingStrategy

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov resolved WICKET-6962. --- Resolution: Duplicate > Use singletons for

[jira] [Commented] (WICKET-6944) Memory leak in WicketEndpoint

2022-03-22 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510350#comment-17510350 ] Martin Tzvetanov Grigorov commented on WICKET-6944: --- You will also need to remove the

[wicket] branch master updated: Update Maven to 3.8.5

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new 8bfd774 Update Maven to 3.8.5 8bfd774 is

[wicket] branch master updated: Update Maven to 3.8.5

2022-03-22 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new 85b509f Update Maven to 3.8.5 85b509f is