[jira] [Commented] (WICKET-7011) Improve usage of JUnit 5.x APIs

2022-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1768#comment-1768 ] ASF subversion and git services commented on WICKET-7011: - Commi

[wicket] branch wicket-9.x updated: Cleanup junit 5 assertions (#545)

2022-10-21 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch wicket-9.x in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/wicket-9.x by this push: new 0514a4a72b Cleanup junit 5 assertions

[jira] [Commented] (WICKET-7011) Improve usage of JUnit 5.x APIs

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1767#comment-1767 ] ASF GitHub Bot commented on WICKET-7011: martin-g commented on PR #545: URL: htt

[GitHub] [wicket] martin-g commented on pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286896241 Thank you, @vandeven & @timtebeek ! Please use https://issues.apache.org/jira/browse/WICKET-7011 as a ticket reference for any further work on this topic! -- This is an automated m

[jira] [Commented] (WICKET-7011) Improve usage of JUnit 5.x APIs

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1765#comment-1765 ] ASF GitHub Bot commented on WICKET-7011: martin-g merged PR #545: URL: https://g

[jira] [Commented] (WICKET-7011) Improve usage of JUnit 5.x APIs

2022-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1766#comment-1766 ] ASF subversion and git services commented on WICKET-7011: - Commi

[wicket] branch master updated: Cleanup junit 5 assertions (#545)

2022-10-21 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new acc979b3ba Cleanup junit 5 assertions (#545)

[GitHub] [wicket] martin-g merged pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g merged PR #545: URL: https://github.com/apache/wicket/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[jira] [Created] (WICKET-7011) Improve usage of JUnit 5.x APIs

2022-10-21 Thread Martin Tzvetanov Grigorov (Jira)
Martin Tzvetanov Grigorov created WICKET-7011: - Summary: Improve usage of JUnit 5.x APIs Key: WICKET-7011 URL: https://issues.apache.org/jira/browse/WICKET-7011 Project: Wicket Is

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001597087 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001595216 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] solomax commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
solomax commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001574012 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] martin-g commented on pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286655770 > Would you appreciate a few more such automated fixes? Sure! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] timtebeek commented on pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286628517 Glad to see this approved so quickly @martin-g ! :) Would you appreciate a few more such automated fixes? I understand it's a fine balance to not overwhelm you with review requests when