[
https://issues.apache.org/jira/browse/WICKET-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703928#comment-17703928
]
ASF GitHub Bot commented on WICKET-7035:
solomax commented on code in PR #561:
U
solomax commented on code in PR #561:
URL: https://github.com/apache/wicket/pull/561#discussion_r1145758595
##
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##
@@ -1866,6 +1904,29 @@ protected void onBeforeRender()
// clear multipart hin
[
https://issues.apache.org/jira/browse/WICKET-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703922#comment-17703922
]
ASF GitHub Bot commented on WICKET-7035:
martin-g commented on code in PR #561:
martin-g commented on code in PR #561:
URL: https://github.com/apache/wicket/pull/561#discussion_r1145750830
##
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##
@@ -1866,6 +1904,29 @@ protected void onBeforeRender()
// clear multipart hi
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a change to branch fileCountMax-9.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
from f8a942853b Code to automatically set fileCountMax is added
add 854ff6730c Optional is inited
No new r
Maxim Solodovnik created WICKET-7035:
Summary: fileCountMax should be added to control the amount of
files being uploaded
Key: WICKET-7035
URL: https://issues.apache.org/jira/browse/WICKET-7035
Pr
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a change to branch fileCountMax-9.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
from 84aad6c57f More work on max file count
add f8a942853b Code to automatically set fileCountMax is added
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703612#comment-17703612
]
ASF GitHub Bot commented on WICKET-7034:
dstoch commented on PR #562:
URL: https
dstoch commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479388864
Ok, thank you @martin-g.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703602#comment-17703602
]
Ernesto Reinaldo Barreiro commented on WICKET-7034:
---
[~interface]
In
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703596#comment-17703596
]
ASF subversion and git services commented on WICKET-7034:
-
Commi
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703597#comment-17703597
]
ASF GitHub Bot commented on WICKET-7034:
martin-g commented on PR #562:
URL: htt
martin-g commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479310800
https://github.com/apache/wicket/commit/9fa35bbc5403f94a62c73bcb83b525a9a606429f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new 9fa35bbc54 WICKET-7034: Publish WebSocket eve
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703595#comment-17703595
]
ASF GitHub Bot commented on WICKET-7034:
martin-g commented on PR #562:
URL: htt
martin-g commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479309848
Oops! I pushed it to a wrong branch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703594#comment-17703594
]
ASF GitHub Bot commented on WICKET-7034:
martin-g commented on PR #562:
URL: htt
martin-g commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479308553
I have already cherry-picked it with
https://github.com/apache/wicket/commit/f3e40820c8d459cf668e059f55c76dc4b73e3732
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703590#comment-17703590
]
ASF GitHub Bot commented on WICKET-7034:
dstoch commented on PR #562:
URL: https
dstoch commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479291083
This PR is for wicket-9.x. I am not sure how to fix this in master (10.x)?
Should I prepare another PR or it will be merged other way?
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703585#comment-17703585
]
ASF subversion and git services commented on WICKET-7034:
-
Commi
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Tzvetanov Grigorov resolved WICKET-7034.
---
Fix Version/s: 10.0.0
9.13.0
Resolution: Fi
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703586#comment-17703586
]
ASF GitHub Bot commented on WICKET-7034:
martin-g commented on PR #562:
URL: htt
[
https://issues.apache.org/jira/browse/WICKET-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703584#comment-17703584
]
ASF subversion and git services commented on WICKET-7032:
-
Commi
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch WICKET-7032-update-js-tests
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit f3e40820c8d459cf668e059f55c76dc4b73e3732
Author: Daniel Stoch
AuthorDate: Wed Mar 22 11:20:38 20
martin-g commented on PR #562:
URL: https://github.com/apache/wicket/pull/562#issuecomment-1479285925
Thank you, @dstoch !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a change to branch WICKET-7032-update-js-tests
in repository https://gitbox.apache.org/repos/asf/wicket.git
at f3e40820c8 WICKET-7034: Publish WebSocket events even if connection
was already closed (#562)
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703582#comment-17703582
]
ASF GitHub Bot commented on WICKET-7034:
martin-g merged PR #562:
URL: https://g
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch wicket-9.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/wicket-9.x by this push:
new 25d4f5016d WICKET-7034: Publish WebSo
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703583#comment-17703583
]
ASF subversion and git services commented on WICKET-7034:
-
Commi
martin-g merged PR #562:
URL: https://github.com/apache/wicket/pull/562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apach
martin-g commented on PR #561:
URL: https://github.com/apache/wicket/pull/561#issuecomment-1479267796
In that case maybe it would be better to not do anything at line 225 but add
logic to `Form#onBeforeRender()` (?!) that does something like:
```
# pseudo code
if (maxFileCount == -
[
https://issues.apache.org/jira/browse/WICKET-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703577#comment-17703577
]
ASF GitHub Bot commented on WICKET-7034:
dstoch opened a new pull request, #562:
dstoch opened a new pull request, #562:
URL: https://github.com/apache/wicket/pull/562
This PR contains fix for WICKET-7034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
solomax commented on PR #561:
URL: https://github.com/apache/wicket/pull/561#issuecomment-1479201460
> You mean to call form.setFileCountMax(this.max) ?
yes
> Why ? I think this is responsibility of the developer to set the max per
Form. Wicket should not try to calculate it. O
martin-g commented on PR #561:
URL: https://github.com/apache/wicket/pull/561#issuecomment-1479159277
> I would like to add `setFileCountMax()` to `MultiFileUploadField` (at line
225)
You mean to call `form.setFileCountMax(this.max)` ?
Why ? I think this is responsibility of the de
36 matches
Mail list logo
