[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705818#comment-17705818 ] ASF GitHub Bot commented on WICKET-6915: solomax commented on code in PR #565: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

solomax commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1150062370 ## wicket-core/src/main/java/module-info.java: ## @@ -23,7 +23,8 @@ requires org.apache.wicket.request; requires org.apache.commons.io; requires

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705817#comment-17705817 ] ASF GitHub Bot commented on WICKET-6915: martin-g commented on code in PR #565: URL:

[jira] [Commented] (WICKET-7036) Extend MarkupFactory, so that additional MarkupFilters for MarkupParser can be added

[ https://issues.apache.org/jira/browse/WICKET-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705814#comment-17705814 ] ASF GitHub Bot commented on WICKET-7036: martin-g commented on PR #564: URL:

[GitHub] [wicket] martin-g commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

martin-g commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1150061840 ## wicket-core/src/main/java/module-info.java: ## @@ -23,7 +23,8 @@ requires org.apache.wicket.request; requires org.apache.commons.io; requires

[GitHub] [wicket] martin-g commented on pull request #564: WICKET-7036: MarkupFactory supports IMarkupFilters

martin-g commented on PR #564: URL: https://github.com/apache/wicket/pull/564#issuecomment-1486258481 Thanks for the explanation, @hosea ! I can see how the code in this PR would help for your case! But no one ever asked for this so far and it looks like a rather unique case.

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705812#comment-17705812 ] ASF GitHub Bot commented on WICKET-6915: solomax commented on code in PR #565: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

solomax commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1150060808 ## wicket-core/src/main/java/module-info.java: ## @@ -23,7 +23,8 @@ requires org.apache.wicket.request; requires org.apache.commons.io; requires

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705802#comment-17705802 ] ASF GitHub Bot commented on WICKET-6915: martin-g commented on code in PR #565: URL:

[GitHub] [wicket] martin-g commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

martin-g commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1150042754 ## wicket-core/src/main/java/module-info.java: ## @@ -23,7 +23,8 @@ requires org.apache.wicket.request; requires org.apache.commons.io; requires

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705801#comment-17705801 ] ASF GitHub Bot commented on WICKET-6915: martin-g commented on code in PR #565: URL:

[GitHub] [wicket] martin-g commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

martin-g commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1150041747 ## wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java: ## @@ -0,0 +1,165 @@ +/* Review Comment:

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705764#comment-17705764 ] ASF GitHub Bot commented on WICKET-6915: solomax commented on code in PR #565: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

solomax commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1149971094 ## wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java: ## @@ -0,0 +1,165 @@ +/* Review Comment: I

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705752#comment-17705752 ] ASF subversion and git services commented on WICKET-6915: - Commit

[wicket] branch fileupload2 updated (d2b4821d5c -> 00f0eee560)

This is an automated email from the ASF dual-hosted git repository. solomax pushed a change to branch fileupload2 in repository https://gitbox.apache.org/repos/asf/wicket.git from d2b4821d5c [WICKET-6915] attempt to fix tests add 00f0eee560 [WICKET-6915] Comments are addressed No new

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705746#comment-17705746 ] ASF GitHub Bot commented on WICKET-6915: solomax commented on code in PR #565: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

solomax commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1149942530 ## wicket-core/src/main/java/module-info.java: ## @@ -23,7 +23,8 @@ requires org.apache.wicket.request; requires org.apache.commons.io; requires

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705743#comment-17705743 ] ASF GitHub Bot commented on WICKET-6915: solomax commented on code in PR #565: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

solomax commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1149941017 ## wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java: ## @@ -0,0 +1,165 @@ +/* Review Comment: ```

[jira] [Commented] (WICKET-7036) Extend MarkupFactory, so that additional MarkupFilters for MarkupParser can be added

[ https://issues.apache.org/jira/browse/WICKET-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705401#comment-17705401 ] ASF GitHub Bot commented on WICKET-7036: hosea commented on PR #564: URL:

[GitHub] [wicket] hosea commented on pull request #564: WICKET-7036: MarkupFactory supports IMarkupFilters

hosea commented on PR #564: URL: https://github.com/apache/wicket/pull/564#issuecomment-1485306655 Hi @theigl , @martin-g , I agree with you, that one could easily extend MarkupFactory and achieve the requirement. That's in fact, what we do now. I just want to explain, why it would

[jira] [Commented] (WICKET-6915) Update common-fileupload to 2.0

[ https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705297#comment-17705297 ] ASF GitHub Bot commented on WICKET-6915: martin-g commented on code in PR #565: URL:

[GitHub] [wicket] martin-g commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

martin-g commented on code in PR #565: URL: https://github.com/apache/wicket/pull/565#discussion_r1149143654 ## wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java: ## @@ -0,0 +1,165 @@ +/* Review Comment: I am

[jira] [Commented] (WICKET-7036) Extend MarkupFactory, so that additional MarkupFilters for MarkupParser can be added

[ https://issues.apache.org/jira/browse/WICKET-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705294#comment-17705294 ] ASF GitHub Bot commented on WICKET-7036: martin-g commented on PR #564: URL:

[GitHub] [wicket] martin-g commented on pull request #564: WICKET-7036: MarkupFactory supports IMarkupFilters

martin-g commented on PR #564: URL: https://github.com/apache/wicket/pull/564#issuecomment-1484927039 I agree with @theigl that one could easily extend MarkupFactory and achieve the requirement. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (WICKET-7036) Extend MarkupFactory, so that additional MarkupFilters for MarkupParser can be added

[ https://issues.apache.org/jira/browse/WICKET-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705272#comment-17705272 ] ASF GitHub Bot commented on WICKET-7036: theigl commented on PR #564: URL:

[GitHub] [wicket] theigl commented on pull request #564: WICKET-7036: MarkupFactory supports IMarkupFilters

theigl commented on PR #564: URL: https://github.com/apache/wicket/pull/564#issuecomment-1484847931 Is this really necessary? The Javadoc for `MarkupFactory` reads: ```java * MarkupParser's can be extended by means of {@link IMarkupFilter}. You can add your own filter *