[PR] WICKET-7107 improved BaseWicketTester#WicketTesterServletWebResponse [wicket]

2024-04-25 Thread via GitHub
dr0ps opened a new pull request, #846: URL: https://github.com/apache/wicket/pull/846 WICKET-7107 seems to not be an issue in Wicket core but rather a shortcoming of BaseWicketTester. WicketTesterServletWebResponse does implement IMetaDataBufferingWebResponse but fails to buffer header data

[jira] [Commented] (WICKET-7107) CSP Header not rendered when using RedirectPolicy.AUTO_REDIRECT

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840817#comment-17840817 ] ASF GitHub Bot commented on WICKET-7107: dr0ps opened a new pull request, #846:

[jira] [Updated] (WICKET-7107) CSP Header not rendered when using RedirectPolicy.AUTO_REDIRECT

2024-04-25 Thread Dirk Forchel (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Forchel updated WICKET-7107: - Description: If we redirect to another Web Page and use the RedirectPolicy.AUTO_REDIRECT, this

Re: [PR] WICKET-7107 improved BaseWicketTester#WicketTesterServletWebResponse [wicket]

2024-04-25 Thread via GitHub
dr0ps commented on PR #846: URL: https://github.com/apache/wicket/pull/846#issuecomment-2078081010 ResetResponseException$ResponseResettingDecorator#respond(RequestCycle) calls reset() on the response object. The current implementation in BaseWicketTester$WicketTesterServletWebResponse does

[jira] [Commented] (WICKET-7107) CSP Header not rendered when using RedirectPolicy.AUTO_REDIRECT

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840952#comment-17840952 ] ASF GitHub Bot commented on WICKET-7107: dr0ps commented on PR #846: URL: https:

Re: [PR] WICKET-7107 improved BaseWicketTester#WicketTesterServletWebResponse [wicket]

2024-04-25 Thread via GitHub
dr0ps commented on PR #846: URL: https://github.com/apache/wicket/pull/846#issuecomment-2078090021 I replaced CSPRequestCycleListener#onRequestHandlerResolved and CSPRequestCycleListener#onRequestHandlerExecuted with onUrlMapped which fixes the tests. Is the a good idea? -- This is an au

[jira] [Commented] (WICKET-7107) CSP Header not rendered when using RedirectPolicy.AUTO_REDIRECT

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840956#comment-17840956 ] ASF GitHub Bot commented on WICKET-7107: dr0ps commented on PR #846: URL: https: