Re: [PR] Small improvements in Logging [wicket]

2024-07-24 Thread via GitHub
martin-g commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1689428603 ## wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java: ## @@ -52,7 +52,8 @@ private static String detail(Componen

[jira] [Created] (WICKET-7119) 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment)

2024-07-24 Thread Kaiyao Ke (Jira)
Kaiyao Ke created WICKET-7119: - Summary: 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment) Key: WICKET-7119 URL: https://issues.apache.org/jira/browse/WICKE

[PR] [WICKET-7119] Fixed non-idempotent unit tests [wicket]

2024-07-24 Thread via GitHub
kaiyaok2 opened a new pull request, #929: URL: https://github.com/apache/wicket/pull/929 Fixes https://issues.apache.org/jira/browse/WICKET-7119 # The Problem Some unit tests are non-idempotent, as they pass in the first run but fail in the second run in the same environmen

[jira] [Commented] (WICKET-7119) 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment)

2024-07-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868419#comment-17868419 ] ASF GitHub Bot commented on WICKET-7119: kaiyaok2 opened a new pull request, #92

Re: [PR] Small improvements in Logging [wicket]

2024-07-24 Thread via GitHub
renoth commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1690308265 ## wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java: ## @@ -52,7 +52,8 @@ private static String detail(Component

Re: [PR] Small improvements in Logging [wicket]

2024-07-24 Thread via GitHub
renoth commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1690307949 ## wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java: ## @@ -372,9 +372,7 @@ protected IRequestHandler handleException(final Exception e)