(wicket) branch wicket-9.x updated: WICKET-7119 fixed non-idempotent unit tests (#929)

2024-07-30 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch wicket-9.x in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/wicket-9.x by this push: new dfa5713f9c WICKET-7119 fixed non-idem

Re: [PR] [WICKET-7119] Fixed non-idempotent unit tests [wicket]

2024-07-30 Thread via GitHub
martin-g commented on PR #929: URL: https://github.com/apache/wicket/pull/929#issuecomment-2257619329 Thank you, @kaiyaok2 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (WICKET-7119) 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment)

2024-07-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869545#comment-17869545 ] ASF subversion and git services commented on WICKET-7119: - Commi

[jira] [Resolved] (WICKET-7119) 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment)

2024-07-30 Thread Martin Tzvetanov Grigorov (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov resolved WICKET-7119. --- Fix Version/s: 9.18.0 10.2.0 Assignee: Ma

[jira] [Commented] (WICKET-7119) 5 unit tests are non-idempotent (passes in the first run but fails in subsequent runs in the same environment)

2024-07-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869546#comment-17869546 ] ASF GitHub Bot commented on WICKET-7119: martin-g commented on PR #929: URL: htt

Re: [PR] Small improvements in Logging [wicket]

2024-07-30 Thread via GitHub
martin-g commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1696428909 ## wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java: ## @@ -52,7 +52,8 @@ private static String detail(Componen

Re: [PR] Small improvements in Logging [wicket]

2024-07-30 Thread via GitHub
renoth commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1697917706 ## wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java: ## @@ -372,9 +372,7 @@ protected IRequestHandler handleException(final Exception e)

[PR] Make AutoCompleteTextField more Accessible [wicket]

2024-07-30 Thread via GitHub
renoth opened a new pull request, #933: URL: https://github.com/apache/wicket/pull/933 Autocomplete textfields arent read properly by a screenreader when selection the options with arrow keys. This PR adresses that issue. **input must have** role="combobox" aria-expanded="true/f

Re: [PR] Make AutoCompleteTextField more Accessible [wicket]

2024-07-30 Thread via GitHub
renoth commented on PR #933: URL: https://github.com/apache/wicket/pull/933#issuecomment-2259768876 Tested with NVDA 2024.2 and Firefox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi