[GitHub] [wicket] bitstorm commented on pull request #552: [WICKET-7025] package private methods are intercepted by ByteBuddy

2023-01-18 Thread GitBox
bitstorm commented on PR #552: URL: https://github.com/apache/wicket/pull/552#issuecomment-1396064575 @solomax thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [wicket] solomax commented on pull request #552: [WICKET-7025] package private methods are intercepted by ByteBuddy

2023-01-18 Thread GitBox
solomax commented on PR #552: URL: https://github.com/apache/wicket/pull/552#issuecomment-1387330832 Done, thanks! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [wicket] martin-g commented on pull request #552: [WICKET-7025] package private methods are intercepted by ByteBuddy

2023-01-18 Thread GitBox
martin-g commented on PR #552: URL: https://github.com/apache/wicket/pull/552#issuecomment-1387250034 Yes, I think it is a good idea! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [wicket] solomax commented on pull request #552: [WICKET-7025] package private methods are intercepted by ByteBuddy

2023-01-18 Thread GitBox
solomax commented on PR #552: URL: https://github.com/apache/wicket/pull/552#issuecomment-1386770348 @martin-g shall I cherry-pick this code to wicket-9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [wicket] solomax merged pull request #552: [WICKET-7025] package private methods are intercepted by ByteBuddy

2023-01-18 Thread GitBox
solomax merged PR #552: URL: https://github.com/apache/wicket/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache

[GitHub] [wicket] dependabot[bot] commented on pull request #551: Bump json5 from 2.2.0 to 2.2.3 in /testing/wicket-js-tests

2023-01-11 Thread GitBox
dependabot[bot] commented on PR #551: URL: https://github.com/apache/wicket/pull/551#issuecomment-1378571957 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [wicket] martin-g closed pull request #551: Bump json5 from 2.2.0 to 2.2.3 in /testing/wicket-js-tests

2023-01-11 Thread GitBox
martin-g closed pull request #551: Bump json5 from 2.2.0 to 2.2.3 in /testing/wicket-js-tests URL: https://github.com/apache/wicket/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [wicket] dependabot[bot] opened a new pull request, #551: Bump json5 from 2.2.0 to 2.2.3 in /testing/wicket-js-tests

2023-01-07 Thread GitBox
dependabot[bot] opened a new pull request, #551: URL: https://github.com/apache/wicket/pull/551 Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3. Release notes Sourced from https://github.com/json5/json5/releases";>json5's releases. v2.2.3 Fix: json5@2

[GitHub] [wicket] mattrpav commented on pull request #550: [WICKET-7021] Update OSGi imports for needed packages

2023-01-07 Thread GitBox
mattrpav commented on PR #550: URL: https://github.com/apache/wicket/pull/550#issuecomment-1374492114 > @mattrpav do you think we might need something similar for master branch with new Jakarta EE packages? Yep. The packages should map 1:1 (if not too much has changed in Wicket 10)

[GitHub] [wicket] bitstorm commented on pull request #550: [WICKET-7021] Update OSGi imports for needed packages

2023-01-07 Thread GitBox
bitstorm commented on PR #550: URL: https://github.com/apache/wicket/pull/550#issuecomment-1374489162 @mattrpav do you think we might need something similar for master branch with new Jakarta EE packages? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [wicket] bitstorm merged pull request #550: [WICKET-7021] Update OSGi imports for needed packages

2023-01-04 Thread GitBox
bitstorm merged PR #550: URL: https://github.com/apache/wicket/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dr0ps closed pull request #549: ListenerRequestHandler no longer hides IndexOutOfBoundsException in b…

2022-12-16 Thread GitBox
dr0ps closed pull request #549: ListenerRequestHandler no longer hides IndexOutOfBoundsException in b… URL: https://github.com/apache/wicket/pull/549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [wicket] Jezza closed pull request #297: Improve AjaxLazyLoadPanel's functionality.

2022-12-09 Thread GitBox
Jezza closed pull request #297: Improve AjaxLazyLoadPanel's functionality. URL: https://github.com/apache/wicket/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [wicket] svenmeier commented on pull request #549: ListenerRequestHandler no longer hides IndexOutOfBoundsException in b…

2022-11-18 Thread GitBox
svenmeier commented on PR #549: URL: https://github.com/apache/wicket/pull/549#issuecomment-1320392005 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [wicket] dr0ps commented on pull request #549: ListenerRequestHandler no longer hides IndexOutOfBoundsException in b…

2022-11-18 Thread GitBox
dr0ps commented on PR #549: URL: https://github.com/apache/wicket/pull/549#issuecomment-1320263007 Previously an IndexOutOfBoundsException occuring inside the behavior invocation would be wrapped in a WicketRuntimeException with the message "Couldn't find component behavior". This should on

[GitHub] [wicket] dr0ps opened a new pull request, #549: ListenerRequestHandler no longer hides IndexOutOfBoundsException in b…

2022-11-18 Thread GitBox
dr0ps opened a new pull request, #549: URL: https://github.com/apache/wicket/pull/549 …ehavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [wicket] martin-g merged pull request #548: Bump minimatch from 3.0.4 to 3.0.8 in /testing/wicket-js-tests

2022-11-17 Thread GitBox
martin-g merged PR #548: URL: https://github.com/apache/wicket/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dependabot[bot] opened a new pull request, #548: Bump minimatch from 3.0.4 to 3.0.8 in /testing/wicket-js-tests

2022-11-17 Thread GitBox
dependabot[bot] opened a new pull request, #548: URL: https://github.com/apache/wicket/pull/548 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.0.8. Commits https://github.com/isaacs/minimatch/commit/782c264e9ff4b02b41923e827726e03c1bcaec28";>782c264 3.0.

[GitHub] [wicket] bitstorm merged pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-11-12 Thread GitBox
bitstorm merged PR #546: URL: https://github.com/apache/wicket/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] renoth commented on pull request #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-08 Thread GitBox
renoth commented on PR #547: URL: https://github.com/apache/wicket/pull/547#issuecomment-1307836104 The error only occurs in our DEVELOPMENT staging environment but not in TEST or PRODUCTION, maybe that has something to do with it. Debugbar maybe? -- This is an automated message from the

[GitHub] [wicket] martin-g commented on pull request #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-02 Thread GitBox
martin-g commented on PR #547: URL: https://github.com/apache/wicket/pull/547#issuecomment-1300446402 According to https://stackoverflow.com/a/60976421/497381 it should be caused by concurrent removals. But all methods which manipulate `pages` are `synchronized` ... Maybe [#writeObjec

[GitHub] [wicket] renoth closed pull request #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-02 Thread GitBox
renoth closed pull request #547: InSessionPageStore throws IndexOutOfBoundsException URL: https://github.com/apache/wicket/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [wicket] renoth commented on pull request #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-02 Thread GitBox
renoth commented on PR #547: URL: https://github.com/apache/wicket/pull/547#issuecomment-1300414579 yes you are right, The size should not be negative. the stacktrace is ``` java.lang.IndexOutOfBoundsException: Index: 0, Size: -1 at java.util.LinkedList.checkPositionI

[GitHub] [wicket] martin-g commented on pull request #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-02 Thread GitBox
martin-g commented on PR #547: URL: https://github.com/apache/wicket/pull/547#issuecomment-1300279982 Calling `List.iterator()` on an empty list won't lead to IndexOutOfBoundsException. Is the list is `null` then the exception would be a `NullPointerException`. Please create a new

[GitHub] [wicket] renoth opened a new pull request, #547: InSessionPageStore throws IndexOutOfBoundsException

2022-11-02 Thread GitBox
renoth opened a new pull request, #547: URL: https://github.com/apache/wicket/pull/547 I have the same problem like in https://issues.apache.org/jira/browse/WICKET-6966 when using Wicket 9.11.0 and all Settings in SessionPageStore at default values. The problem does only occur in DEVELOPME

[GitHub] [wicket] timtebeek commented on pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
timtebeek commented on PR #546: URL: https://github.com/apache/wicket/pull/546#issuecomment-1292061524 Thanks for the quick review! I've kept the `AppendingStringBufferTest` changes out of this PR for now, to keep things simple. -- This is an automated message from the Apache Git Service.

[GitHub] [wicket] martin-g commented on pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
martin-g commented on PR #546: URL: https://github.com/apache/wicket/pull/546#issuecomment-1291884392 I'm fine with this solution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [wicket] timtebeek commented on pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
timtebeek commented on PR #546: URL: https://github.com/apache/wicket/pull/546#issuecomment-1291881882 Not sure if there's much we could do; the assertions end up calling: ```java static boolean objectsAreEqual(Object obj1, Object obj2) { if (obj1 == null) { retu

[GitHub] [wicket] martin-g commented on pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
martin-g commented on PR #546: URL: https://github.com/apache/wicket/pull/546#issuecomment-1291868877 > Might be worth creating a separate issue for. Is it possible to do anything about it at our side ? AppendingStringBuffer#equals() has logic to compare against any `CharSequence`

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-26 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r100529 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] timtebeek commented on pull request #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
timtebeek commented on PR #546: URL: https://github.com/apache/wicket/pull/546#issuecomment-1291631783 Might have found an issue in `AppendingStringBuffer`; [the equals method](https://github.com/apache/wicket/blob/master/wicket-util/src/main/java/org/apache/wicket/util/string/AppendingStrin

[GitHub] [wicket] timtebeek opened a new pull request, #546: WICKET-7011 Swap assertion arguments to conform to expected vs actual

2022-10-26 Thread GitBox
timtebeek opened a new pull request, #546: URL: https://github.com/apache/wicket/pull/546 https://issues.apache.org/jira/browse/WICKET-7011 https://github.com/openrewrite/rewrite-testing-frameworks/pull/277 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-22 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1002499905 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] martin-g commented on pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286896241 Thank you, @vandeven & @timtebeek ! Please use https://issues.apache.org/jira/browse/WICKET-7011 as a ticket reference for any further work on this topic! -- This is an automated m

[GitHub] [wicket] martin-g merged pull request #545: WICKET-7011: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g merged PR #545: URL: https://github.com/apache/wicket/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001597087 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] timtebeek commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001595216 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] solomax commented on a diff in pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
solomax commented on code in PR #545: URL: https://github.com/apache/wicket/pull/545#discussion_r1001574012 ## wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java: ## @@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception

[GitHub] [wicket] martin-g commented on pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
martin-g commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286655770 > Would you appreciate a few more such automated fixes? Sure! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] timtebeek commented on pull request #545: Cleanup JUnit 5 assertions

2022-10-21 Thread GitBox
timtebeek commented on PR #545: URL: https://github.com/apache/wicket/pull/545#issuecomment-1286628517 Glad to see this approved so quickly @martin-g ! :) Would you appreciate a few more such automated fixes? I understand it's a fine balance to not overwhelm you with review requests when

[GitHub] [wicket] vandeven opened a new pull request, #545: Cleanup JUnit 5 assertions

2022-10-20 Thread GitBox
vandeven opened a new pull request, #545: URL: https://github.com/apache/wicket/pull/545 Ran the Clean Up Assertions recipe from the OpenRewrite project (https://docs.openrewrite.org/reference/recipes/java/testing/junit5/cleanupassertions version 1.30.0). Had to do 1 manual change to

[GitHub] [wicket] martin-g merged pull request #544: WICKET-7009: Bump jackson-databind from 2.10.5 to 2.13.4.1

2022-10-18 Thread GitBox
martin-g merged PR #544: URL: https://github.com/apache/wicket/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dependabot[bot] commented on pull request #520: Bump jackson-databind from 2.10.5 to 2.12.6.1

2022-10-18 Thread GitBox
dependabot[bot] commented on PR #520: URL: https://github.com/apache/wicket/pull/520#issuecomment-1282907455 Superseded by #544. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [wicket] dependabot[bot] closed pull request #520: Bump jackson-databind from 2.10.5 to 2.12.6.1

2022-10-18 Thread GitBox
dependabot[bot] closed pull request #520: Bump jackson-databind from 2.10.5 to 2.12.6.1 URL: https://github.com/apache/wicket/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [wicket] dependabot[bot] opened a new pull request, #544: Bump jackson-databind from 2.10.5 to 2.13.4.1

2022-10-18 Thread GitBox
dependabot[bot] opened a new pull request, #544: URL: https://github.com/apache/wicket/pull/544 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.5 to 2.13.4.1. Commits See full diff in https://github.com/FasterXML/jackson/commits";>compare view

[GitHub] [wicket] dependabot[bot] closed pull request #519: Bump ejs from 3.1.6 to 3.1.7 in /testing/wicket-js-tests

2022-10-10 Thread GitBox
dependabot[bot] closed pull request #519: Bump ejs from 3.1.6 to 3.1.7 in /testing/wicket-js-tests URL: https://github.com/apache/wicket/pull/519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [wicket] dependabot[bot] commented on pull request #519: Bump ejs from 3.1.6 to 3.1.7 in /testing/wicket-js-tests

2022-10-10 Thread GitBox
dependabot[bot] commented on PR #519: URL: https://github.com/apache/wicket/pull/519#issuecomment-1273115996 Superseded by #543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [wicket] dependabot[bot] opened a new pull request, #543: Bump ejs from 3.1.6 to 3.1.8 in /testing/wicket-js-tests

2022-10-10 Thread GitBox
dependabot[bot] opened a new pull request, #543: URL: https://github.com/apache/wicket/pull/543 Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.8. Release notes Sourced from https://github.com/mde/ejs/releases";>ejs's releases. v3.1.8 Version 3.1.8 v3.1.7

[GitHub] [wicket] martin-g merged pull request #542: Bump async from 2.6.3 to 3.2.3 in /testing/wicket-js-tests

2022-10-10 Thread GitBox
martin-g merged PR #542: URL: https://github.com/apache/wicket/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dependabot[bot] opened a new pull request, #542: Bump async from 2.6.3 to 3.2.3 in /testing/wicket-js-tests

2022-10-07 Thread GitBox
dependabot[bot] opened a new pull request, #542: URL: https://github.com/apache/wicket/pull/542 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 3.2.3. Changelog Sourced from https://github.com/caolan/async/blob/master/CHANGELOG.md";>async's changelog. v3.2.3

[GitHub] [wicket] bitstorm merged pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-07 Thread GitBox
bitstorm merged PR #540: URL: https://github.com/apache/wicket/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] tenbeitelh commented on pull request #541: WICKET-7008 toString() should reflect the actual variable name

2022-10-07 Thread GitBox
tenbeitelh commented on PR #541: URL: https://github.com/apache/wicket/pull/541#issuecomment-1271308489 @bitstorm with pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [wicket] bitstorm commented on pull request #541: WICKET-7008 toString() should reflect the actual variable name

2022-10-07 Thread GitBox
bitstorm commented on PR #541: URL: https://github.com/apache/wicket/pull/541#issuecomment-1271291094 @tenbeitelh thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [wicket] bitstorm merged pull request #541: WICKET-7008 toString() should reflect the actual variable name

2022-10-07 Thread GitBox
bitstorm merged PR #541: URL: https://github.com/apache/wicket/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] bitstorm closed pull request #541: toString() should reflect the actual variable name

2022-10-07 Thread GitBox
bitstorm closed pull request #541: toString() should reflect the actual variable name URL: https://github.com/apache/wicket/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [wicket] mattrpav commented on a diff in pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-06 Thread GitBox
mattrpav commented on code in PR #540: URL: https://github.com/apache/wicket/pull/540#discussion_r989098172 ## wicket/src/main/filtered-resources/features.xml: ## @@ -0,0 +1,18 @@ + Review Comment: This is completed, and I added a reference section to the wicket-user-guide

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-06 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1270109123 Updated user guide w/ Apache Karaf feature info https://user-images.githubusercontent.com/512119/19456-c5f42c4b-759d-4ed7-998d-b7716970b51b.png";> -- This is an automated me

[GitHub] [wicket] mattrpav commented on a diff in pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-05 Thread GitBox
mattrpav commented on code in PR #540: URL: https://github.com/apache/wicket/pull/540#discussion_r985796876 ## pom.xml: ## @@ -891,18 +894,19 @@ true

[GitHub] [wicket] martin-g commented on a diff in pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-05 Thread GitBox
martin-g commented on code in PR #540: URL: https://github.com/apache/wicket/pull/540#discussion_r985722371 ## pom.xml: ## @@ -891,18 +894,19 @@ true

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-10-01 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1264459712 Let me get a couple more done. For sure we should have the web socket bundles in good shape -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263997555 > > Generally, things like 'internal' are not exported since they are not part of a proper API or SPI. > > In OSGi world it is indeed. But as I wrote in description in Wicket they ar

[GitHub] [wicket] dstoch commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
dstoch commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263991579 > Generally, things like 'internal' are not exported since they are not part of a proper API or SPI. In OSGi world it is indeed. But as I wrote in description in Wicket they are part o

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263988806 > I described a problem in this issue description in JIRA. Eg. without exporting org.apache.wicket.markup.html.internal package is not possible to use Wicket in OSGi. Do you really use it i

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263970031 > I described a problem in this issue description in JIRA. Eg. without exporting org.apache.wicket.markup.html.internal package is not possible to use Wicket in OSGi. Do you really use it i

[GitHub] [wicket] dstoch commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
dstoch commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263964567 I described a problem in this issue description in JIRA. Eg. without exporting org.apache.wicket.markup.html.internal package is not possible to use Wicket in OSGi. Do you really use it in OS

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263959524 > MANIFESTs are broken since Wicket 8.x, so it is not a good evidence ;). What is broken? We've been running unmodified bundles on Wicket 8.x for years. -- This is an automated mes

[GitHub] [wicket] dstoch commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
dstoch commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263950659 > @dstoch the actual _application_ bundle would need to do that as they require. Further backing evidence is the Wicket 8.x bundles do not have 'DynamicImport-Package: *' specified. MA

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263945374 > > I've removed the DynamicImport-Package: * rule. I think that should only be needed by the application wars to support modular pages and allow Wicket to instantiate those classes from th

[GitHub] [wicket] dstoch commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
dstoch commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263934816 > I've removed the DynamicImport-Package: * rule. I think that should only be needed by the application wars to support modular pages and allow Wicket to instantiate those classes from the wa

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263915218 I've removed the DynamicImport-Package: * rule. I think that should only be needed by the application wars to support modular pages and allow Wicket to instantiate those classes from the wa

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263893361 NOTE: Generate export packages list for wicket-core ``` % find . -name "*.java" -exec grep "^package" {} \; | cut -f2 -d" " | sort -u ``` -- This is an automated message from

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263883424 wicket-request: ``` Export-Package = org.apache.wicket.request;version=10.0.0, org.apache.wicket.request.flow;version=10.0.0, org.apache.wicket.request.hand

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263869054 Commit f2edd61 fixes bundle plugin execution phase+goal to generate correct MANIFEST and allow for enforcer plugin to be maintained. -- This is an automated message from the Apache Git Se

[GitHub] [wicket] mattrpav commented on pull request #540: [WICKET-6999] Update bundle plugin to support slf4j [1.7,3)

2022-09-30 Thread GitBox
mattrpav commented on PR #540: URL: https://github.com/apache/wicket/pull/540#issuecomment-1263843086 At issue is the bundle plugin runs different at various maven phases. When combined with the enforcer plugin to restrict config to an execution, the bundle plugin definition will get chatty

[GitHub] [wicket] martin-g commented on pull request #539: Fix apache/wicket#WICKET-7007

2022-09-26 Thread GitBox
martin-g commented on PR #539: URL: https://github.com/apache/wicket/pull/539#issuecomment-1258009573 Thank you, @brbog ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [wicket] martin-g merged pull request #539: Fix apache/wicket#WICKET-7007

2022-09-26 Thread GitBox
martin-g merged PR #539: URL: https://github.com/apache/wicket/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] brbog opened a new pull request, #539: Fix apache/wicket#WICKET-7007

2022-09-26 Thread GitBox
brbog opened a new pull request, #539: URL: https://github.com/apache/wicket/pull/539 Links to issue https://issues.apache.org/jira/browse/WICKET-7007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [wicket] bitstorm merged pull request #538: Fix apache/wicket#WICKET-7004

2022-09-18 Thread GitBox
bitstorm merged PR #538: URL: https://github.com/apache/wicket/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] brbog commented on pull request #538: Fix apache/wicket#WICKET-7004

2022-09-14 Thread GitBox
brbog commented on PR #538: URL: https://github.com/apache/wicket/pull/538#issuecomment-1247653357 Links to issue https://issues.apache.org/jira/browse/WICKET-7004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [wicket] brbog commented on pull request #538: Fix apache/wicket#WICKET-7004

2022-09-14 Thread GitBox
brbog commented on PR #538: URL: https://github.com/apache/wicket/pull/538#issuecomment-1247274920 Making a pull request to the 9.x branch seems more logical, but not sure how to achieve that. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [wicket] brbog opened a new pull request, #538: Fix apache/wicket#WICKET-7004

2022-09-14 Thread GitBox
brbog opened a new pull request, #538: URL: https://github.com/apache/wicket/pull/538 Make example Jetty configuration expose less information about the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [wicket] brbog closed pull request #537: Fix apache/wicket#WICKET-7004

2022-09-14 Thread GitBox
brbog closed pull request #537: Fix apache/wicket#WICKET-7004 URL: https://github.com/apache/wicket/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [wicket] brbog opened a new pull request, #537: Fix apache/wicket#WICKET-7004

2022-09-14 Thread GitBox
brbog opened a new pull request, #537: URL: https://github.com/apache/wicket/pull/537 Make example Jetty configuration expose less information about the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [wicket] dashorst merged pull request #532: WICKET-7002 Remove blocking code from Application#get/setMetaData (10.x)

2022-09-05 Thread GitBox
dashorst merged PR #532: URL: https://github.com/apache/wicket/pull/532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dashorst merged pull request #536: WICKET-7002 Remove blocking code from Application#get/setMetaData (8.x)

2022-09-05 Thread GitBox
dashorst merged PR #536: URL: https://github.com/apache/wicket/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dashorst merged pull request #535: WICKET-7002 Remove blocking code from Application#get/setMetaData (9.x)

2022-09-05 Thread GitBox
dashorst merged PR #535: URL: https://github.com/apache/wicket/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dashorst opened a new pull request, #536: WICKET-7002 Remove blocking code from Application#get/setMetaData

2022-09-03 Thread GitBox
dashorst opened a new pull request, #536: URL: https://github.com/apache/wicket/pull/536 By replacing the datastructure for Application class's metaData field with a ConcurrentHashMap we can remove the synchronization on the application instance and speed up lookups of the metadata. For

[GitHub] [wicket] dashorst opened a new pull request, #535: WICKET-7002 Remove blocking code from Application#get/setMetaData

2022-09-03 Thread GitBox
dashorst opened a new pull request, #535: URL: https://github.com/apache/wicket/pull/535 By replacing the datastructure for Application class's metaData field with a ConcurrentHashMap we can remove the synchronization on the application instance and speed up lookups of the metadata. For

[GitHub] [wicket] dashorst closed pull request #534: WICKET 7002 9.x

2022-09-03 Thread GitBox
dashorst closed pull request #534: WICKET 7002 9.x URL: https://github.com/apache/wicket/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [wicket] dashorst opened a new pull request, #534: WICKET 7002 9.x

2022-09-03 Thread GitBox
dashorst opened a new pull request, #534: URL: https://github.com/apache/wicket/pull/534 - Changed release script to use branch wicket-9.x - WICKET-6883 updated chapter 8 to reflect page storing changes - WICKET-6884 Trigger build to rebuild apidocs - WICKET-6884 Trigger build to reb

[GitHub] [wicket] bitstorm merged pull request #524: The http RequestLogger is very expensive.

2022-09-03 Thread GitBox
bitstorm merged PR #524: URL: https://github.com/apache/wicket/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dashorst closed pull request #533: Wicket 7002

2022-09-02 Thread GitBox
dashorst closed pull request #533: Wicket 7002 URL: https://github.com/apache/wicket/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [wicket] theigl commented on pull request #532: WICKET-7002 Remove blocking code from Application#get/setMetaData

2022-09-02 Thread GitBox
theigl commented on PR #532: URL: https://github.com/apache/wicket/pull/532#issuecomment-1235724292 I think this change makes a lot of sense. I just debugged my app and this synchronized method is hit about 100 times per request on my larger pages. -- This is an automated message from the

[GitHub] [wicket] dashorst opened a new pull request, #532: WICKET-7002 Remove blocking code from Application#get/setMetaData

2022-09-02 Thread GitBox
dashorst opened a new pull request, #532: URL: https://github.com/apache/wicket/pull/532 By replacing the datastructure for Application class's metaData field with a ConcurrentHashMap we can remove the synchronization on the application instance and speed up lookups of the metadata. For

[GitHub] [wicket] martin-g merged pull request #531: Bump minimist from 1.2.5 to 1.2.6 in /testing/wicket-js-tests

2022-08-22 Thread GitBox
martin-g merged PR #531: URL: https://github.com/apache/wicket/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dependabot[bot] opened a new pull request, #531: Bump minimist from 1.2.5 to 1.2.6 in /testing/wicket-js-tests

2022-08-22 Thread GitBox
dependabot[bot] opened a new pull request, #531: URL: https://github.com/apache/wicket/pull/531 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7efb22a 1.2

[GitHub] [wicket] rkurucz9 closed pull request #471: WICKET-6888 ToggleableDataTable

2022-07-27 Thread GitBox
rkurucz9 closed pull request #471: WICKET-6888 ToggleableDataTable URL: https://github.com/apache/wicket/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [wicket] Serranya commented on pull request #529: WICKET-6993 - Resource Variations containing a single character are not correctly decoded

2022-07-18 Thread GitBox
Serranya commented on PR #529: URL: https://github.com/apache/wicket/pull/529#issuecomment-1187055095 Hello, could I get any feedback regarding this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [wicket] martin-g merged pull request #530: Bump jetty-server from 11.0.7 to 11.0.10

2022-07-13 Thread GitBox
martin-g merged PR #530: URL: https://github.com/apache/wicket/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apach

[GitHub] [wicket] dependabot[bot] opened a new pull request, #530: Bump jetty-server from 11.0.7 to 11.0.10

2022-07-07 Thread GitBox
dependabot[bot] opened a new pull request, #530: URL: https://github.com/apache/wicket/pull/530 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 11.0.7 to 11.0.10. Release notes Sourced from https://github.com/eclipse/jetty.project/releases";>jetty-server's rele

  1   2   3   4   5   >