rkurucz9 commented on pull request #471:
URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236
> I've taken a second look and actually your solution is very good. You
clearly have understood how to work with components :).
>
> My major grieve is how the collection of
rkurucz9 commented on pull request #471:
URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236
> I've taken a second look and actually your solution is very good. You
clearly have understood how to work with components :).
>
> My major grieve is how the collection of
martin-g opened a new pull request #474:
URL: https://github.com/apache/wicket/pull/474
This PR makes Wicket 9.x fully (?!) supporting Java 9+ module system.
I decided to use 9.x instead of 10.x because this way it will be easier to
test it with our production applications.
If the
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-872261034
// CC @jonathanlocke @svenmeier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-872263147
TODO JPMS-fy the http2 modules. I decided to do it in separate commit so
that it is easier to cherry-pick in 10.x where those were merged to -core.
--
This is an automated messa
bitstorm commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-873088551
I see you did also some code clean-up (for util classes for example). Good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-873130716
Not really a cleanup.
I needed to move some test classes to unique packages.
We have a test for this in testing/common-testts but it covers just the
main sources.
JPMS c
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663311532
##
File path: pom.xml
##
@@ -142,6 +142,7 @@
3.2.2
4.4
1.4
+
Review comment:
I guess this one can be
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663816604
##
File path: pom.xml
##
@@ -142,6 +142,7 @@
3.2.2
4.4
1.4
+
Review comment:
Done!
--
This is a
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663817735
##
File path: pom.xml
##
@@ -169,7 +170,7 @@
3.11.1
3.2
1.0.12
- 1.7.25
+ 2.0.0-
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r664354043
##
File path: pom.xml
##
@@ -169,7 +170,7 @@
3.11.1
3.2
1.0.12
- 1.7.25
+ 2.0.0-a
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663816604
##
File path: pom.xml
##
@@ -142,6 +142,7 @@
3.2.2
4.4
1.4
+
Review comment:
Done!
##
File
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r664354043
##
File path: pom.xml
##
@@ -169,7 +170,7 @@
3.11.1
3.2
1.0.12
- 1.7.25
+ 2.0.0-a
solomax opened a new pull request #475:
URL: https://github.com/apache/wicket/pull/475
The only issue I'm observing so far: All links to JDK classes points to
Java8 API .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
martin-g commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r666932739
##
File path: testing/wicket-threadtest/src/site/site.xml
##
@@ -16,9 +16,4 @@
limitations under the License.
-->
-
- org.apache
solomax commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r666934748
##
File path: testing/wicket-threadtest/src/site/site.xml
##
@@ -16,9 +16,4 @@
limitations under the License.
-->
-
- org.apache.
martin-g commented on pull request #475:
URL: https://github.com/apache/wicket/pull/475#issuecomment-877179810
If this fixes the javadoc issue then you could use WICKET-6884 in the title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
solomax commented on pull request #475:
URL: https://github.com/apache/wicket/pull/475#issuecomment-877217210
The result of `mvn clean deploy javadoc:aggregate-no-fork` can be checked
here: https://ci-builds.apache.org/job/Wicket/job/wicket-9.x/javadoc/
--
This is an automated message fr
solomax commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r667267759
##
File path: pom.xml
##
@@ -1020,7 +1020,6 @@
true
none
solomax merged pull request #475:
URL: https://github.com/apache/wicket/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
martin-g commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r667522677
##
File path: pom.xml
##
@@ -1020,7 +1020,6 @@
true
none
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-881433068
I've tested this branch in a real application both with Tomcat 9.0.50 and
Jetty 10.0.6.
I didn't find any issue with the application related to JPMS.
My only concern bef
martin-g merged pull request #474:
URL: https://github.com/apache/wicket/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
martin-g opened a new pull request #476:
URL: https://github.com/apache/wicket/pull/476
CGLib is not well maintained and it does not work with JDK 17+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
martin-g merged pull request #476:
URL: https://github.com/apache/wicket/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
nileshsachdeva opened a new pull request #477:
URL: https://github.com/apache/wicket/pull/477
ccvdsfdcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
martin-g closed pull request #477:
URL: https://github.com/apache/wicket/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
mat128 opened a new pull request #478:
URL: https://github.com/apache/wicket/pull/478
Currently, MultipartFormComponentListener ensures form enctype is
correct on the client-side when visibility for multipart-enabling
components is toggled. It does so by visiting all form components,
martin-g merged pull request #478:
URL: https://github.com/apache/wicket/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
martin-g commented on pull request #478:
URL: https://github.com/apache/wicket/pull/478#issuecomment-924021309
Thank you, @mat128 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bitstorm closed pull request #473:
URL: https://github.com/apache/wicket/pull/473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr..
bitstorm commented on pull request #473:
URL: https://github.com/apache/wicket/pull/473#issuecomment-962179542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reiern70 commented on a change in pull request #469:
URL: https://github.com/apache/wicket/pull/469#discussion_r744097433
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/HomePage.html
##
@@ -29,6 +29,7 @@
reiern70 commented on a change in pull request #469:
URL: https://github.com/apache/wicket/pull/469#discussion_r744097486
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##
@@ -50,6 +50,7 @@ public void init()
reiern70 commented on a change in pull request #469:
URL: https://github.com/apache/wicket/pull/469#discussion_r744097639
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed
reiern70 commented on a change in pull request #469:
URL: https://github.com/apache/wicket/pull/469#discussion_r744097689
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #469:
URL: https://github.com/apache/wicket/pull/469#discussion_r744097999
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the
reiern70 commented on pull request #469:
URL: https://github.com/apache/wicket/pull/469#issuecomment-962416580
@martin-g thanks for review. Implemented suggested changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
reiern70 opened a new pull request #479:
URL: https://github.com/apache/wicket/pull/479
This PR adds some extra functionality to WS implementation. Not sure if this
can be done in a cleaner way or a more general one. This adds.
- Allows to avoid sending "empty" web socket push messag
reiern70 closed pull request #469:
URL: https://github.com/apache/wicket/pull/469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
reiern70 commented on pull request #469:
URL: https://github.com/apache/wicket/pull/469#issuecomment-962574206
Superseded by
https://github.com/apache/wicket/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-962576011
@martin-g Not very sure about the pageCLass I have introduced. Maybe call
this "context"? i.e. page class is just a. context?
--
This is an automated message from the Apache Git
DisasterMo opened a new pull request #480:
URL: https://github.com/apache/wicket/pull/480
## Description
In the Wicket User Guide the _adjective_ 'determinate' is being used as a
verb. Those instances are now replaced with the actual verb 'to determine'.
## JIRA
Fixes W
martin-g commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744544608
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Soft
martin-g merged pull request #480:
URL: https://github.com/apache/wicket/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
martin-g commented on pull request #480:
URL: https://github.com/apache/wicket/pull/480#issuecomment-963008488
Thank you, @DisasterMo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-963049609
@martin-g many thanks for your comments! I will go through them right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-963054657
> About the new `pageClass` attribute:
>
> * PageIdKey is no more accurate name, since it is not just the `id`
anymore. But renaming it would be an API break
> * What is
reiern70 edited a comment on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-963054657
> About the new `pageClass` attribute:
>
> * PageIdKey is no more accurate name, since it is not just the `id`
anymore. But renaming it would be an API break
> * W
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744633522
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Soft
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744637086
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Soft
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744637255
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744641650
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744643439
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744644384
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744644484
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744647012
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java
##
@@ -109
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r744710596
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java
##
@@ -97,7
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r745323108
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/IWebSocketConnectionRegistry.java
#
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r745324550
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/PageIdKey.java
##
@@ -25,9 +28,
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r745324877
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/PageIdKey.java
##
@@ -25,9 +28,
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r745325353
##
File path:
wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
##
@@ -56,6 +57,7
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-963860667
@martin-g I have moved context to IKey. See
https://github.com/apache/wicket/pull/479/commits/74bea3b3cf62ccf640a5d9e1e40b3eae359d32f2
--
This is an automate
martin-g commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r746593713
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Soft
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747238529
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/BaseWebSocketBehavior.java
##
@@ -120,9
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747239357
##
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/IKey.java
##
@@ -23,4 +23,9 @@
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747246759
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747246898
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747248123
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licen
reiern70 commented on a change in pull request #479:
URL: https://github.com/apache/wicket/pull/479#discussion_r747251280
##
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licen
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-966095373
@martin-g Many thanks for review and useful comments! I will squash commits
and merge to wicket 9.x.
--
This is an automated message from the Apache Git Service.
To respond to t
martin-g commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-966097015
And cherry-pick the final commit to `master` please!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
reiern70 merged pull request #479:
URL: https://github.com/apache/wicket/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
reiern70 commented on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-966170799
> And cherry-pick the final commit to `master` please!
Done! Thanks again for your help!
--
This is an automated message from the Apache Git Service.
To respond to the mes
solomax commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r748838235
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pub
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r748852273
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
martin-g commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r748902761
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##
@@ -46,11 +46,21 @@
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749019077
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749020586
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##
@@ -46,11 +46,21 @@
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749020964
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
martin-g commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749109202
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749117687
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749117687
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
martin-g commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749123231
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
martin-g commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749124609
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##
@@ -46,11 +46,21 @@
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749204276
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##
@@ -46,11 +46,21 @@
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r750131665
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##
@@ -46,11 +46,21 @@
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r750147103
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r750147725
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -44,17 +46,18 @@ pu
reiern70 commented on pull request #481:
URL: https://github.com/apache/wicket/pull/481#issuecomment-972656891
> Please create a JIRA ticket
https://issues.apache.org/jira/browse/WICKET-6935
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
reiern70 commented on pull request #481:
URL: https://github.com/apache/wicket/pull/481#issuecomment-972664149
@martin-g squashed all commits into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reiern70 merged pull request #481:
URL: https://github.com/apache/wicket/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
martin-g commented on a change in pull request #482:
URL: https://github.com/apache/wicket/pull/482#discussion_r752046172
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -73,16 +68,16 @@ pr
reiern70 closed pull request #483:
URL: https://github.com/apache/wicket/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
reiern70 commented on a change in pull request #482:
URL: https://github.com/apache/wicket/pull/482#discussion_r752205791
##
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##
@@ -73,16 +68,16 @@ pr
reiern70 commented on pull request #482:
URL: https://github.com/apache/wicket/pull/482#issuecomment-972834645
@martin-g many thanks for review. Landed in master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
reiern70 merged pull request #482:
URL: https://github.com/apache/wicket/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
froque opened a new pull request #485:
URL: https://github.com/apache/wicket/pull/485
- [ ] This should be backported to versions 7, 8 and 9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
reiern70 merged pull request #485:
URL: https://github.com/apache/wicket/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
martin-g commented on pull request #485:
URL: https://github.com/apache/wicket/pull/485#issuecomment-976224924
Downported it to 8.x and 9.x. It does not apply for 7.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
1 - 100 of 463 matches
Mail list logo