[GitHub] [wicket] rkurucz9 commented on pull request #471: WICKET-6888 ToggleableDataTable

rkurucz9 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236 > I've taken a second look and actually your solution is very good. You clearly have understood how to work with components :). > > My major grieve is how the collection of

[GitHub] [wicket] rkurucz9 commented on pull request #471: WICKET-6888 ToggleableDataTable

rkurucz9 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236 > I've taken a second look and actually your solution is very good. You clearly have understood how to work with components :). > > My major grieve is how the collection of

[GitHub] [wicket] martin-g opened a new pull request #474: Java 9+ module-aware Wicket 9.x

martin-g opened a new pull request #474: URL: https://github.com/apache/wicket/pull/474 This PR makes Wicket 9.x fully (?!) supporting Java 9+ module system. I decided to use 9.x instead of 10.x because this way it will be easier to test it with our production applications. If the

[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on pull request #474: URL: https://github.com/apache/wicket/pull/474#issuecomment-872261034 // CC @jonathanlocke @svenmeier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on pull request #474: URL: https://github.com/apache/wicket/pull/474#issuecomment-872263147 TODO JPMS-fy the http2 modules. I decided to do it in separate commit so that it is easier to cherry-pick in 10.x where those were merged to -core. -- This is an automated messa

[GitHub] [wicket] bitstorm commented on pull request #474: Java 9+ module-aware Wicket 9.x

bitstorm commented on pull request #474: URL: https://github.com/apache/wicket/pull/474#issuecomment-873088551 I see you did also some code clean-up (for util classes for example). Good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on pull request #474: URL: https://github.com/apache/wicket/pull/474#issuecomment-873130716 Not really a cleanup. I needed to move some test classes to unique packages. We have a test for this in testing/common-testts but it covers just the main sources. JPMS c

[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

solomax commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r663311532 ## File path: pom.xml ## @@ -142,6 +142,7 @@ 3.2.2 4.4 1.4 + Review comment: I guess this one can be

[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r663816604 ## File path: pom.xml ## @@ -142,6 +142,7 @@ 3.2.2 4.4 1.4 + Review comment: Done! -- This is a

[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r663817735 ## File path: pom.xml ## @@ -169,7 +170,7 @@ 3.11.1 3.2 1.0.12 - 1.7.25 + 2.0.0-

[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

solomax commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r664354043 ## File path: pom.xml ## @@ -169,7 +170,7 @@ 3.11.1 3.2 1.0.12 - 1.7.25 + 2.0.0-a

[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r663816604 ## File path: pom.xml ## @@ -142,6 +142,7 @@ 3.2.2 4.4 1.4 + Review comment: Done! ## File

[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

solomax commented on a change in pull request #474: URL: https://github.com/apache/wicket/pull/474#discussion_r664354043 ## File path: pom.xml ## @@ -169,7 +170,7 @@ 3.11.1 3.2 1.0.12 - 1.7.25 + 2.0.0-a

[GitHub] [wicket] solomax opened a new pull request #475: no jira: javadoc:aggregate seems to work locally

solomax opened a new pull request #475: URL: https://github.com/apache/wicket/pull/475 The only issue I'm observing so far: All links to JDK classes points to Java8 API . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [wicket] martin-g commented on a change in pull request #475: no jira: javadoc:aggregate seems to work locally

martin-g commented on a change in pull request #475: URL: https://github.com/apache/wicket/pull/475#discussion_r666932739 ## File path: testing/wicket-threadtest/src/site/site.xml ## @@ -16,9 +16,4 @@ limitations under the License. --> - - org.apache

[GitHub] [wicket] solomax commented on a change in pull request #475: no jira: javadoc:aggregate seems to work locally

solomax commented on a change in pull request #475: URL: https://github.com/apache/wicket/pull/475#discussion_r666934748 ## File path: testing/wicket-threadtest/src/site/site.xml ## @@ -16,9 +16,4 @@ limitations under the License. --> - - org.apache.

[GitHub] [wicket] martin-g commented on pull request #475: no jira: javadoc:aggregate seems to work locally

martin-g commented on pull request #475: URL: https://github.com/apache/wicket/pull/475#issuecomment-877179810 If this fixes the javadoc issue then you could use WICKET-6884 in the title -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [wicket] solomax commented on pull request #475: no jira: javadoc:aggregate seems to work locally

solomax commented on pull request #475: URL: https://github.com/apache/wicket/pull/475#issuecomment-877217210 The result of `mvn clean deploy javadoc:aggregate-no-fork` can be checked here: https://ci-builds.apache.org/job/Wicket/job/wicket-9.x/javadoc/ -- This is an automated message fr

[GitHub] [wicket] solomax commented on a change in pull request #475: WICKET-6884: javadoc:aggregate seems to work locally

solomax commented on a change in pull request #475: URL: https://github.com/apache/wicket/pull/475#discussion_r667267759 ## File path: pom.xml ## @@ -1020,7 +1020,6 @@ true none

[GitHub] [wicket] solomax merged pull request #475: WICKET-6884: javadoc:aggregate seems to work locally

solomax merged pull request #475: URL: https://github.com/apache/wicket/pull/475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [wicket] martin-g commented on a change in pull request #475: WICKET-6884: javadoc:aggregate seems to work locally

martin-g commented on a change in pull request #475: URL: https://github.com/apache/wicket/pull/475#discussion_r667522677 ## File path: pom.xml ## @@ -1020,7 +1020,6 @@ true none

[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x

martin-g commented on pull request #474: URL: https://github.com/apache/wicket/pull/474#issuecomment-881433068 I've tested this branch in a real application both with Tomcat 9.0.50 and Jetty 10.0.6. I didn't find any issue with the application related to JPMS. My only concern bef

[GitHub] [wicket] martin-g merged pull request #474: Java 9+ module-aware Wicket 9.x

martin-g merged pull request #474: URL: https://github.com/apache/wicket/pull/474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] martin-g opened a new pull request #476: WICKET-6913 Replace CGLib with ByteBuddy

martin-g opened a new pull request #476: URL: https://github.com/apache/wicket/pull/476 CGLib is not well maintained and it does not work with JDK 17+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [wicket] martin-g merged pull request #476: WICKET-6913 Replace CGLib with ByteBuddy

martin-g merged pull request #476: URL: https://github.com/apache/wicket/pull/476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] nileshsachdeva opened a new pull request #477: abcd

nileshsachdeva opened a new pull request #477: URL: https://github.com/apache/wicket/pull/477 ccvdsfdcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [wicket] martin-g closed pull request #477: abcd

martin-g closed pull request #477: URL: https://github.com/apache/wicket/pull/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] mat128 opened a new pull request #478: WICKET-6921 Avoid updating hidden forms

mat128 opened a new pull request #478: URL: https://github.com/apache/wicket/pull/478 Currently, MultipartFormComponentListener ensures form enctype is correct on the client-side when visibility for multipart-enabling components is toggled. It does so by visiting all form components,

[GitHub] [wicket] martin-g merged pull request #478: WICKET-6921 Avoid updating hidden forms

martin-g merged pull request #478: URL: https://github.com/apache/wicket/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] martin-g commented on pull request #478: WICKET-6921 Avoid updating hidden forms

martin-g commented on pull request #478: URL: https://github.com/apache/wicket/pull/478#issuecomment-924021309 Thank you, @mat128 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [wicket] bitstorm closed pull request #473: WICKET-6895: Links to examples in documentation points to old version of 8x

bitstorm closed pull request #473: URL: https://github.com/apache/wicket/pull/473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [wicket] bitstorm commented on pull request #473: WICKET-6895: Links to examples in documentation points to old version of 8x

bitstorm commented on pull request #473: URL: https://github.com/apache/wicket/pull/473#issuecomment-962179542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r744097433 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/HomePage.html ## @@ -29,6 +29,7 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r744097486 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java ## @@ -50,6 +50,7 @@ public void init()

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r744097639 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java ## @@ -0,0 +1,133 @@ +/* + * Licensed

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r744097689 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r744097999 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on pull request #469: URL: https://github.com/apache/wicket/pull/469#issuecomment-962416580 @martin-g thanks for review. Implemented suggested changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [wicket] reiern70 opened a new pull request #479: Wicket 6930 websocket improvements

reiern70 opened a new pull request #479: URL: https://github.com/apache/wicket/pull/479 This PR adds some extra functionality to WS implementation. Not sure if this can be done in a cleaner way or a more general one. This adds. - Allows to avoid sending "empty" web socket push messag

[GitHub] [wicket] reiern70 closed pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 closed pull request #469: URL: https://github.com/apache/wicket/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] reiern70 commented on pull request #469: create demo page showing how to use push in order to update a compone…

reiern70 commented on pull request #469: URL: https://github.com/apache/wicket/pull/469#issuecomment-962574206 Superseded by https://github.com/apache/wicket/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-962576011 @martin-g Not very sure about the pageCLass I have introduced. Maybe call this "context"? i.e. page class is just a. context? -- This is an automated message from the Apache Git

[GitHub] [wicket] DisasterMo opened a new pull request #480: Change wrong 'to determinate' into correct 'to determine'

DisasterMo opened a new pull request #480: URL: https://github.com/apache/wicket/pull/480 ## Description In the Wicket User Guide the _adjective_ 'determinate' is being used as a verb. Those instances are now replaced with the actual verb 'to determine'. ## JIRA Fixes W

[GitHub] [wicket] martin-g commented on a change in pull request #479: Wicket 6930 websocket improvements

martin-g commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744544608 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Soft

[GitHub] [wicket] martin-g merged pull request #480: Change wrong 'to determinate' into correct 'to determine'

martin-g merged pull request #480: URL: https://github.com/apache/wicket/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] martin-g commented on pull request #480: Change wrong 'to determinate' into correct 'to determine'

martin-g commented on pull request #480: URL: https://github.com/apache/wicket/pull/480#issuecomment-963008488 Thank you, @DisasterMo ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-963049609 @martin-g many thanks for your comments! I will go through them right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-963054657 > About the new `pageClass` attribute: > > * PageIdKey is no more accurate name, since it is not just the `id` anymore. But renaming it would be an API break > * What is

[GitHub] [wicket] reiern70 edited a comment on pull request #479: Wicket 6930 websocket improvements

reiern70 edited a comment on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-963054657 > About the new `pageClass` attribute: > > * PageIdKey is no more accurate name, since it is not just the `id` anymore. But renaming it would be an API break > * W

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744633522 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Soft

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744637086 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Soft

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744637255 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java ## @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744641650 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressBarTogglePanel.java ## @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744643439 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,163 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744644384 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,163 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744644484 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,163 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744647012 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java ## @@ -109

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r744710596 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java ## @@ -97,7

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r745323108 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/IWebSocketConnectionRegistry.java #

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r745324550 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/PageIdKey.java ## @@ -25,9 +28,

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r745324877 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/PageIdKey.java ## @@ -25,9 +28,

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r745325353 ## File path: wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java ## @@ -56,6 +57,7

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-963860667 @martin-g I have moved context to IKey. See https://github.com/apache/wicket/pull/479/commits/74bea3b3cf62ccf640a5d9e1e40b3eae359d32f2 -- This is an automate

[GitHub] [wicket] martin-g commented on a change in pull request #479: Wicket 6930 websocket improvements

martin-g commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r746593713 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Session.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Soft

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747238529 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/BaseWebSocketBehavior.java ## @@ -120,9

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747239357 ## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/IKey.java ## @@ -23,4 +23,9 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747246759 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747246898 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747248123 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java ## @@ -0,0 +1,31 @@ +/* + * Licen

[GitHub] [wicket] reiern70 commented on a change in pull request #479: Wicket 6930 websocket improvements

reiern70 commented on a change in pull request #479: URL: https://github.com/apache/wicket/pull/479#discussion_r747251280 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java ## @@ -0,0 +1,31 @@ +/* + * Licen

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-966095373 @martin-g Many thanks for review and useful comments! I will squash commits and merge to wicket 9.x. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [wicket] martin-g commented on pull request #479: Wicket 6930 websocket improvements

martin-g commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-966097015 And cherry-pick the final commit to `master` please! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [wicket] reiern70 merged pull request #479: Wicket 6930 websocket improvements

reiern70 merged pull request #479: URL: https://github.com/apache/wicket/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] reiern70 commented on pull request #479: Wicket 6930 websocket improvements

reiern70 commented on pull request #479: URL: https://github.com/apache/wicket/pull/479#issuecomment-966170799 > And cherry-pick the final commit to `master` please! Done! Thanks again for your help! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [wicket] solomax commented on a change in pull request #481: several minor datatable improvements

solomax commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r748838235 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pub

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r748852273 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] martin-g commented on a change in pull request #481: several minor datatable improvements

martin-g commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r748902761 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java ## @@ -46,11 +46,21 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749019077 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749020586 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java ## @@ -46,11 +46,21 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749020964 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] martin-g commented on a change in pull request #481: several minor datatable improvements

martin-g commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749109202 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749117687 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749117687 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] martin-g commented on a change in pull request #481: several minor datatable improvements

martin-g commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749123231 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] martin-g commented on a change in pull request #481: several minor datatable improvements

martin-g commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749124609 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java ## @@ -46,11 +46,21 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r749204276 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java ## @@ -46,11 +46,21 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r750131665 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java ## @@ -46,11 +46,21 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r750147103 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] reiern70 commented on a change in pull request #481: several minor datatable improvements

reiern70 commented on a change in pull request #481: URL: https://github.com/apache/wicket/pull/481#discussion_r750147725 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -44,17 +46,18 @@ pu

[GitHub] [wicket] reiern70 commented on pull request #481: several minor datatable improvements

reiern70 commented on pull request #481: URL: https://github.com/apache/wicket/pull/481#issuecomment-972656891 > Please create a JIRA ticket https://issues.apache.org/jira/browse/WICKET-6935 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [wicket] reiern70 commented on pull request #481: several minor datatable improvements

reiern70 commented on pull request #481: URL: https://github.com/apache/wicket/pull/481#issuecomment-972664149 @martin-g squashed all commits into one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [wicket] reiern70 merged pull request #481: several minor datatable improvements

reiern70 merged pull request #481: URL: https://github.com/apache/wicket/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] martin-g commented on a change in pull request #482: [WICKET-6935] several minor datatable improvements

martin-g commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752046172 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ pr

[GitHub] [wicket] reiern70 closed pull request #483: Allow to overrride channel creation

reiern70 closed pull request #483: URL: https://github.com/apache/wicket/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] reiern70 commented on a change in pull request #482: [WICKET-6935] several minor datatable improvements

reiern70 commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752205791 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ pr

[GitHub] [wicket] reiern70 commented on pull request #482: [WICKET-6935] several minor datatable improvements

reiern70 commented on pull request #482: URL: https://github.com/apache/wicket/pull/482#issuecomment-972834645 @martin-g many thanks for review. Landed in master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [wicket] reiern70 merged pull request #482: [WICKET-6935] several minor datatable improvements

reiern70 merged pull request #482: URL: https://github.com/apache/wicket/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] froque opened a new pull request #485: Fix spelling in user guide

froque opened a new pull request #485: URL: https://github.com/apache/wicket/pull/485 - [ ] This should be backported to versions 7, 8 and 9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [wicket] reiern70 merged pull request #485: Fix spelling in user guide

reiern70 merged pull request #485: URL: https://github.com/apache/wicket/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [wicket] martin-g commented on pull request #485: Fix spelling in user guide

martin-g commented on pull request #485: URL: https://github.com/apache/wicket/pull/485#issuecomment-976224924 Downported it to 8.x and 9.x. It does not apply for 7.x! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

  1   2   3   4   5   >