[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776139#comment-17776139
]
Sam Peters commented on WICKET-7072:
Indeed, thanks. (I wonder why
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776123#comment-17776123
]
Sam Peters commented on WICKET-7072:
Thanks for updating and releasing! Two things:
* [~bitstorm]:
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774513#comment-17774513
]
Sam Peters edited comment on WICKET-7072 at 10/12/23 5:02 PM:
--
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774513#comment-17774513
]
Sam Peters commented on WICKET-7072:
[~mgrigorov]: Some final thoughts after resolving this issue:
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771709#comment-17771709
]
Sam Peters edited comment on WICKET-7072 at 10/4/23 5:57 AM:
-
{quote}This
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771709#comment-17771709
]
Sam Peters edited comment on WICKET-7072 at 10/4/23 5:57 AM:
-
{quote}This
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771709#comment-17771709
]
Sam Peters commented on WICKET-7072:
{quote}This change is not related to this commit. I reverted it
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770449#comment-17770449
]
Sam Peters edited comment on WICKET-7072 at 9/29/23 2:53 PM:
-
Can you also
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770449#comment-17770449
]
Sam Peters edited comment on WICKET-7072 at 9/29/23 1:43 PM:
-
Can you also
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770449#comment-17770449
]
Sam Peters commented on WICKET-7072:
Can you also translate the _useModulePath=false_ (that surfire
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770353#comment-17770353
]
Sam Peters commented on WICKET-7072:
Seems to be this issue (you do a Run As JUnit, right?):
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770317#comment-17770317
]
Sam Peters commented on WICKET-7072:
Thanks for testing!
The bug with
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770180#comment-17770180
]
Sam Peters commented on WICKET-7072:
Thanks for the hint!
[~bitstorm] and [~solomax], could you
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770134#comment-17770134
]
Sam Peters commented on WICKET-7072:
{quote}Which problems do you have with this?
{quote}
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769952#comment-17769952
]
Sam Peters edited comment on WICKET-7072 at 9/28/23 8:58 AM:
-
{quote}After
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769952#comment-17769952
]
Sam Peters commented on WICKET-7072:
{quote}After `false` in main wicket pom.xml:line
1155 is
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769758#comment-17769758
]
Sam Peters commented on WICKET-7072:
i set it to false to overcome the following problems (the same
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769697#comment-17769697
]
Sam Peters commented on WICKET-7072:
[~solomax] I think that one could add a module-info.test that
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769080#comment-17769080
]
Sam Peters commented on WICKET-7072:
[~mgrigorov]:
Thank you for your feedback. I understand your
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769020#comment-17769020
]
Sam Peters commented on WICKET-7072:
{quote}VSCode uses Eclipse jar to do the job
{quote}
That's
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768689#comment-17768689
]
Sam Peters edited comment on WICKET-7072 at 9/25/23 3:13 PM:
-
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768689#comment-17768689
]
Sam Peters commented on WICKET-7072:
{quote}Please test the branch and report any issues!
{quote}
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768678#comment-17768678
]
Sam Peters commented on WICKET-7072:
Thanks!
Why do you need an extra
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768587#comment-17768587
]
Sam Peters commented on WICKET-7072:
{quote}maven-rat-plugin won't replace the WelformedXmlTestCase,
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768573#comment-17768573
]
Sam Peters commented on WICKET-7072:
[~solomax] Thanks for testing! Now, ApacheLicenseHeaderTestCase
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768121#comment-17768121
]
Sam Peters commented on WICKET-7072:
{quote}VSCode also reports 2k+ error after opening Wicket :(
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767997#comment-17767997
]
Sam Peters edited comment on WICKET-7072 at 9/22/23 1:10 PM:
-
{quote}Now the
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767997#comment-17767997
]
Sam Peters commented on WICKET-7072:
{quote}Now the idea is to:
move WicketTester and Co in
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767591#comment-17767591
]
Sam Peters edited comment on WICKET-7072 at 9/21/23 8:47 PM:
-
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767591#comment-17767591
]
Sam Peters edited comment on WICKET-7072 at 9/21/23 5:02 PM:
-
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767591#comment-17767591
]
Sam Peters edited comment on WICKET-7072 at 9/21/23 3:04 PM:
-
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767591#comment-17767591
]
Sam Peters commented on WICKET-7072:
{quote}wicket-core should not depend on wicket-tester.
{quote}
[ https://issues.apache.org/jira/browse/WICKET-7072 ]
Sam Peters deleted comment on WICKET-7072:
was (Author: JIRAUSER302119):
_Short Update:_
After fighting Eclipse's FindExceptions I restarted a new multimodule maven
project, consisting of
[ https://issues.apache.org/jira/browse/WICKET-7072 ]
Sam Peters deleted comment on WICKET-7072:
was (Author: JIRAUSER302119):
I was a bit too optimistic concerning Eclipse... dependencies of type
_test-jar_ are not really supported. See here
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767044#comment-17767044
]
Sam Peters edited comment on WICKET-7072 at 9/21/23 6:04 AM:
-
Thank you for
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767166#comment-17767166
]
Sam Peters commented on WICKET-7072:
_Short Update:_
After fighting Eclipse's FindExceptions I
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767044#comment-17767044
]
Sam Peters commented on WICKET-7072:
Thank you for merging!
Now, while trying to build the new
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767070#comment-17767070
]
Sam Peters edited comment on WICKET-7072 at 9/20/23 10:31 AM:
--
I was a bit
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767070#comment-17767070
]
Sam Peters commented on WICKET-7072:
I was a bit too optimistic concerning Eclipse... dependencies
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766920#comment-17766920
]
Sam Peters edited comment on WICKET-7072 at 9/19/23 8:14 PM:
-
That's great,
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766920#comment-17766920
]
Sam Peters edited comment on WICKET-7072 at 9/19/23 8:14 PM:
-
That's great,
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766920#comment-17766920
]
Sam Peters commented on WICKET-7072:
That's great, thank you!
Missing changes for wicket-util (see
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766797#comment-17766797
]
Sam Peters edited comment on WICKET-7072 at 9/19/23 2:02 PM:
-
Thank you for
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766797#comment-17766797
]
Sam Peters commented on WICKET-7072:
Thank you for the clarifications! And good news, my initial
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766779#comment-17766779
]
Sam Peters commented on WICKET-7072:
Wow, I haven't heard about the _test-jar_ type. I still try to
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766721#comment-17766721
]
Sam Peters commented on WICKET-7072:
{quote}create an new lib, e. g. wicket-util-test
No need to do
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766682#comment-17766682
]
Sam Peters commented on WICKET-7072:
Ok, I agree. Then I'll try to fork master and create the two
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766389#comment-17766389
]
Sam Peters commented on WICKET-7072:
> _Eclipse + Maven integration is weird! I still cannot
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766370#comment-17766370
]
Sam Peters commented on WICKET-7072:
Hi, thank you!
master branch would be perfectly fine (we have
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766353#comment-17766353
]
Sam Peters commented on WICKET-7072:
[~hobrom]: Yes, it was a typo and should be "false". But the
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766270#comment-17766270
]
Sam Peters commented on WICKET-7072:
Update: The described errors remain even in newest Eclipse IDE
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765684#comment-17765684
]
Sam Peters commented on WICKET-7072:
Thank you very much for your explaination. I see that moving
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765616#comment-17765616
]
Sam Peters commented on WICKET-7072:
Thank you for your feedback and the link to WICKET-7019. I'll
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Peters updated WICKET-7072:
---
Description:
In Wicket 10, the wicket-core and wicket-util jars contain JUnit-related code,
see
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Peters updated WICKET-7072:
---
Description:
In Wicket 10, the wicket-core and wicket-util jars contain JUnit-related code
(see
[
https://issues.apache.org/jira/browse/WICKET-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Peters updated WICKET-7072:
---
Description:
In Wicket 10, the wicket-core and wicket-util jars contain JUnit-related code
(see
Sam Peters created WICKET-7072:
--
Summary: JUnit code in /src/main/java breaks JPMS support in
Eclipse IDE
Key: WICKET-7072
URL: https://issues.apache.org/jira/browse/WICKET-7072
Project: Wicket
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763008#comment-17763008
]
Sam Peters commented on WICKET-7071:
Thank you. I am aware of such wrapping workarounds but they may
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762812#comment-17762812
]
Sam Peters commented on WICKET-7071:
Thank you for debugging! I added some debugging on the
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762683#comment-17762683
]
Sam Peters commented on WICKET-7071:
> This shows that the problem is in your code.
No, it isn't:
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762663#comment-17762663
]
Sam Peters commented on WICKET-7071:
> We recommend the quickstart because it makes it easier to
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Peters updated WICKET-7071:
---
Description:
Calling request.getInputStream() (without reading any data from the stream),
followed
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762488#comment-17762488
]
Sam Peters edited comment on WICKET-7071 at 9/6/23 9:18 PM:
Thank you for
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Peters updated WICKET-7071:
---
Description:
Calling request.getInputStream() (without reading any data from the stream),
followed
[
https://issues.apache.org/jira/browse/WICKET-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762488#comment-17762488
]
Sam Peters commented on WICKET-7071:
Thank you for your fast response! I'm not aware of using CSP,
Sam Peters created WICKET-7071:
--
Summary: Problems when calling request.getInputStream() before
executing WicketFilter
Key: WICKET-7071
URL: https://issues.apache.org/jira/browse/WICKET-7071
Project:
66 matches
Mail list logo
