[GitHub] [wicket] reiern70 commented on pull request #566: [WICKET-7037] add SameSite attribute to cookie.

2023-04-03 Thread via GitHub
reiern70 commented on PR #566: URL: https://github.com/apache/wicket/pull/566#issuecomment-1493946725 > I have no idea... Af far as I udnerestand from code this is only used in order to trigger donwload finished event. Correct? We are not using that event in our application but we

[GitHub] [wicket] reiern70 commented on pull request #566: [WICKET-7037] add SameSite attribute to cookie.

2023-04-03 Thread via GitHub
reiern70 commented on PR #566: URL: https://github.com/apache/wicket/pull/566#issuecomment-1493985882 > It might be required to set cookie to `none` in case wicket application opened in `iframe` We had troubles with login inside iframe, so tomcat config was corrected What changes do

[GitHub] [wicket] reiern70 commented on pull request #566: [WICKET-7037] add SameSite attribute to cookie.

2023-04-04 Thread via GitHub
reiern70 commented on PR #566: URL: https://github.com/apache/wicket/pull/566#issuecomment-1495693150 @solomax I have used the idea @martin-g used for master and partilly ported to 9.x in a way that is backward compatible (or so I hope) -- This is an automated message from the Apache Git