[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495702979 > @reiern70 Would it be possible to add XML configuration (like `wicket.mode`) ? > > @reiern70 Would it be possible to add XML configuration (like `wicket.mod

[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495709612 > Yes, exactly so this settings can be set without code modification and recompilation :) Shall this be part of some application settings? -- This is an automated message from the

[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495732184 > > In our case init parameter of servlet context will be enough :)) > > If Wicket won't set this value into some **Settings bean then there is nothing to do here. The application can

[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495732988 @martin-g Should I add such configuration option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495745652 > > You can allways roll you own AjaxDonwloadBehavior and do > > Good point! Thanks :) But I still see a valid use case for what you requested for existing applications:

[GitHub] [wicket] reiern70 commented on pull request #567: [WICKET-7037] add SameSite attribute to download finished cookie

2023-04-04 Thread via GitHub
reiern70 commented on PR #567: URL: https://github.com/apache/wicket/pull/567#issuecomment-1495789591 > Yes, this would be ideal But Custom AjaxDownloadBehavior is something we can workaround with until Wicket-10 :) For 9.x we need https://github.com/apache/wicket/pull/566 --