DavesMan commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1761123685
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
martin-g commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1759394499
Thank you, @DavesMan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
martin-g merged PR #670:
URL: https://github.com/apache/wicket/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bitstorm commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1753244685
@DavesMan completely agree with our considerations and I also hoped for
more "exhaustive" specs about concurrent access to Session object. :-/
--
This is an automated message from the
DavesMan commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1753038723
@martin-g I am afraid there is no ideal solution of this problem. It is bad
by design of the specs. We can:
1. Sync on some object like the SessionStore and loose performance. Bad.
martin-g commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1753025853
Thanks for restoring it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1753018372
Thanks for the explanation!
I wanted to re-open the PR but it seems you already deleted it.
I guess we will come with a similar solution ...
--
This is an automated message from the
DavesMan closed pull request #670: WICKET-7056 try-catch attempts to operate on
invalid HTTP session and…
URL: https://github.com/apache/wicket/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
DavesMan commented on PR #670:
URL: https://github.com/apache/wicket/pull/670#issuecomment-1752962518
I could not find any situable object to synchronize on.
The HttpSessionStore is one instance per application. Because at least
org.apache.wicket.Session#exists() is called in every
DavesMan opened a new pull request, #670:
URL: https://github.com/apache/wicket/pull/670
… log them
1. The getHttpSession returns non-null value in case HTTP session exists and
is valid and reference to it is stored.
2. Meanwhile the session is invalidated by another thread
10 matches
Mail list logo