[ 
https://issues.apache.org/jira/browse/WICKET-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051065#comment-13051065
 ] 

Ivan Vasilev edited comment on WICKET-3652 at 6/17/11 1:27 PM:
---------------------------------------------------------------

Hello,
Inside GenericPanel and GenericWebPage:

        @SuppressWarnings("unchecked")
        public final T getModel()
        {
                return (T)getDefaultModel();
        }

Shouldn't it be:

        @SuppressWarnings("unchecked")
        public final T getModel()
        {
                return (IModel<T>)getDefaultModel();
        }

Also, do you think similar GenericFragment should can be added? Thanks.

      was (Author: hok):
    Hello,
Inside GenericPanel:

        @SuppressWarnings("unchecked")
        public final T getModel()
        {
                return (T)getDefaultModel();
        }

Shouldn't it be:

        @SuppressWarnings("unchecked")
        public final T getModel()
        {
                return (IModel<T>)getDefaultModel();
        }

Also, do you think similar GenericFragment should can be added? Thanks.
  
> Provide a Typesafe Panel, that allows to use getDefaultModel and 
> getDefaultModelObject without casting
> ------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3652
>                 URL: https://issues.apache.org/jira/browse/WICKET-3652
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Martin Dilger
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-RC5
>
>         Attachments: 
> 0001-TypedPanel-to-provide-TypeSafe-access-to-underlying-.patch, 
> 0001-WICKET-3652-TypedPanel-and-TypedWebPage-to-provide-T.patch
>
>
> I want to use panels in a generic way with no need to cast, if I use 
> getDefaultModel and getDefaultModelObject.
> This issue has been thoroughly discussed, and thats why Panel is currently 
> not implemented using generics.
> Please provide a class TypedPanel instead, that can be used interchangeably 
> with Panel itself.
> The Implementation could provide the following Methods:
> public T getDefaultModel()
> public T getDefaultModelObject()
> That would make usage of typed panels much more cleaner.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to