[ https://issues.apache.org/jira/browse/WICKET-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl-Eric Menzel resolved WICKET-4618. -------------------------------------- Resolution: Fixed Fix Version/s: 1.5.8 Fixed in 1.5.x. New method ResourceStreamLocator#getClasspathLocationPrefixes(). > ResourceStreamLocator does a hard-coded resource lookup in > "META-INF/resources" > ------------------------------------------------------------------------------- > > Key: WICKET-4618 > URL: https://issues.apache.org/jira/browse/WICKET-4618 > Project: Wicket > Issue Type: Bug > Affects Versions: 6.0.0-beta2, 1.5.7 > Reporter: Carl-Eric Menzel > Assignee: Carl-Eric Menzel > Fix For: 1.5.8 > > > ResourceStreamLocator currently does a hard-coded resource lookup in > "META-INF/resources". In deployment, that is not a big problem, since its > results are cached. In testing however, this single line is nearly doubling > our wallclock time. > I agree that the lookup is necessary for Servlet 3.0 support, but it should > not be just inelegantly hardcoded like that. Our application doesn't use it, > yet our tests are hit hard. I profiled one of the worse testcases (roughly > 50-60 seconds in 1.4, now 110-120(!)) - we spent over 70% of the time in > ResourceStreamLocator#getResourceStream. I tried commenting out just that one > call looking for "META-INF/resources" and the test dropped back down to 60 > seconds. > So I'd really like this to be configurable, so I can just get rid of it in > test configurations. > WICKET-4617 will take care of it all in 6.0, because it will introduce a > ResourceFinder/ResourcePath for it, which will make it easily configurable. > For 1.5 I propose giving ResourceStreamLocator itself a list of paths to try > (by default "" and "META-INF/resources") instead of hard-coding. > Objections? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira