[
https://issues.apache.org/jira/browse/WICKET-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Compagner closed WICKET-1844.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.5
Assignee: Johan Compagner
i removed the finals from the class but there are still finals for some
methods, but most of them are controlled by the WizardModel (like enabled)
> Wizard button implementations should not be final
> -------------------------------------------------
>
> Key: WICKET-1844
> URL: https://issues.apache.org/jira/browse/WICKET-1844
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.3.4
> Reporter: Matthias Keller
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.3.5, 1.4-M4
>
>
> I dont know why the wizard buttons are final but this makes it hard to add
> custom behaviour to them. For example, we need to hide a button if it's not
> enabled. We had to re-create all buttons by ourselves to do that instead of
> just overriding the isVisible() method of a button.
> Affects:
> org/apache/wicket/extensions/wizard/CancelButton
> org/apache/wicket/extensions/wizard/FinishButton
> org/apache/wicket/extensions/wizard/LastButton
> org/apache/wicket/extensions/wizard/NextButton
> org/apache/wicket/extensions/wizard/PreviousButton
> Suggestion: remove 'final' from class declaration
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
