[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Pedro Santos (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932709#action_12932709 ] Pedro Santos commented on WICKET-3166: -- The currently isVisibleInHierarchy

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932711#action_12932711 ] Martin Makundi commented on WICKET-3166: I think changing the form visitor is a

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Pedro Santos (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932757#action_12932757 ] Pedro Santos commented on WICKET-3166: -- My suggested fix would involve in not

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Igor Vaynberg (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932801#action_12932801 ] Igor Vaynberg commented on WICKET-3166: --- i am thinking we should revert this in

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932831#action_12932831 ] Martin Makundi commented on WICKET-3166: The original isvisibleinhierarcy was

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-16 Thread Igor Vaynberg (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932845#action_12932845 ] Igor Vaynberg commented on WICKET-3166: --- @pedro: post-order is there for a reason.

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931876#action_12931876 ] Martin Makundi commented on WICKET-3166: Hi! The fix I proposed does fix the

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931879#action_12931879 ] Martin Makundi commented on WICKET-3166: Hah.. actually there is an unnecessary

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931880#action_12931880 ] Martin Makundi commented on WICKET-3166: New fix proposal: public final

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931934#action_12931934 ] Hudson commented on WICKET-3166: Integrated in Apache Wicket 1.4.x #266 (See

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931954#action_12931954 ] Hudson commented on WICKET-3166: Integrated in Apache Wicket 1.4.x #267 (See

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931959#action_12931959 ] Hudson commented on WICKET-3166: Integrated in Apache Wicket 1.5.x #517 (See

[jira] Commented: (WICKET-3166) isVisibleInHierarchy() possibly unnecessarily checks children whose parents are invisible?

2010-11-14 Thread Martin Makundi (JIRA)
[ https://issues.apache.org/jira/browse/WICKET-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12931986#action_12931986 ] Martin Makundi commented on WICKET-3166: 1. THIS SOLUTION WORKS ::: public final