[ https://issues.apache.org/jira/browse/WICKET-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1905. ----------------------------------- Resolution: Won't Fix Assignee: Igor Vaynberg > Component.getPageFactory() vs. Session.getPageFactory() and > Session.getPageFactory(Page) > ---------------------------------------------------------------------------------------- > > Key: WICKET-1905 > URL: https://issues.apache.org/jira/browse/WICKET-1905 > Project: Wicket > Issue Type: Bug > Components: wicket > Affects Versions: 1.4-M4 > Reporter: Jan Loose > Assignee: Igor Vaynberg > > I was found strange code: > In Session: > public final IPageFactory getPageFactory() > { > return getApplication().getSessionSettings().getPageFactory(); > } > public final IPageFactory getPageFactory(final Page page) > { > if (page != null) > { > return page.getPageFactory(); > } > return getPageFactory(); > } > Both method are 'final', the first gets PageFactory from SessionSettings and > the second uses Page#PageFactory (defined in Component) or uses the > Session#getPageFactory() (the first method). > In Component: > /** > * @return The page factory for the session that this component is in > */ > public final IPageFactory getPageFactory() > { > return getSession().getPageFactory(); > } > And again 'final' and gets the PageFactory by Session#getPageFactory() too. > Why is there this code? I think that the final word in > Component#getPageFactory() should be removed (i need it:-)). > Thx, > H. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.