This is an automated email from the ASF dual-hosted git repository.

svenmeier pushed a commit to branch fix/WICKET-7065-filter-form-inline-js
in repository https://gitbox.apache.org/repos/asf/wicket.git

commit 9c7928fba264fcd4ae9ac3b7acc55bcdc19a424e
Author: Sven Meier <svenme...@apache.org>
AuthorDate: Fri Jul 28 22:51:06 2023 +0200

    WICKET-7065 replace inline js with header item
---
 .../markup/html/repeater/data/table/filter/FilterForm.java       | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
index 48af754e9d..a3099c7455 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
@@ -22,6 +22,7 @@ import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.markup.MarkupStream;
 import org.apache.wicket.markup.head.IHeaderResponse;
 import org.apache.wicket.markup.head.JavaScriptHeaderItem;
+import org.apache.wicket.markup.head.OnEventHeaderItem;
 import org.apache.wicket.markup.head.OnLoadHeaderItem;
 import org.apache.wicket.markup.html.form.Form;
 import org.apache.wicket.markup.html.form.FormComponent;
@@ -140,11 +141,9 @@ public class FilterForm<T> extends Form<T>
                        }
 
                        @Override
-                       public void onComponentTag(final Component component, 
final ComponentTag tag)
-                       {
-                               tag.put("onfocus", 
getFocusTrackingHandler(component));
-
-                               super.onComponentTag(component, tag);
+                       public void renderHead(Component component, 
IHeaderResponse response) {
+                               
response.render(OnEventHeaderItem.forComponent(component, "focus",
+                                               
getFocusTrackingHandler(component)));
                        }
                });
        }

Reply via email to