Author: pete
Date: Sat Nov 13 11:00:01 2010
New Revision: 1034729
URL: http://svn.apache.org/viewvc?rev=1034729&view=rev
Log:
WICKET-3161: cookies that are set during a buffered web response will not be
transferred over redirecting.
The solution to this issue is not what I consider pretty so please take time to
review and feel free to improve it.
Sorry for the last commit message (I intended to create a path but was clicking
too fast)
The previous commit is part of WICKET-3161
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/BufferedWebResponse.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/IBufferedWebResponse.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/BufferedWebResponse.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/BufferedWebResponse.java?rev=1034729&r1=1034728&r2=1034729&view=diff
==============================================================================
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/BufferedWebResponse.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/BufferedWebResponse.java
Sat Nov 13 11:00:01 2010
@@ -47,7 +47,8 @@ public class BufferedWebResponse extends
*/
public BufferedWebResponse(WebResponse originalResponse)
{
- // if original response had some cookies set we should not
forget to transfer them
+ // if original response had some cookies set we should not
forget
+ // to transfer them to the current response
if(originalResponse instanceof IBufferedWebResponse)
((IBufferedWebResponse)
originalResponse).transferCookies(this);
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/IBufferedWebResponse.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/IBufferedWebResponse.java?rev=1034729&r1=1034728&r2=1034729&view=diff
==============================================================================
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/IBufferedWebResponse.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/IBufferedWebResponse.java
Sat Nov 13 11:00:01 2010
@@ -20,5 +20,10 @@ import org.apache.wicket.request.http.We
interface IBufferedWebResponse
{
+ /**
+ * transfer cookie operations (add + clear cookie) to given web response
+ *
+ * @param webResponse web response that should receive the current
cookie operation
+ */
void transferCookies(WebResponse webResponse);
}
