Re: [PR] parquet source with partition extraction [incubator-xtable]

2025-07-23 Thread via GitHub
unical1988 commented on code in PR #728: URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224252730 ## xtable-core/src/main/java/org/apache/xtable/parquet/ParquetConversionSource.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] parquet source with partition extraction [incubator-xtable]

2025-07-23 Thread via GitHub
unical1988 commented on code in PR #728: URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224252168 ## xtable-core/src/main/java/org/apache/xtable/hudi/ConfigurationBasedPartitionSpecExtractor.java: ## @@ -29,20 +29,21 @@ import org.apache.xtable.model.sche

Re: [PR] parquet source with partition extraction [incubator-xtable]

2025-07-23 Thread via GitHub
unical1988 commented on code in PR #728: URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224252168 ## xtable-core/src/main/java/org/apache/xtable/hudi/ConfigurationBasedPartitionSpecExtractor.java: ## @@ -29,20 +29,21 @@ import org.apache.xtable.model.sche

Re: [PR] parquet source with partition extraction [incubator-xtable]

2025-07-23 Thread via GitHub
unical1988 commented on code in PR #728: URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224252730 ## xtable-core/src/main/java/org/apache/xtable/parquet/ParquetConversionSource.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] parquet source with partition extraction [incubator-xtable]

2025-07-23 Thread via GitHub
unical1988 commented on code in PR #728: URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2227242827 ## xtable-core/src/test/java/org/apache/xtable/ITConversionController.java: ## @@ -141,7 +140,7 @@ private static Stream testCasesWithPartitioningAndSyncMode