Re: [PR] Website header add ASF menu [incubator-xtable]

2024-03-15 Thread via GitHub
xtable-bot commented on PR #388: URL: https://github.com/apache/incubator-xtable/pull/388#issuecomment-200134 ## CI report: * 2b855f5312b9668fe65c1d8a06468ee13fe795f8 Azure:

Re: [PR] Website header add ASF menu [incubator-xtable]

2024-03-15 Thread via GitHub
xtable-bot commented on PR #388: URL: https://github.com/apache/incubator-xtable/pull/388#issuecomment-2001294723 ## CI report: * 2b855f5312b9668fe65c1d8a06468ee13fe795f8 Azure:

Re: [PR] Website header add ASF menu [incubator-xtable]

2024-03-15 Thread via GitHub
xtable-bot commented on PR #388: URL: https://github.com/apache/incubator-xtable/pull/388#issuecomment-2001290632 ## CI report: * 2b855f5312b9668fe65c1d8a06468ee13fe795f8 UNKNOWN Bot commands @xtable-bot supports the following commands: - `@xtable-bot run

[PR] Website header add ASF menu [incubator-xtable]

2024-03-15 Thread via GitHub
wuchunfu opened a new pull request, #388: URL: https://github.com/apache/incubator-xtable/pull/388 Website header add ASF menu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add blog post on E-commerce Funnel Analysis with StarRocks: 87 Millio… [incubator-xtable]

2024-03-15 Thread via GitHub
xtable-bot commented on PR #361: URL: https://github.com/apache/incubator-xtable/pull/361#issuecomment-2000402342 ## CI report: * 3d4cfaf4458bf0e10b4019b25b2c9c16260e2a00 UNKNOWN Bot commands @xtable-bot supports the following commands: - `@xtable-bot run

Re: [PR] Implement UUID type [incubator-xtable]

2024-03-15 Thread via GitHub
yyy1000 commented on PR #267: URL: https://github.com/apache/incubator-xtable/pull/267#issuecomment-192445 No @gzagarwal , I think you can take in the original issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Implement UUID type [incubator-xtable]

2024-03-15 Thread via GitHub
yyy1000 closed pull request #267: Implement UUID type URL: https://github.com/apache/incubator-xtable/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Properly reflect rollbacks/restores in target tables [incubator-xtable]

2024-03-15 Thread via GitHub
gzagarwal commented on issue #40: URL: https://github.com/apache/incubator-xtable/issues/40#issuecomment-189709 What is the source and target in this scenario ? Actually i am trying to understand the code change so following the jira issues as well might ask silly question. -- This

Re: [I] Simplify SourceClient inerface by replacing getSchemaCatalog with getSchema [incubator-xtable]

2024-03-15 Thread via GitHub
gzagarwal commented on issue #77: URL: https://github.com/apache/incubator-xtable/issues/77#issuecomment-177813 @ashvina is this completed ? i think pr merge is pending according to the review , apologise if i missed anything -- This is an automated message from the Apache Git

Re: [PR] Implement UUID type [incubator-xtable]

2024-03-15 Thread via GitHub
xtable-bot commented on PR #267: URL: https://github.com/apache/incubator-xtable/pull/267#issuecomment-177637 ## CI report: * eafb4f6b8ce2b15d6525fa0ff0b76d7a4e2ba9e4 UNKNOWN Bot commands @xtable-bot supports the following commands: - `@xtable-bot run

Re: [PR] Implement UUID type [incubator-xtable]

2024-03-15 Thread via GitHub
gzagarwal commented on PR #267: URL: https://github.com/apache/incubator-xtable/pull/267#issuecomment-175793 @yyy1000 @the-other-tim-brown is this PR completed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Add record count to OneData File with Delta version upgrade. [incubator-xtable]

2024-03-15 Thread via GitHub
gzagarwal commented on issue #102: URL: https://github.com/apache/incubator-xtable/issues/102#issuecomment-1999848811 Also the change is not present in the github code in main branch the code is changed in "core/src/main/java/io/onetable/delta/DeltaActionsConverter.java"

Re: [I] Add record count to OneData File with Delta version upgrade. [incubator-xtable]

2024-03-15 Thread via GitHub
gzagarwal commented on issue #102: URL: https://github.com/apache/incubator-xtable/issues/102#issuecomment-1999834816 > We are now on Delta 2.4.X so this can be easily done. Labeling as a "good first issue" in case anyone wants to pick it up. as part of this change do we want to remove

Re: [I] Blog posts in XTable website compliance with ASF policies [incubator-xtable]

2024-03-15 Thread via GitHub
zabetak commented on issue #376: URL: https://github.com/apache/incubator-xtable/issues/376#issuecomment-1999329699 Hey @jcamachor, I had a look at the structured of the blog page and it seems that almost all the links point towards third party sites. I don' think this is a problem as

Re: [PR] Add license header [incubator-xtable]

2024-03-15 Thread via GitHub
zabetak commented on PR #359: URL: https://github.com/apache/incubator-xtable/pull/359#issuecomment-1999266530 Many thanks for the PR @wuchunfu ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add license header [incubator-xtable]

2024-03-15 Thread via GitHub
zabetak commented on PR #359: URL: https://github.com/apache/incubator-xtable/pull/359#issuecomment-1999265918 Merged via https://github.com/apache/incubator-xtable/commit/7c7b54b3870791578b4689b29cf8794866eefa52 Apart from the squash, I did a small fixup to properly exclude [the

Re: [PR] Add license header [incubator-xtable]

2024-03-15 Thread via GitHub
zabetak closed pull request #359: Add license header URL: https://github.com/apache/incubator-xtable/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(incubator-xtable) branch gh-pages updated: deploy: 7c7b54b3870791578b4689b29cf8794866eefa52

2024-03-15 Thread timbrown
This is an automated email from the ASF dual-hosted git repository. timbrown pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/incubator-xtable.git The following commit(s) were added to refs/heads/gh-pages by this push: new 4130b7ee deploy:

(incubator-xtable) branch main updated: Enforce ASF license header in non-java files via spotless (#359)

2024-03-15 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-xtable.git The following commit(s) were added to refs/heads/main by this push: new 7c7b54b3 Enforce ASF license header in

Re: [PR] Add license header [incubator-xtable]

2024-03-15 Thread via GitHub
zabetak commented on PR #359: URL: https://github.com/apache/incubator-xtable/pull/359#issuecomment-1999200273 Since we are all good with reviews I will try to squash the commits myself and merge via command line to see if this can be used as an option. I will update here with the results.