[zeppelin] branch master updated: [ZEPPELIN-4449] Fix Credentials update errors

[zjffdu]

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d9a2d0  [ZEPPELIN-4449] Fix Credentials update errors
4d9a2d0 is described below

commit 4d9a2d0931d8f0e98a54d057e652fdc5f696df05
Author: LeeDongMyeong <dev.dm...@gmail.com>
AuthorDate: Thu Nov 21 14:42:56 2019 +0900

    [ZEPPELIN-4449] Fix Credentials update errors
    
    ### What is this PR for?
    Updating 'Credentials' causes the following error and will not be fixed.
    
    <img width="958" alt="Screen Shot 2019-11-14 at 10 13 21 PM" 
src="https://user-images.githubusercontent.com/42430609/68860902-c055e980-072d-11ea-9e09-81bf60fb6d06.png";>
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-4449
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed 
behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    before
    ![Nov-14-2019 
21-36-21](https://user-images.githubusercontent.com/42430609/68861251-889b7180-072e-11ea-829b-d379ae25f2cb.gif)
    
    after
    ![Nov-14-2019 
22-28-57](https://user-images.githubusercontent.com/42430609/68861168-52f68880-072e-11ea-8661-113d945b4c70.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: LeeDongMyeong <dev.dm...@gmail.com>
    
    Closes #3521 from eldiem/fix-credentials and squashes the following commits:
    
    85f084f9a [LeeDongMyeong] Add validation
    5ebae9001 [LeeDongMyeong] [ZEPPELIN-4449] Fix Credentials update errors
---
 zeppelin-web/src/app/credential/credential.controller.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/zeppelin-web/src/app/credential/credential.controller.js 
b/zeppelin-web/src/app/credential/credential.controller.js
index 7de383e..350a046 100644
--- a/zeppelin-web/src/app/credential/credential.controller.js
+++ b/zeppelin-web/src/app/credential/credential.controller.js
@@ -136,9 +136,9 @@ function CredentialController($scope, $rootScope, $http, 
baseUrlSrv, ngToast) {
   };
 
   $scope.updateCredentialInfo = function(form, data, entity) {
-    if (!$scope.isValidCredential()) {
-      showToast('Username \\ Entity can not be empty.', 'danger');
-      return;
+    if (!data.username || !data.password) {
+      showToast('Username \\ Password can not be empty.', 'danger');
+      return false;
     }
 
     let credential = {