HADOOP-13163 Reuse pre-computed filestatus in Distcp-CopyMapper (Rajesh 
Balamohan via stevel)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/c69a6492
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/c69a6492
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/c69a6492

Branch: refs/heads/YARN-3368
Commit: c69a649257a331da55c1a1bf61c819e289015a6b
Parents: b357930
Author: Steve Loughran <ste...@apache.org>
Authored: Tue May 17 12:59:59 2016 +0100
Committer: Steve Loughran <ste...@apache.org>
Committed: Tue May 17 13:00:18 2016 +0100

----------------------------------------------------------------------
 .../java/org/apache/hadoop/tools/mapred/CopyMapper.java   | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/c69a6492/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
----------------------------------------------------------------------
diff --git 
a/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
 
b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
index 4db1d4e..4b73415 100644
--- 
a/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
+++ 
b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
@@ -182,7 +182,7 @@ public class CopyMapper extends Mapper<Text, 
CopyListingFileStatus, Text, Text>
         return;
       }
 
-      FileAction action = checkUpdate(sourceFS, sourceCurrStatus, target);
+      FileAction action = checkUpdate(sourceFS, sourceCurrStatus, target, 
targetStatus);
       if (action == FileAction.SKIP) {
         LOG.info("Skipping copy of " + sourceCurrStatus.getPath()
                  + " to " + target);
@@ -270,13 +270,7 @@ public class CopyMapper extends Mapper<Text, 
CopyListingFileStatus, Text, Text>
   }
 
   private FileAction checkUpdate(FileSystem sourceFS, FileStatus source,
-      Path target) throws IOException {
-    final FileStatus targetFileStatus;
-    try {
-      targetFileStatus = targetFS.getFileStatus(target);
-    } catch (FileNotFoundException e) {
-      return FileAction.OVERWRITE;
-    }
+      Path target, FileStatus targetFileStatus) throws IOException {
     if (targetFileStatus != null && !overWrite) {
       if (canSkip(sourceFS, source, targetFileStatus)) {
         return FileAction.SKIP;


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org

Reply via email to