Re: [DISCUSS] what needs to be done to switch to java17

2024-07-31 Thread Xiaoqiao He
Great discussion. Strong +1 to support JDK 17. Not verify carefully, just want to collect if it is clear when we want to upgrade to support JDK17. a. CI infra. b. JUnit 5? (Not confirmed?) c. Jersey. d. JPMS args. e. Some other dependencies (Not clear). f. Any other things... we are using Hadoop c

RE: [DISCUSS] what needs to be done to switch to java17

2024-07-30 Thread Cheng Pan
I would classify the must things into: 1. CI infrastructure. We must refactor the CI to supply regular checks for JDK 17, in both compiling and testing. In my local play, I can compile the Hadoop code successful with tune some maven plugin args, while the CI for testing is a little bit challengi

Re: [DISCUSS] what needs to be done to switch to java17

2024-07-30 Thread Ayush Saxena
> One thing I know is that it is necessary to upgrade JUnit 4 to JUnit 5 Do you know any specific reason or docs mentioning that? Just curious as to why we need to migrate to JUnit 5 for JDK-17, Looking here [1], it seems like it supports JDK-21 as well and even [2] mentions like it does support

Re: [DISCUSS] what needs to be done to switch to java17

2024-07-29 Thread Ashutosh Gupta
Thanks, everyone, for starting this discussion. This sounds like a good plan to start with. As I was working on the JUnit 4 to 5 upgrade, I paused for a while as I got occupied with other stuff. But I would be happy to complete it as part of the Java switch process. On Tue, Jul 30, 2024 at 4:21 AM

Re: [DISCUSS] what needs to be done to switch to java17

2024-07-29 Thread slfan1989
Thank you very much for initiating this discussion! I am also very much looking forward to JDK 17. I have observed that using --add-opens= is quite common in other Apache projects. One thing I know is that it is necessary to upgrade JUnit 4 to JUnit 5. There are some JIRA issues currently being wor

Re: [DISCUSS] what needs to be done to switch to java17

2024-07-29 Thread Ayush Saxena
Depends on what we mean by switching to JDK-17, Compile time support or Runtime support, We don't have compile time support for JDK-11 too, it is just runtime, We have a daily build as well for JDK-11, which has now some genuine failures now, need to check [1], as of now the version is hardcoded he

Re: [DISCUSS] what needs to be done to switch to java17

2024-07-29 Thread PJ Fanning
I think this is worth considering. I think it would require a minor release like 3.5.0 as opposed to considering it for future 3.4.x patch releases. I tend to build locally with Java 11, by default and I haven't hit major issues building Hadoop. There may be some gotcha somewhere but it is likely t

[DISCUSS] what needs to be done to switch to java17

2024-07-29 Thread Steve Loughran
A lot of projects are moving off java8. making java17 the new baseline what do we need to there that is blocker rather than just "nice"'?