Re: [DISCUSS} why is checkstyle harassing me on indentation?

2016-01-20 Thread Andrew Wang
I just turned off some checkstyle warnings at HADOOP-12713, namely the "file is too long" warning whenever you modify an existing big file. Steve, if you want to make indentation more flexible, feel free to file a patch and I'll +1. The overall response on this thread seems positive. Best, Andrew

Re: [DISCUSS} why is checkstyle harassing me on indentation?

2016-01-18 Thread Colin P. McCabe
On Mon, Jan 18, 2016 at 11:34 AM, Steve Loughran wrote: > > Yetus checkstyle is going a bit overboard on indentation policy > > https://builds.apache.org/job/PreCommit-HADOOP-Build/8434/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt > > I am happy with it going on ab

Re: [DISCUSS} why is checkstyle harassing me on indentation?

2016-01-18 Thread Allen Wittenauer
> On Jan 18, 2016, at 11:34 AM, Steve Loughran wrote: > > > Yetus checkstyle is going a bit overboard on indentation policy Just the messenger. ;) FWIW: https://wiki.apache.org/hadoop/CodeReviewChecklist

[DISCUSS} why is checkstyle harassing me on indentation?

2016-01-18 Thread Steve Loughran
Yetus checkstyle is going a bit overboard on indentation policy https://builds.apache.org/job/PreCommit-HADOOP-Build/8434/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt I am happy with it going on about javadocs, box/unbox, charsets. But complaining that something