Hi All
INFRA-18777 is closed and github UI has disabled #1 and #3. Only Squash and
Merge is possible.
Could we start using this option (merge from UI) from now onwards ?
- Sunil
On Mon, Jul 22, 2019 at 10:24 AM Bharat Viswanadham
wrote:
> +1 for squash and merge.
>
> And if we use Github UI,
Thanks for all the positive feedback,
I opened INFRA-18777 to request the proposed change.
Marton
On 7/18/19 10:02 AM, Masatake Iwasaki wrote:
> +1
>
> Thanks,
> Masatake Iwasaki
>
> On 7/17/19 15:07, Elek, Marton wrote:
>> Hi,
>>
>> Github UI (ui!) helps to merge Pull Requests to the
+1
Thanks,
Masatake Iwasaki
On 7/17/19 15:07, Elek, Marton wrote:
Hi,
Github UI (ui!) helps to merge Pull Requests to the proposed branch.
There are three different ways to do it [1]:
1. Keep all the different commits from the PR branch and create one
additional merge commit ("Create a merge
sounds good! +1
Regards,
Da
> On Jul 17, 2019, at 7:32 PM, Dinesh Chitlangia
> wrote:
>
> +1, this is certainly useful.
>
> Thank you,
> Dinesh
>
>
>
>
>> On Wed, Jul 17, 2019 at 10:04 PM Akira Ajisaka wrote:
>>
>> Makes sense, +1
>>
>>> On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee
+1, this is certainly useful.
Thank you,
Dinesh
On Wed, Jul 17, 2019 at 10:04 PM Akira Ajisaka wrote:
> Makes sense, +1
>
> On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee wrote:
> >
> > +1. Sounds good to me.
> >
> > On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote:
> >
> > > +1
> > >
> >
Makes sense, +1
On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee wrote:
>
> +1. Sounds good to me.
>
> On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote:
>
> > +1
> >
> > On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran > >
> > wrote:
> >
> > > +1 for squash and merge, with whoever does the merge
+1. Sounds good to me.
On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote:
> +1
>
> On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran >
> wrote:
>
> > +1 for squash and merge, with whoever does the merge adding the full
> commit
> > message for the logs, with JIRA, contributor(s) etc
> >
> > One
+1
On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran
wrote:
> +1 for squash and merge, with whoever does the merge adding the full commit
> message for the logs, with JIRA, contributor(s) etc
>
> One limit of the github process is that the author of the commit becomes
> whoever hit the squash
+1 for squash and merge, with whoever does the merge adding the full commit
message for the logs, with JIRA, contributor(s) etc
One limit of the github process is that the author of the commit becomes
whoever hit the squash button, not whoever did the code, so it loses the
credit they are due.
+1 Good idea.
On Wed, Jul 17, 2019 at 9:37 AM Ayush Saxena wrote:
> Thanks Marton, Makes Sense +1
>
> > On 17-Jul-2019, at 11:37 AM, Elek, Marton wrote:
> >
> > Hi,
> >
> > Github UI (ui!) helps to merge Pull Requests to the proposed branch.
> > There are three different ways to do it [1]:
> >
Thanks Marton, Makes Sense +1
> On 17-Jul-2019, at 11:37 AM, Elek, Marton wrote:
>
> Hi,
>
> Github UI (ui!) helps to merge Pull Requests to the proposed branch.
> There are three different ways to do it [1]:
>
> 1. Keep all the different commits from the PR branch and create one
> additional
Makes sense, +1.
Thanks
+Vinod
> On Jul 17, 2019, at 11:37 AM, Elek, Marton wrote:
>
> Hi,
>
> Github UI (ui!) helps to merge Pull Requests to the proposed branch.
> There are three different ways to do it [1]:
>
> 1. Keep all the different commits from the PR branch and create one
>
+1, Lets have Squash and merge as the default & only option on github UI.
Thanks,
Mukul
On 7/17/19 11:37 AM, Elek, Marton wrote:
Hi,
Github UI (ui!) helps to merge Pull Requests to the proposed branch.
There are three different ways to do it [1]:
1. Keep all the different commits from the
Thanks Marton, +1 on this.
Weiwei
On Jul 17, 2019, 2:07 PM +0800, Elek, Marton , wrote:
> Hi,
>
> Github UI (ui!) helps to merge Pull Requests to the proposed branch.
> There are three different ways to do it [1]:
>
> 1. Keep all the different commits from the PR branch and create one
>
Hi,
Github UI (ui!) helps to merge Pull Requests to the proposed branch.
There are three different ways to do it [1]:
1. Keep all the different commits from the PR branch and create one
additional merge commit ("Create a merge commit")
2. Squash all the commits and commit the change as one
15 matches
Mail list logo
