Re: Guidance needed on HADOOP-13096 and HADOOP-13097

2016-05-06 Thread larry mccay
I agree with your rationale for not doing C now. And those clean up tasks can more easily be discussed when separated from this effort. On Fri, May 6, 2016 at 3:11 PM, Allen Wittenauer wrote: > After thinking about it, I think you are correct here: I’m more > inclined

Re: Guidance needed on HADOOP-13096 and HADOOP-13097

2016-05-06 Thread Allen Wittenauer
After thinking about it, I think you are correct here: I’m more inclined to do D w/follow-up JIRAs to fix this up. The hadoop and hdfs script functionality is being tested, so it isn’t like HADOOP-12930 is going in with zero unit tests. Never mind that large chunks of hadoop-tools gets

Re: Guidance needed on HADOOP-13096 and HADOOP-13097

2016-05-05 Thread Larry McCay
I would vote for C or D with a filed JIRA to clean up the maven structure as a separate effort. Before moving to D, could you describe any reason to not go with C? On May 4, 2016, at 9:51 PM, Allen Wittenauer wrote: > > When the sub-projects re-merged, maven work was

Guidance needed on HADOOP-13096 and HADOOP-13097

2016-05-04 Thread Allen Wittenauer
When the sub-projects re-merged, maven work was done, whatever, the shell scripts for MR and YARN were placed (effectively) outside of the normal maven hierarchy. In order to add unit tests to the shell scripts for these sub-projects, it means effectively turning