Re: Including Original Author in git commits.

2019-02-14 Thread Aaron Fabbri
+1. I think formatted patches and PRs will be an improvement. I've used the git --committer thing a couple of times here without issue. Another unrelated improvement with github is handling of large changes. I really think large patches should be split up into logical subcommitts and PR's support

Re: Including Original Author in git commits.

2019-02-14 Thread Steve Loughran
Yetus is adding support for github PRs, we can adopt it. There's already a github a/c for it (hadoop-yetus) and a goal of adopting the new Yetus. Be great to have people involved here On Thu, Feb 14, 2019 at 1:24 PM Vinayakumar B wrote: > So.. if we started doing that already.. we can encourage

Re: Including Original Author in git commits.

2019-02-14 Thread Vinayakumar B
So.. if we started doing that already.. we can encourage contributors to attach formatted patch.. or create PRs. And update wiki to follow exact steps to contribute and commit. -Vinay On Thu, 14 Feb 2019, 4:54 pm Steve Loughran I've been trying to do that recently, though as it forces me to go

Re: Including Original Author in git commits.

2019-02-14 Thread Steve Loughran
I've been trying to do that recently, though as it forces me to go to the command line rather than using Atlassian Sourcetree, I've been getting other things wrong. To those people who have been dealing with commits I've managed to mess up: apologies. 1. Once someone is down as an author you don't

Re: Including Original Author in git commits.

2019-02-14 Thread Akira Ajisaka
Hi Vinay, I'm already doing this if I can get the original author name and the email address in some way. If the patch is created by git format-patch command, smart-apply-patch --committer option can do this automatically. Thanks, Akira On Thu, Feb 14, 2019 at 3:27 PM Vinayakumar B wrote: > > H

Including Original Author in git commits.

2019-02-13 Thread Vinayakumar B
Hi all, Right now we are committing with commitrer name as author and adding contributor name in commit message. This way of committing will not reflect in contributors git profile. I believe current way of crediting.. is based on SVN days.. Since now all apache repos are following git.. we can