RE: IMPORTANT: testing patches for branches

-...@hadoop.apache.org; mapreduce-...@hadoop.apache.org; yarn-...@hadoop.apache.org Subject: Re: IMPORTANT: testing patches for branches On Apr 22, 2015, at 11:34 PM, Zheng, Kai wrote: > Hi Allen, > > This sounds great. > >>> Naming a patch foo-HDFS-7285.00.patch should get te

Re: IMPORTANT: testing patches for branches

Allen, I am not questioning whether checkstyle is a requirement. My concern is that some of the rules in there are arcane/unnecessary - we should use a better list of rules, in my opinion. This is why I filed HADOOP-11869. As pointed out by Jason, this is not a dupe of HADOOP-11866

Re: IMPORTANT: testing patches for branches

On Apr 23, 2015, at 7:57 PM, Sidharta Seethana wrote: > About (3.) , a lot of the check style rules seem to be arcane/unnecessary. > Please see : https://issues.apache.org/jira/browse/HADOOP-11869 a) I've closed it as a dupe of HADOOP-11866 to keep everything in one place. b) I've had HADO

Re: IMPORTANT: testing patches for branches

On Apr 24, 2015, at 3:09 AM, Brahma Reddy Battula wrote: > The patch artifact directory on has been removed! > This is a fatal error for test-patch.sh. Aborting. > Jenkins (node H8) information at > https://builds.apache.org/job/PreCommit-YARN-Build/7477/ may provide some > hints. ( did I mi

RE: IMPORTANT: testing patches for branches

hana [sidharta.apa...@gmail.com] Sent: Friday, April 24, 2015 12:27 AM To: common-dev@hadoop.apache.org Subject: Re: IMPORTANT: testing patches for branches About (3.) , a lot of the check style rules seem to be arcane/unnecessary. Please see : https://issues.apache.org/jira/browse/HADOOP-11869 On Thu, Ap

Re: IMPORTANT: testing patches for branches

About (3.) , a lot of the check style rules seem to be arcane/unnecessary. Please see : https://issues.apache.org/jira/browse/HADOOP-11869 On Thu, Apr 23, 2015 at 10:45 AM, Steve Loughran wrote: > > 1. I really like the new patch process, especially the at-a-glance summary > 2. I think being -1

Re: IMPORTANT: testing patches for branches

1. I really like the new patch process, especially the at-a-glance summary 2. I think being -1 on whitespace is overkill; Its just part of my " git apply -p 0 -3 --verbose --whitespace=fix " action. Accordingly, I won't reject patches on whitespace alone. 3. if checkstyle is complaining, how to

Re: IMPORTANT: testing patches for branches

On Apr 22, 2015, at 11:34 PM, Zheng, Kai wrote: > Hi Allen, > > This sounds great. > >>> Naming a patch foo-HDFS-7285.00.patch should get tested on the HDFS-7285 >>> branch. > Does it happen locally in developer's machine when running test-patch.sh, or > also mean something in Hadoop Jen

RE: IMPORTANT: testing patches for branches

Hi Allen, This sounds great. >> Naming a patch foo-HDFS-7285.00.patch should get tested on the HDFS-7285 >> branch. Does it happen locally in developer's machine when running test-patch.sh, or also mean something in Hadoop Jenkins building when a JIRA becoming patch available? Thanks. Regard

Re: IMPORTANT: testing patches for branches

Perhaps a script is due that creates the patch file with -exactly- the right name. Something like what HBase has as dev-support/make_patch.sh perhaps? On Wed, Apr 22, 2015 at 10:30 PM, Allen Wittenauer wrote: > > Oh, this is also in the release notes, but one can use a git reference # > as well.

Re: IMPORTANT: testing patches for branches

Oh, this is also in the release notes, but one can use a git reference # as well. :) (with kudos to OOM for the idea.) On Apr 22, 2015, at 8:57 PM, Allen Wittenauer wrote: > > More than likely. It probably needs more testing (esp under Jenkins). > > It should be noted that the code in test

Re: IMPORTANT: testing patches for branches

More than likely. It probably needs more testing (esp under Jenkins). It should be noted that the code in test-patch.sh has lots of problems with branch-0, minor, and micro releases. But for major releases, it seems to work well for me. :) On Apr 22, 2015, at 8:45 PM, Vinod Kumar Vavilapa

Re: IMPORTANT: testing patches for branches

Does this mean HADOOP-7435 is no longer needed / closeable as dup? Thanks +Vinod On Apr 22, 2015, at 12:34 PM, Allen Wittenauer wrote: > > Hey gang, > > Just so everyone is aware, if you are working on a patch for either a > feature branch or a major branch, if you name the patc