[jira] [Assigned] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Yuanbo Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuanbo Liu reassigned HADOOP-13441: --- Assignee: Yuanbo Liu > Document LdapGroupsMapping keystore password properties >

[jira] [Commented] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Yuanbo Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400383#comment-15400383 ] Yuanbo Liu commented on HADOOP-13441: - [~jojochuang]Thank you for filing this, I'd like to work on

[jira] [Comment Edited] (HADOOP-13439) Fix race between TestMetricsSystemImpl and TestGangliaMetrics

2016-07-29 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400285#comment-15400285 ] Chen Liang edited comment on HADOOP-13439 at 7/30/16 12:11 AM: --- Hi

[jira] [Commented] (HADOOP-13439) Fix race between TestMetricsSystemImpl and TestGangliaMetrics

2016-07-29 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400285#comment-15400285 ] Chen Liang commented on HADOOP-13439: - Hi [~iwasakims], Any updates on this issue? As I found this

[jira] [Commented] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400269#comment-15400269 ] Xiao Chen commented on HADOOP-13443: Thanks very much for finding and fixing this,

[jira] [Comment Edited] (HADOOP-13436) RPC connections are leaking due to missing equals override in RetryUtils#getDefaultRetryPolicy

2016-07-29 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400217#comment-15400217 ] Mingliang Liu edited comment on HADOOP-13436 at 7/29/16 11:25 PM: -- I'm

[jira] [Commented] (HADOOP-13436) RPC connections are leaking due to missing equals override in RetryUtils#getDefaultRetryPolicy

2016-07-29 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400217#comment-15400217 ] Mingliang Liu commented on HADOOP-13436: I'm in favor of making {{RetryPolicy}} an abstract

[jira] [Commented] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400170#comment-15400170 ] Hadoop QA commented on HADOOP-13443: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-13434) Add quoting to Shell class

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400166#comment-15400166 ] Hadoop QA commented on HADOOP-13434: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-13444) Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400162#comment-15400162 ] Hadoop QA commented on HADOOP-13444: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-13081) add the ability to create multiple UGIs/subjects from one kerberos login

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400147#comment-15400147 ] Hadoop QA commented on HADOOP-13081: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HADOOP-13434) Add quoting to Shell class

2016-07-29 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen O'Malley updated HADOOP-13434: --- Attachment: HADOOP-13434.patch I made some tweaks to make check style happy. > Add quoting

[jira] [Updated] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Anthony Young-Garner (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Young-Garner updated HADOOP-13443: -- Status: Patch Available (was: Open) > KMS uses DefaultCryptoProvider when

[jira] [Updated] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Anthony Young-Garner (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Young-Garner updated HADOOP-13443: -- Attachment: HADOOP-13443.patch > KMS uses DefaultCryptoProvider when active

[jira] [Commented] (HADOOP-13081) add the ability to create multiple UGIs/subjects from one kerberos login

2016-07-29 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400072#comment-15400072 ] Chris Nauroth commented on HADOOP-13081: Nice catch on cloning the Hadoop {{Credentials}}

[jira] [Updated] (HADOOP-13081) add the ability to create multiple UGIs/subjects from one kerberos login

2016-07-29 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HADOOP-13081: -- Attachment: HADOOP-13081.02.patch Updating the patch to remove tabs > add the

[jira] [Commented] (HADOOP-13336) support cross-region operations in S3a

2016-07-29 Thread Steven K. Wong (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400047#comment-15400047 ] Steven K. Wong commented on HADOOP-13336: - S3A already supports cross-region, if your config

[jira] [Updated] (HADOOP-13444) Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

2016-07-29 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated HADOOP-13444: -- Attachment: HADOOP-13444.patch > Replace org.apache.commons.io.Charsets with

[jira] [Updated] (HADOOP-13444) Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

2016-07-29 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated HADOOP-13444: -- Fix Version/s: (was: 2.7.2) 2.7.4 Affects Version/s:

[jira] [Commented] (HADOOP-13081) add the ability to create multiple UGIs/subjects from one kerberos login

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400042#comment-15400042 ] Hadoop QA commented on HADOOP-13081: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Created] (HADOOP-13444) Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

2016-07-29 Thread Vincent Poon (JIRA)
Vincent Poon created HADOOP-13444: - Summary: Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets Key: HADOOP-13444 URL: https://issues.apache.org/jira/browse/HADOOP-13444

[jira] [Updated] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Anthony Young-Garner (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Young-Garner updated HADOOP-13443: -- Flags: (was: Patch) > KMS uses DefaultCryptoProvider when active

[jira] [Created] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-07-29 Thread Anthony Young-Garner (JIRA)
Anthony Young-Garner created HADOOP-13443: - Summary: KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension Key: HADOOP-13443 URL:

[jira] [Commented] (HADOOP-11540) Raw Reed-Solomon coder using Intel ISA-L library

2016-07-29 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400011#comment-15400011 ] Kai Zheng commented on HADOOP-11540: Per Aaron's below comments: bq. I'll be +1 once this is

[jira] [Updated] (HADOOP-13081) add the ability to create multiple UGIs/subjects from one kerberos login

2016-07-29 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HADOOP-13081: -- Attachment: HADOOP-13081.02.patch Added the test and some additional logic to clone

[jira] [Commented] (HADOOP-13434) Add quoting to Shell class

2016-07-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399904#comment-15399904 ] ASF GitHub Bot commented on HADOOP-13434: - Github user arp7 commented on the issue:

[jira] [Commented] (HADOOP-13208) S3A listFiles(recursive=true) to do a bulk listObjects instead of walking the pseudo-tree of directories

2016-07-29 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399881#comment-15399881 ] Chris Nauroth commented on HADOOP-13208: [~fabbri], thank you for your code review. This is

[jira] [Commented] (HADOOP-13442) Optimize UGI group lookups

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399880#comment-15399880 ] Hadoop QA commented on HADOOP-13442: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-13434) Add quoting to Shell class

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399820#comment-15399820 ] Hadoop QA commented on HADOOP-13434: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HADOOP-13442) Optimize UGI group lookups

2016-07-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HADOOP-13442: - Status: Patch Available (was: Open) Will be much more useful with hdfs counterpart. >

[jira] [Updated] (HADOOP-13442) Optimize UGI group lookups

2016-07-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HADOOP-13442: - Attachment: HADOOP-13442.patch # Changed group provider to cache the de-dupped list instead of

[jira] [Comment Edited] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399461#comment-15399461 ] Wei-Chiu Chuang edited comment on HADOOP-13353 at 7/29/16 6:13 PM: --- I

[jira] [Updated] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-13441: - Description: A few properties are not documented.

[jira] [Created] (HADOOP-13442) Optimize UGI group lookups

2016-07-29 Thread Daryn Sharp (JIRA)
Daryn Sharp created HADOOP-13442: Summary: Optimize UGI group lookups Key: HADOOP-13442 URL: https://issues.apache.org/jira/browse/HADOOP-13442 Project: Hadoop Common Issue Type: Improvement

[jira] [Updated] (HADOOP-13434) Add quoting to Shell class

2016-07-29 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen O'Malley updated HADOOP-13434: --- Status: Patch Available (was: Open) > Add quoting to Shell class >

[jira] [Updated] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-13441: - Component/s: security > Document LdapGroupsMapping keystore password properties >

[jira] [Updated] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-13441: - Affects Version/s: 2.6.0 > Document LdapGroupsMapping keystore password properties >

[jira] [Updated] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-13441: - Labels: documentation (was: ) > Document LdapGroupsMapping keystore password

[jira] [Commented] (HADOOP-13403) AzureNativeFileSystem rename/delete performance improvements

2016-07-29 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399707#comment-15399707 ] Chris Nauroth commented on HADOOP-13403: [~pattipaka], in addition to the earlier code review

[jira] [Created] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
Wei-Chiu Chuang created HADOOP-13441: Summary: Document LdapGroupsMapping keystore password properties Key: HADOOP-13441 URL: https://issues.apache.org/jira/browse/HADOOP-13441 Project: Hadoop

[jira] [Commented] (HADOOP-13426) More efficiently build IPC responses

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399525#comment-15399525 ] Hadoop QA commented on HADOOP-13426: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399461#comment-15399461 ] Wei-Chiu Chuang commented on HADOOP-13353: -- I see that when the IOException is thrown, the log

[jira] [Updated] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-13353: - Labels: supportability (was: ) > LdapGroupsMapping getPassward shouldn't return null

[jira] [Commented] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-07-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399455#comment-15399455 ] Wei-Chiu Chuang commented on HADOOP-13353: -- The fix looks good to me. Thanks

[jira] [Updated] (HADOOP-13426) More efficiently build IPC responses

2016-07-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HADOOP-13426: - Attachment: HADOOP-13426.1.patch Make checkstyle happy. > More efficiently build IPC responses

[jira] [Commented] (HADOOP-9565) Add a Blobstore interface to add to blobstore FileSystems

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399420#comment-15399420 ] Hadoop QA commented on HADOOP-9565: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HADOOP-13436) RPC connections are leaking due to missing equals override in RetryUtils#getDefaultRetryPolicy

2016-07-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399409#comment-15399409 ] Daryn Sharp commented on HADOOP-13436: -- bq. Does it mean it leads to performance issues?

[jira] [Updated] (HADOOP-9565) Add a Blobstore interface to add to blobstore FileSystems

2016-07-29 Thread Pieter Reuse (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pieter Reuse updated HADOOP-9565: - Attachment: HADOOP-9565-007.patch Uploaded patch version 7: * Renamed

[jira] [Comment Edited] (HADOOP-13222) s3a.mkdirs() to delete empty fake parent directories

2016-07-29 Thread Shen Yinjie (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398947#comment-15398947 ] Shen Yinjie edited comment on HADOOP-13222 at 7/29/16 8:36 AM: --- I firstly

[jira] [Comment Edited] (HADOOP-13222) s3a.mkdirs() to delete empty fake parent directories

2016-07-29 Thread Shen Yinjie (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398947#comment-15398947 ] Shen Yinjie edited comment on HADOOP-13222 at 7/29/16 8:25 AM: --- I firstly

[jira] [Commented] (HADOOP-13222) s3a.mkdirs() to delete empty fake parent directories

2016-07-29 Thread Shen Yinjie (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398947#comment-15398947 ] Shen Yinjie commented on HADOOP-13222: -- I firstly create object {{aa/bb}} with aws-java-sdk, and it

[jira] [Commented] (HADOOP-13437) KMS should reload whitelist and default key ACLs when hot-reloading

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398851#comment-15398851 ] Hadoop QA commented on HADOOP-13437: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Comment Edited] (HADOOP-13437) KMS should reload whitelist and default key ACLs when hot-reloading

2016-07-29 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398801#comment-15398801 ] Xiao Chen edited comment on HADOOP-13437 at 7/29/16 6:29 AM: - Thanks

[jira] [Updated] (HADOOP-13437) KMS should reload whitelist and default key ACLs when hot-reloading

2016-07-29 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Chen updated HADOOP-13437: --- Attachment: HADOOP-13437.03.patch Thanks [~andrew.wang] for the great comments! I confess I was too

[jira] [Commented] (HADOOP-13440) FileContext does not react on changing umask via configuration

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398790#comment-15398790 ] Hadoop QA commented on HADOOP-13440: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||