[GitHub] [hadoop] hadoop-yetus commented on issue #1084: HDDS-1492. Generated chunk size name too long.

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1084: HDDS-1492. Generated chunk size name too long. URL: https://github.com/apache/hadoop/pull/1084#issuecomment-511690232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hadoop] iamcaoxudong opened a new pull request #1103: HDFS-14646. Standby NameNode should terminate the FsImage put process immediately if the peer NN is not in the appropriate state to rece

2019-07-15 Thread GitBox
iamcaoxudong opened a new pull request #1103: HDFS-14646. Standby NameNode should terminate the FsImage put process immediately if the peer NN is not in the appropriate state to receive an image. URL: https://github.com/apache/hadoop/pull/1103 … immediately if the peer NN is not in the app

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747037 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on issue #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#issuecomment-511686261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747047 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747009 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746946 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746964 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746996 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/utils/O

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747018 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746970 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747027 ## File path: hadoop-ozone/objectstore-service/src/main/java/org/apache/hadoop/ozon

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746991 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/utils/O

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746978 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747034 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746939 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303747003 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303746986 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] iamcaoxudong closed pull request #1093: HDFS-14646. Standby NameNode should terminate the FsImage put process…

2019-07-15 Thread GitBox
iamcaoxudong closed pull request #1093: HDFS-14646. Standby NameNode should terminate the FsImage put process… URL: https://github.com/apache/hadoop/pull/1093 This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] bharatviswa504 edited a comment on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 edited a comment on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511663998 Thank You @arp7 for the review. I will commit this to the trunk. Ran S3 secure acceptance test suite locally, te

[GitHub] [hadoop] bharatviswa504 merged pull request #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 merged pull request #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hadoop] bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511663998 Thank You @arp7 for the review. I will commit this to the trunk. --

[GitHub] [hadoop] bshashikant commented on issue #1084: HDDS-1492. Generated chunk size name too long.

2019-07-15 Thread GitBox
bshashikant commented on issue #1084: HDDS-1492. Generated chunk size name too long. URL: https://github.com/apache/hadoop/pull/1084#issuecomment-511663920 The updated patch addresses checkstyle issues. I have also verified the name of chunk file in dn. ---

[GitHub] [hadoop] bshashikant commented on issue #1084: HDDS-1492. Generated chunk size name too long.

2019-07-15 Thread GitBox
bshashikant commented on issue #1084: HDDS-1492. Generated chunk size name too long. URL: https://github.com/apache/hadoop/pull/1084#issuecomment-511663557 The updated patch addresses checkstyle issues. I have also verified the name of chunk file in dn. ---

[GitHub] [hadoop] hadoop-yetus commented on issue #1102: HDDS-1803. shellcheck.sh does not work on Mac

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1102: HDDS-1803. shellcheck.sh does not work on Mac URL: https://github.com/apache/hadoop/pull/1102#issuecomment-511657290 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[GitHub] [hadoop] hadoop-yetus commented on issue #1096: HDDS-1793. Acceptance test of ozone-topology cluster is failing

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1096: HDDS-1793. Acceptance test of ozone-topology cluster is failing URL: https://github.com/apache/hadoop/pull/1096#issuecomment-511657023 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[jira] [Commented] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885821#comment-16885821 ] Hadoop QA commented on HADOOP-16386: | (/) *{color:green}+1 overall{color}* | \\ \\

[jira] [Updated] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-16386: -- Status: Patch Available (was: Open) > FindBugs warning in branch-2: GlobalStorageSta

[GitHub] [hadoop] adoroszlai commented on issue #1102: HDDS-1803. shellcheck.sh does not work on Mac

2019-07-15 Thread GitBox
adoroszlai commented on issue #1102: HDDS-1803. shellcheck.sh does not work on Mac URL: https://github.com/apache/hadoop/pull/1102#issuecomment-511648883 /label ozone This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885804#comment-16885804 ] Masatake Iwasaki commented on HADOOP-16386: --- Adding filter pattern would be m

[jira] [Updated] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-16386: -- Attachment: HADOOP-16386-branch-2.002.patch > FindBugs warning in branch-2: GlobalSto

[GitHub] [hadoop] adoroszlai opened a new pull request #1102: HDDS-1803. shellcheck.sh does not work on Mac

2019-07-15 Thread GitBox
adoroszlai opened a new pull request #1102: HDDS-1803. shellcheck.sh does not work on Mac URL: https://github.com/apache/hadoop/pull/1102 ## What changes were proposed in this pull request? * Filter for file permission on Mac. * Merge two separate `find` calls to avoid overwriti

[GitHub] [hadoop] hadoop-yetus commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511647235 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[jira] [Comment Edited] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885790#comment-16885790 ] Masatake Iwasaki edited comment on HADOOP-16386 at 7/16/19 2:58 AM: -

[jira] [Updated] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-16386: -- Attachment: HADOOP-16386-branch-2.001.patch > FindBugs warning in branch-2: GlobalSto

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709343 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709367 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709337 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709318 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709361 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709417 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709405 ## File path: hadoop-ozone/objectstore-service/src/main/java/org/apache/hadoop/ozon

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709450 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/O

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709348 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/utils/O

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709353 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/utils/O

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709432 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709335 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709302 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709421 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709339 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709375 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709392 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709399 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709360 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ###

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709315 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709308 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709426 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709327 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709388 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709396 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709437 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709324 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709413 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/B

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709373 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709378 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on issue #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#issuecomment-511642985 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709384 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/c

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709298 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709403 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709445 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/K

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709283 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709293 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709280 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709290 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
hadoop-yetus commented on a change in pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101#discussion_r303709275 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.ja

[jira] [Commented] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885790#comment-16885790 ] Masatake Iwasaki commented on HADOOP-16386: --- We got the error on branch-2 but

[jira] [Assigned] (HADOOP-16386) FindBugs warning in branch-2: GlobalStorageStatistics defines non-transient non-serializable instance field map

2019-07-15 Thread Masatake Iwasaki (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki reassigned HADOOP-16386: - Assignee: Masatake Iwasaki > FindBugs warning in branch-2: GlobalStorageStatis

[GitHub] [hadoop] ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client.

2019-07-15 Thread GitBox
ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client. URL: https://github.com/apache/hadoop/pull/1094#discussion_r303705636 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBloc

[GitHub] [hadoop] ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client.

2019-07-15 Thread GitBox
ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client. URL: https://github.com/apache/hadoop/pull/1094#discussion_r303705636 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBloc

[GitHub] [hadoop] ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client.

2019-07-15 Thread GitBox
ChenSammi commented on a change in pull request #1094: HDDS-1787. NPE thrown while trying to find DN closest to client. URL: https://github.com/apache/hadoop/pull/1094#discussion_r303705636 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBloc

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1096: HDDS-1793. Acceptance test of ozone-topology cluster is failing

2019-07-15 Thread GitBox
adoroszlai commented on a change in pull request #1096: HDDS-1793. Acceptance test of ozone-topology cluster is failing URL: https://github.com/apache/hadoop/pull/1096#discussion_r303705545 ## File path: hadoop-ozone/dist/src/main/compose/testlib.sh ## @@ -28,7 +28,7 @@ mk

[GitHub] [hadoop] hadoop-yetus commented on issue #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#issuecomment-511634741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hadoop] hadoop-yetus commented on issue #1099: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1099: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1099#issuecomment-511633015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 opened a new pull request #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511626065 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
bharatviswa504 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511626101 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#discussion_r303694634 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCacheImpl.java ###

[GitHub] [hadoop] arp7 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
arp7 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#discussion_r303692949 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -104,14

[GitHub] [hadoop] arp7 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
arp7 commented on a change in pull request #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#discussion_r303692835 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -83,11 +

[GitHub] [hadoop] arp7 merged pull request #943: HDDS-1666. Issue in openKey when allocating block.

2019-07-15 Thread GitBox
arp7 merged pull request #943: HDDS-1666. Issue in openKey when allocating block. URL: https://github.com/apache/hadoop/pull/943 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] bharatviswa504 merged pull request #1052: HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes.

2019-07-15 Thread GitBox
bharatviswa504 merged pull request #1052: HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes. URL: https://github.com/apache/hadoop/pull/1052 This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop] bharatviswa504 commented on issue #1052: HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes.

2019-07-15 Thread GitBox
bharatviswa504 commented on issue #1052: HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes. URL: https://github.com/apache/hadoop/pull/1052#issuecomment-511621943 Thank You @arp7 for the review. Test failures are not related to this patch. Will commit this to the trun

[GitHub] [hadoop] arp7 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests.

2019-07-15 Thread GitBox
arp7 commented on issue #1038: HDDS-1736. Cleanup 2phase old HA code for Key requests. URL: https://github.com/apache/hadoop/pull/1038#issuecomment-511621402 +1 LGTM. Feel free to commit with checkstyle issues fixed. I assume you verified the test failures are unrelated. ---

[GitHub] [hadoop] xiaoyuyao opened a new pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. …

2019-07-15 Thread GitBox
xiaoyuyao opened a new pull request #1101: HDDS-1544. Support default Acls for volume, bucket, keys and prefix. … URL: https://github.com/apache/hadoop/pull/1101 …Contributed by Ajay Kumar. Some additional change to fix the unit tests and checkstyle issue. TestOzoneRpcClientW

[GitHub] [hadoop] bharatviswa504 edited a comment on issue #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 edited a comment on issue #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#issuecomment-511618921 One missing thing in this PR is on the restart, we should load up tables with cache, where cleanup policy is NEVER from DB.

[GitHub] [hadoop] bharatviswa504 commented on issue #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 commented on issue #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100#issuecomment-511618921 One missing in this PR is on the restart, we should load up tables with cache, where cleanup policy is NEVER from DB. Will post a

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1100: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 opened a new pull request #1100: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1100 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] bharatviswa504 closed pull request #1099: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 closed pull request #1099: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1099 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1099: HDDS-1802. Add Eviction policy for table cache.

2019-07-15 Thread GitBox
bharatviswa504 opened a new pull request #1099: HDDS-1802. Add Eviction policy for table cache. URL: https://github.com/apache/hadoop/pull/1099 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] hadoop-yetus commented on issue #1098: HDDS-1801. Make Topology Aware Replication/Read non-default for ozone…

2019-07-15 Thread GitBox
hadoop-yetus commented on issue #1098: HDDS-1801. Make Topology Aware Replication/Read non-default for ozone… URL: https://github.com/apache/hadoop/pull/1098#issuecomment-511612217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

  1   2   >