[GitHub] [hadoop] ehiggs commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

ehiggs commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#issuecomment-522478887 Updated MR to fix findbugs and checkstyle issues. This is a

[GitHub] [hadoop] iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r315192775 ## File path: LICENSE-binary ## @@ -0,0 +1,531 @@ + + Apache Licen

[GitHub] [hadoop] iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

iwasakims commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r315193836 ## File path: LICENSE-binary ## @@ -0,0 +1,531 @@ + + Apache Licen

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1310: HDDS-1978. Create helper script to run blockade tests.

mukul1987 commented on a change in pull request #1310: HDDS-1978. Create helper script to run blockade tests. URL: https://github.com/apache/hadoop/pull/1310#discussion_r315245144 ## File path: hadoop-ozone/dev-support/checks/blockade.sh ## @@ -0,0 +1,28 @@ +#!/usr/bin/env

[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1310: HDDS-1978. Create helper script to run blockade tests.

nandakumar131 commented on a change in pull request #1310: HDDS-1978. Create helper script to run blockade tests. URL: https://github.com/apache/hadoop/pull/1310#discussion_r315247298 ## File path: hadoop-ozone/dev-support/checks/blockade.sh ## @@ -0,0 +1,28 @@ +#!/usr/bin

[GitHub] [hadoop] leosunli opened a new pull request #1314: HDFS-14748. Make DataNodePeerMetrics#minOutlierDetectionSamples configurable

leosunli opened a new pull request #1314: HDFS-14748. Make DataNodePeerMetrics#minOutlierDetectionSamples configurable URL: https://github.com/apache/hadoop/pull/1314 Signed-off-by: sunlisheng This is an automated message fr

[GitHub] [hadoop] bshashikant commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart.

bshashikant commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart. URL: https://github.com/apache/hadoop/pull/1226#issuecomment-522623256 The test failures are not related to the patch.

[jira] [Commented] (HADOOP-15998) Jar validation bash scripts don't work on Windows due to platform differences (colons in paths, \r\n)

[ https://issues.apache.org/jira/browse/HADOOP-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910512#comment-16910512 ] Sean Busbey commented on HADOOP-15998: -- the current qa result looks promising. I h

[GitHub] [hadoop] sunilgovind commented on issue #1297: HDFS-14729. Upgrade Bootstrap and jQuery versions used in HDFS UIs

sunilgovind commented on issue #1297: HDFS-14729. Upgrade Bootstrap and jQuery versions used in HDFS UIs URL: https://github.com/apache/hadoop/pull/1297#issuecomment-522656664 +1 This is an automated message from the Apache G

[GitHub] [hadoop] hanishakoneru commented on issue #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager

hanishakoneru commented on issue #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager URL: https://github.com/apache/hadoop/pull/1259#issuecomment-522674063 Thank you @avijayanhwx. +1

[GitHub] [hadoop] bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#issuecomment-522679586 I see tests are passing locally on my laptop. I was able to test ha-proxy with aws cli. Not able to figure

[GitHub] [hadoop] bharatviswa504 edited a comment on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 edited a comment on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#issuecomment-522679586 I see tests are passing locally on my laptop. I was able to test ha-proxy with aws cli. Not able to

[GitHub] [hadoop] hanishakoneru merged pull request #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager

hanishakoneru merged pull request #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager URL: https://github.com/apache/hadoop/pull/1259 This is an automated message from the Apach

[jira] [Commented] (HADOOP-16478) S3Guard bucket-info fails if the bucket location is denied to the caller

[ https://issues.apache.org/jira/browse/HADOOP-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910620#comment-16910620 ] Steve Loughran commented on HADOOP-16478: - also doc for s3guard that you need t

[jira] [Commented] (HADOOP-16478) S3Guard bucket-info fails if the bucket location is denied to the caller

[ https://issues.apache.org/jira/browse/HADOOP-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910621#comment-16910621 ] Steve Loughran commented on HADOOP-16478: - +have the DDB metastore print this f

[jira] [Assigned] (HADOOP-14784) [KMS] Improve KeyAuthorizationKeyProvider#toString()

[ https://issues.apache.org/jira/browse/HADOOP-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-14784: Assignee: Yeliang Cang > [KMS] Improve KeyAuthorizationKeyProvider#toString() >

[jira] [Commented] (HADOOP-14784) [KMS] Improve KeyAuthorizationKeyProvider#toString()

[ https://issues.apache.org/jira/browse/HADOOP-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910625#comment-16910625 ] Wei-Chiu Chuang commented on HADOOP-14784: -- +1 sorry i missed this one. > [K

[jira] [Updated] (HADOOP-14784) [KMS] Improve KeyAuthorizationKeyProvider#toString()

[ https://issues.apache.org/jira/browse/HADOOP-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-14784: - Fix Version/s: 3.3.0 Resolution: Fixed Status: Resolved (was: Patch A

[jira] [Commented] (HADOOP-14784) [KMS] Improve KeyAuthorizationKeyProvider#toString()

[ https://issues.apache.org/jira/browse/HADOOP-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910638#comment-16910638 ] Hudson commented on HADOOP-14784: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] jojochuang closed pull request #1294: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

jojochuang closed pull request #1294: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields URL: https://github.com/apache/hadoop/pull/1294 This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop] jojochuang opened a new pull request #1294: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

jojochuang opened a new pull request #1294: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields URL: https://github.com/apache/hadoop/pull/1294 Forked from PR #1291 This is an automated message from the Ap

[GitHub] [hadoop] hadoop-yetus commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

hadoop-yetus commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#issuecomment-522721525 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HADOOP-14784) [KMS] Improve KeyAuthorizationKeyProvider#toString()

[ https://issues.apache.org/jira/browse/HADOOP-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910685#comment-16910685 ] Hadoop QA commented on HADOOP-14784: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] arp7 commented on a change in pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

arp7 commented on a change in pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#discussion_r315393614 ## File path: hadoop-ozone/dist/src/main/compose/ozones3-haproxy/docker-compose.yaml #

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

bharatviswa504 opened a new pull request #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315 This is an automated message from the Apache Git Service

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 commented on a change in pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#discussion_r315409086 ## File path: hadoop-ozone/dist/src/main/compose/ozones3-haproxy/docker-compose.y

[GitHub] [hadoop] bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#issuecomment-522751627 Thank You @arp7 and @adoroszlai for the review. I will commit this to the trunk. ---

[GitHub] [hadoop] bharatviswa504 merged pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 merged pull request #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304 This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop] bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end.

bharatviswa504 commented on issue #1304: HDDS-1972. Provide example ha proxy with multiple s3 servers back end. URL: https://github.com/apache/hadoop/pull/1304#issuecomment-522752048 > +1 > > @adoroszlai are you okay to commit this? Got a +1 from @adoroszlai already, so commit

[GitHub] [hadoop] bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-522762718 /retest This is an automated message from

[GitHub] [hadoop] hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r315425380 ## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/k

[GitHub] [hadoop] hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r315426293 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/k

[GitHub] [hadoop] hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r315426622 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/o

[GitHub] [hadoop] hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r315426753 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java ##

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315440404 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315440404 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-522782993 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] jojochuang commented on a change in pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active

jojochuang commented on a change in pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active URL: https://github.com/apache/hadoop/pull/467#discussion_r315449101 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/ap

[GitHub] [hadoop] jojochuang closed pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active

jojochuang closed pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active URL: https://github.com/apache/hadoop/pull/467 This is an automated message from the Apache Git

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315450501 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315452170 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315452344 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-522799727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315466190 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315467845 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315468225 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315468225 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315468225 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315467845 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1316: HDDS-1975. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

bharatviswa504 opened a new pull request #1316: HDDS-1975. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316 This is an automated message from the Apache

[GitHub] [hadoop] bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

bharatviswa504 commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-522814418 /retest This is an automated message from

[jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910895#comment-16910895 ] Wei-Chiu Chuang commented on HADOOP-16268: -- TBH I am not familiar with either

[GitHub] [hadoop] hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-522816675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r315486113 ## File path: LICENSE-binary ## @@ -0,0 +1,531 @@ + + Apache Licens

[GitHub] [hadoop] aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files

aajisaka commented on a change in pull request #1307: HADOOP-15958. Revisiting LICENSE and NOTICE files URL: https://github.com/apache/hadoop/pull/1307#discussion_r315488263 ## File path: LICENSE-binary ## @@ -0,0 +1,531 @@ + + Apache Licens

[GitHub] [hadoop] hadoop-yetus commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

hadoop-yetus commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#issuecomment-522835104 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Created] (HADOOP-16521) Subject has a contradiction between proxy user and real user

Yicong Cai created HADOOP-16521: --- Summary: Subject has a contradiction between proxy user and real user Key: HADOOP-16521 URL: https://issues.apache.org/jira/browse/HADOOP-16521 Project: Hadoop Common

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315495833 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.

hadoop-yetus commented on issue #1315: HDDS-1975. Implement default acls for bucket/volume/key for OM HA code. URL: https://github.com/apache/hadoop/pull/1315#issuecomment-522843858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[jira] [Commented] (HADOOP-16391) Duplicate values in rpcDetailedMetrics

[ https://issues.apache.org/jira/browse/HADOOP-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910998#comment-16910998 ] Bilwa S T commented on HADOOP-16391: Thank you [~xkrogen] for review and committing

[GitHub] [hadoop] mukul1987 commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart.

mukul1987 commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart. URL: https://github.com/apache/hadoop/pull/1226#issuecomment-522860509 Thanks for working on this @bshashikant. +1 the patch looks good to me. The test failures do not look related.

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911019#comment-16911019 ] Jinglun commented on HADOOP-15565: -- Hi [~xkrogen], do you have time to review this?  T