[GitHub] [hadoop] elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-20 Thread GitBox
elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#discussion_r316023955 ## File path: hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/ConfigurationSubCommand

[GitHub] [hadoop] elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-20 Thread GitBox
elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#discussion_r316024166 ## File path: hadoop-ozone/insight/pom.xml ## @@ -0,0 +1,137 @@ + + +http://maven.apache.org/PO

[GitHub] [hadoop] elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-20 Thread GitBox
elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#discussion_r316021395 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/protocolPB/ScmBlockLocationProtoc

[GitHub] [hadoop] elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-20 Thread GitBox
elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#discussion_r316019985 ## File path: hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/List.java ##

[GitHub] [hadoop] elek commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-20 Thread GitBox
elek commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#discussion_r316018169 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315991351 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315990829 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] XBaith opened a new pull request #1324: Fix a typo in TextInputFormat.java

2019-08-20 Thread GitBox
XBaith opened a new pull request #1324: Fix a typo in TextInputFormat.java URL: https://github.com/apache/hadoop/pull/1324 When I read source code about TextInputFormat, I found a typo. This is an automated message from the Ap

[GitHub] [hadoop] supratimdeka opened a new pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-20 Thread GitBox
supratimdeka opened a new pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323 https://issues.apache.org/jira/browse/HDDS-1094 Added an alternate ChunkManager

[GitHub] [hadoop] arp7 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
arp7 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315983569 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone

[GitHub] [hadoop] hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523270984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] hanishakoneru commented on issue #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-20 Thread GitBox
hanishakoneru commented on issue #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#issuecomment-523269653 Thank you @arp7 for the review. I addressed your comments in the new commit. Also added a unit test for restart. --

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-20 Thread GitBox
hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#discussion_r315976786 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OMRati

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-20 Thread GitBox
hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#discussion_r315976747 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneM

[GitHub] [hadoop] hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-20 Thread GitBox
hanishakoneru commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#discussion_r315976601 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315974547 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523267857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315974547 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315974275 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[jira] [Commented] (HADOOP-16496) Apply HDDS-1870 (ConcurrentModification at PrometheusMetricsSink) to Hadoop common

2019-08-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911859#comment-16911859 ] Hudson commented on HADOOP-16496: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] xiaoyuyao commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523256372 /retest This is an automated message from the A

[jira] [Updated] (HADOOP-16496) Apply HDDS-1870 (ConcurrentModification at PrometheusMetricsSink) to Hadoop common

2019-08-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16496: --- Fix Version/s: 3.3.0 Resolution: Fixed Status: Resolved (was: Patch Avail

[GitHub] [hadoop] aajisaka commented on issue #1317: HADOOP-16496. Apply HDDS-1870 (ConcurrentModification at PrometheusMe…

2019-08-20 Thread GitBox
aajisaka commented on issue #1317: HADOOP-16496. Apply HDDS-1870 (ConcurrentModification at PrometheusMe… URL: https://github.com/apache/hadoop/pull/1317#issuecomment-523254272 Committed to trunk. Thanks @bharatviswa504 for the review! --

[GitHub] [hadoop] aajisaka closed pull request #1317: HADOOP-16496. Apply HDDS-1870 (ConcurrentModification at PrometheusMe…

2019-08-20 Thread GitBox
aajisaka closed pull request #1317: HADOOP-16496. Apply HDDS-1870 (ConcurrentModification at PrometheusMe… URL: https://github.com/apache/hadoop/pull/1317 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-523250671 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
hadoop-yetus commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r315961347 ## File path: hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md #

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
hadoop-yetus commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r315961343 ## File path: hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md #

[GitHub] [hadoop] jojochuang commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-20 Thread GitBox
jojochuang commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#discussion_r315956729 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/name

[GitHub] [hadoop] hgadre opened a new pull request #1322: [HDDS-1994] Rename ScmBlockLocationTestIngClient.java to ScmBlockLocationTestingClient.java

2019-08-20 Thread GitBox
hgadre opened a new pull request #1322: [HDDS-1994] Rename ScmBlockLocationTestIngClient.java to ScmBlockLocationTestingClient.java URL: https://github.com/apache/hadoop/pull/1322 And revert HDDS-1965 This is an automated me

[jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

2019-08-20 Thread CR Hota (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911818#comment-16911818 ] CR Hota commented on HADOOP-16268: -- [~xkrogen] Thanks for the comments. Your point is

[jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

2019-08-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911804#comment-16911804 ] Hadoop QA commented on HADOOP-16268: | (/) *{color:green}+1 overall{color}* | \\ \\

[GitHub] [hadoop] steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-523229305 last update moves to a probe set so you can choose what to look for; maybeCreateFakeDirectory uses this to only do the LIST

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315940082 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] hadoop-yetus commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#issuecomment-523228861 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315938903 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r315939643 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java

[GitHub] [hadoop] steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-20 Thread GitBox
steveloughran commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r315938976 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315938903 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315934269 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315932118 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/Ozo

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315929987 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315929710 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315925326 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315925066 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315924477 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/ha

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315922467 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[jira] [Commented] (HADOOP-16523) Minor spell mistake in comment (PR#388)

2019-08-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911752#comment-16911752 ] Hudson commented on HADOOP-16523: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] hadoop-yetus commented on issue #284: HADOOP-14157 fix parseUrl to replace '\' for '/'

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #284: HADOOP-14157 fix parseUrl to replace '\' for '/' URL: https://github.com/apache/hadoop/pull/284#issuecomment-523205375 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315913008 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] hadoop-yetus commented on issue #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#issuecomment-523202633 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315908368 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] hadoop-yetus commented on issue #269: HADOOP-14217. Support colon in Hadoop Path

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #269: HADOOP-14217. Support colon in Hadoop Path URL: https://github.com/apache/hadoop/pull/269#issuecomment-523196673 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315901670 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315901670 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helper

[GitHub] [hadoop] hadoop-yetus commented on issue #231: HADOOP-14508. TestDFSIO throws NPE when set -sequential argument.

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #231: HADOOP-14508. TestDFSIO throws NPE when set -sequential argument. URL: https://github.com/apache/hadoop/pull/231#issuecomment-523190847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] cclauss commented on issue #436: Use print() function in both Python 2 and Python 3

2019-08-20 Thread GitBox
cclauss commented on issue #436: Use print() function in both Python 2 and Python 3 URL: https://github.com/apache/hadoop/pull/436#issuecomment-523190386 DO ACTUAL HUMANS WORK ON THIS PROJECT?? THE BOT DOES NOT SEEM TO UNDERSTAND THAT FIXING A SYNTAX ERROR IS A GOOD THING!!!

[GitHub] [hadoop] hadoop-yetus commented on issue #71: fix NullPointerException in Balancer

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #71: fix NullPointerException in Balancer URL: https://github.com/apache/hadoop/pull/71#issuecomment-523190158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315896339 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/ha

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315896339 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/ha

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315896339 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/ha

[GitHub] [hadoop] hadoop-yetus commented on issue #64: NNStorage does not synchronize iteration on a synchronized list

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #64: NNStorage does not synchronize iteration on a synchronized list URL: https://github.com/apache/hadoop/pull/64#issuecomment-523186490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] howardyoo commented on issue #341: HADOOP-15231. Metrics sink for Wavefront.

2019-08-20 Thread GitBox
howardyoo commented on issue #341: HADOOP-15231. Metrics sink for Wavefront. URL: https://github.com/apache/hadoop/pull/341#issuecomment-523186814 I am seeing the test result with -1 set on javac, and even though I don't see any compile errors, I do see the following: https://builds.apa

[jira] [Commented] (HADOOP-13477) Hadoop metrics can be only sent to the first ganglia gmond server

2019-08-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911716#comment-16911716 ] Hadoop QA commented on HADOOP-13477: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Updated] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

2019-08-20 Thread CR Hota (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CR Hota updated HADOOP-16268: - Attachment: HADOOP-16268.002.patch > Allow custom wrapped exception to be thrown by server if RPC call

[GitHub] [hadoop] hadoop-yetus commented on issue #436: Use print() function in both Python 2 and Python 3

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #436: Use print() function in both Python 2 and Python 3 URL: https://github.com/apache/hadoop/pull/436#issuecomment-523185235 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[jira] [Resolved] (HADOOP-16523) Minor spell mistake in comment (PR#388)

2019-08-20 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-16523. -- Fix Version/s: 3.3.0 Resolution: Fixed > Minor spell mistake in comment (PR#38

[jira] [Created] (HADOOP-16523) Minor spell mistake in comment (PR#388)

2019-08-20 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-16523: Summary: Minor spell mistake in comment (PR#388) Key: HADOOP-16523 URL: https://issues.apache.org/jira/browse/HADOOP-16523 Project: Hadoop Common Iss

[GitHub] [hadoop] jojochuang commented on issue #388: Minor spell mistake in comment : Line number 101

2019-08-20 Thread GitBox
jojochuang commented on issue #388: Minor spell mistake in comment : Line number 101 URL: https://github.com/apache/hadoop/pull/388#issuecomment-523184170 +1 Please file a jira next time, following Hadoops How to Contribute wiki. I filed a jira for you this time. HADOOP-16523 ---

[GitHub] [hadoop] jojochuang merged pull request #388: Minor spell mistake in comment : Line number 101

2019-08-20 Thread GitBox
jojochuang merged pull request #388: Minor spell mistake in comment : Line number 101 URL: https://github.com/apache/hadoop/pull/388 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315886059 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315886059 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#discussion_r315883423 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/

[GitHub] [hadoop] hadoop-yetus commented on issue #33: Showing the path is empty message in ls command

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #33: Showing the path is empty message in ls command URL: https://github.com/apache/hadoop/pull/33#issuecomment-523170978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hadoop] hadoop-yetus commented on issue #159: HDFS-11111. Delete items in .Trash using rm should be forbidden witho…

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #159: HDFS-1. Delete items in .Trash using rm should be forbidden witho… URL: https://github.com/apache/hadoop/pull/159#issuecomment-523169032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hadoop] hadoop-yetus commented on issue #295: Fix checkstyle problem

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #295: Fix checkstyle problem URL: https://github.com/apache/hadoop/pull/295#issuecomment-523166942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 8

[GitHub] [hadoop] hadoop-yetus commented on issue #375: HDFS-13513. Avoid edge case where BUFFER_SIZE is 0

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #375: HDFS-13513. Avoid edge case where BUFFER_SIZE is 0 URL: https://github.com/apache/hadoop/pull/375#issuecomment-523166833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] hadoop-yetus commented on issue #388: Minor spell mistake in comment : Line number 101

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #388: Minor spell mistake in comment : Line number 101 URL: https://github.com/apache/hadoop/pull/388#issuecomment-523165748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hadoop] hadoop-yetus commented on issue #297: Fix Checkstyle error, rename a argument

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #297: Fix Checkstyle error, rename a argument URL: https://github.com/apache/hadoop/pull/297#issuecomment-523164218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[jira] [Commented] (HADOOP-11823) Checking for Verifier in RPC Denied Reply

2019-08-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911684#comment-16911684 ] Hadoop QA commented on HADOOP-11823: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #1: MAPREDUCE-6096.SummarizedJob Class Improvment

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #1: MAPREDUCE-6096.SummarizedJob Class Improvment URL: https://github.com/apache/hadoop/pull/1#issuecomment-523161948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #106: HADOOP-11823: dont check for verifier in RpcDeniedReply

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #106: HADOOP-11823: dont check for verifier in RpcDeniedReply URL: https://github.com/apache/hadoop/pull/106#issuecomment-523161724 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] hadoop-yetus commented on issue #376: HDFS-13514. Avoid edge case where BUFFER_SIZE is 0

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #376: HDFS-13514. Avoid edge case where BUFFER_SIZE is 0 URL: https://github.com/apache/hadoop/pull/376#issuecomment-523161696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] hadoop-yetus commented on issue #277: add check compressor's byte size when finish compress

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #277: add check compressor's byte size when finish compress URL: https://github.com/apache/hadoop/pull/277#issuecomment-523161330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] hadoop-yetus commented on issue #16: Adjust exception output to offer additional information

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #16: Adjust exception output to offer additional information URL: https://github.com/apache/hadoop/pull/16#issuecomment-523160294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] hadoop-yetus commented on issue #4: Update TaskInputOutputContext.java javadoc

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #4: Update TaskInputOutputContext.java javadoc URL: https://github.com/apache/hadoop/pull/4#issuecomment-523160345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #63: Fix a typo

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #63: Fix a typo URL: https://github.com/apache/hadoop/pull/63#issuecomment-523159560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mod

[GitHub] [hadoop] hadoop-yetus commented on issue #60: Add space after jobId in line 1011

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #60: Add space after jobId in line 1011 URL: https://github.com/apache/hadoop/pull/60#issuecomment-523156831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] hadoop-yetus commented on issue #341: HADOOP-15231. Metrics sink for Wavefront.

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #341: HADOOP-15231. Metrics sink for Wavefront. URL: https://github.com/apache/hadoop/pull/341#issuecomment-523156922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #350: Fix FileSystem.listStatus javadoc

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #350: Fix FileSystem.listStatus javadoc URL: https://github.com/apache/hadoop/pull/350#issuecomment-523154955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] hadoop-yetus commented on issue #340: HADOOP-15230. fixes GraphiteSink to support point tags in correct format.

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #340: HADOOP-15230. fixes GraphiteSink to support point tags in correct format. URL: https://github.com/apache/hadoop/pull/340#issuecomment-523152705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] hadoop-yetus commented on issue #406: HDFS-13775. Add a conf property to retry dns reverse lookups during datanode registration.

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #406: HDFS-13775. Add a conf property to retry dns reverse lookups during datanode registration. URL: https://github.com/apache/hadoop/pull/406#issuecomment-523153049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comm

[GitHub] [hadoop] hadoop-yetus commented on issue #453: check the buffer size

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #453: check the buffer size URL: https://github.com/apache/hadoop/pull/453#issuecomment-523151648 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38

[GitHub] [hadoop] hadoop-yetus commented on issue #285: MAPREDUCE-6752: Bad logging practices in mapreduce

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #285: MAPREDUCE-6752: Bad logging practices in mapreduce URL: https://github.com/apache/hadoop/pull/285#issuecomment-523148727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r315848058 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] hadoop-yetus commented on issue #454: Fixing bug : https://issues.apache.org/jira/browse/MAPREDUCE-7089

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #454: Fixing bug : https://issues.apache.org/jira/browse/MAPREDUCE-7089 URL: https://github.com/apache/hadoop/pull/454#issuecomment-523146390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #309: MAPREDUCE-7017:Too many times of meaningless invocation in TaskAttemptImpl#resolveHosts

2019-08-20 Thread GitBox
hadoop-yetus commented on a change in pull request #309: MAPREDUCE-7017:Too many times of meaningless invocation in TaskAttemptImpl#resolveHosts URL: https://github.com/apache/hadoop/pull/309#discussion_r315846922 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoo

[GitHub] [hadoop] hadoop-yetus commented on issue #309: MAPREDUCE-7017:Too many times of meaningless invocation in TaskAttemptImpl#resolveHosts

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #309: MAPREDUCE-7017:Too many times of meaningless invocation in TaskAttemptImpl#resolveHosts URL: https://github.com/apache/hadoop/pull/309#issuecomment-523145737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] hadoop-yetus commented on issue #69: Creating updated branch for Hadoop-6671

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #69: Creating updated branch for Hadoop-6671 URL: https://github.com/apache/hadoop/pull/69#issuecomment-523143652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on issue #296: Fix constants variable name

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #296: Fix constants variable name URL: https://github.com/apache/hadoop/pull/296#issuecomment-523142319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexe

[GitHub] [hadoop] hadoop-yetus commented on issue #77: Branched to archive the Avro RPC work. On trunk Avro RPC is removed a…

2019-08-20 Thread GitBox
hadoop-yetus commented on issue #77: Branched to archive the Avro RPC work. On trunk Avro RPC is removed a… URL: https://github.com/apache/hadoop/pull/77#issuecomment-523141030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|

  1   2   3   >