[GitHub] [hadoop] adoroszlai commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
adoroszlai commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316512198 ## File path: hadoop-hdds/docs/content/interface/S3.md ## @@ -116,7 +116,7 @@ aws s3api --endpoi

[GitHub] [hadoop] bshashikant commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
bshashikant commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#issuecomment-523760729 Thanks @ehiggs for working on this. The patch overall looks good to me with few minor comments . The test failure estWe

[GitHub] [hadoop] bshashikant edited a comment on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
bshashikant edited a comment on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#issuecomment-523760729 Thanks @ehiggs for working on this. The patch overall looks good to me with few minor comments . The test failur

[GitHub] [hadoop] bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#discussion_r316506315 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/nam

[GitHub] [hadoop] lokeshj1703 commented on issue #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-21 Thread GitBox
lokeshj1703 commented on issue #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#issuecomment-523759252 @elek Thanks for updating the PR! The changes look good to me. There is acceptance test failure which I am not able to c

[GitHub] [hadoop] bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#discussion_r316505447 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/pro

[GitHub] [hadoop] bshashikant commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state

2019-08-21 Thread GitBox
bshashikant commented on issue #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state URL: https://github.com/apache/hadoop/pull/1319#issuecomment-523756239 Thanks @lokeshj1703 for working on this. I think running explicit compaction before close

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-21 Thread GitBox
lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#discussion_r316503317 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyManag

[jira] [Commented] (HADOOP-16061) Update Apache Yetus to 0.10.0

2019-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912989#comment-16912989 ] Hudson commented on HADOOP-16061: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] bshashikant commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai…

2019-08-21 Thread GitBox
bshashikant commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai… URL: https://github.com/apache/hadoop/pull/1328#issuecomment-523755123 Thanks @pingsutw for working on this. The test while asserting the exception type to be of type IOException al

[GitHub] [hadoop] tasanuma commented on issue #1320: HDFS-14755. [Dynamometer] Hadoop-2 DataNode fail to start

2019-08-21 Thread GitBox
tasanuma commented on issue #1320: HDFS-14755. [Dynamometer] Hadoop-2 DataNode fail to start URL: https://github.com/apache/hadoop/pull/1320#issuecomment-523754821 Thanks for your explanation, @xkrogen. I see. I'm not sure why my job worked, but it should be one directory there. So

[GitHub] [hadoop] avijayanhwx commented on issue #1333: HDDS-2008 : Wrong package for RatisHelper class in hadoop-hdds/common…

2019-08-21 Thread GitBox
avijayanhwx commented on issue #1333: HDDS-2008 : Wrong package for RatisHelper class in hadoop-hdds/common… URL: https://github.com/apache/hadoop/pull/1333#issuecomment-523753156 /label ozone This is an automated message fro

[GitHub] [hadoop] avijayanhwx opened a new pull request #1333: HDDS-2008 : Wrong package for RatisHelper class in hadoop-hdds/common…

2019-08-21 Thread GitBox
avijayanhwx opened a new pull request #1333: HDDS-2008 : Wrong package for RatisHelper class in hadoop-hdds/common… URL: https://github.com/apache/hadoop/pull/1333 … module. It is currently org.apache.ratis.RatisHelper. It should be org.apache.hadoop.hdds.ratis.RatisHelper. -

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316494881 ## File path: hadoop-ozone/tools/src/main/java/org/

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316493928 ## File path: hadoop-hdds/container-service/src/mai

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316493799 ## File path: hadoop-hdds/container-service/src/mai

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316493799 ## File path: hadoop-hdds/container-service/src/mai

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316493701 ## File path: hadoop-hdds/container-service/src/mai

[GitHub] [hadoop] arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1323: HDDS-1094. Performance test infrastructure : skip writing user data on Datanode. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1323#discussion_r316493551 ## File path: hadoop-hdds/container-service/src/mai

[jira] [Created] (HADOOP-16527) Add a whitelist of endpoints to allow simple authentication even if security is enabled

2019-08-21 Thread Akira Ajisaka (Jira)
Akira Ajisaka created HADOOP-16527: -- Summary: Add a whitelist of endpoints to allow simple authentication even if security is enabled Key: HADOOP-16527 URL: https://issues.apache.org/jira/browse/HADOOP-16527

[jira] [Resolved] (HADOOP-16061) Update Apache Yetus to 0.10.0

2019-08-21 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-16061. Fix Version/s: 3.1.3 3.2.1 3.3.0 Resolution:

[GitHub] [hadoop] aajisaka commented on issue #1298: HADOOP-16061. Upgrade Yetus to 0.10.0

2019-08-21 Thread GitBox
aajisaka commented on issue #1298: HADOOP-16061. Upgrade Yetus to 0.10.0 URL: https://github.com/apache/hadoop/pull/1298#issuecomment-523738639 Committed. Thank you, @steveloughran This is an automated message from the Apache

[GitHub] [hadoop] aajisaka closed pull request #1298: HADOOP-16061. Upgrade Yetus to 0.10.0

2019-08-21 Thread GitBox
aajisaka closed pull request #1298: HADOOP-16061. Upgrade Yetus to 0.10.0 URL: https://github.com/apache/hadoop/pull/1298 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Updated] (HADOOP-16448) Connection to Hadoop homepage is not secure

2019-08-21 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16448: --- Resolution: Fixed Status: Resolved (was: Patch Available) Fixed by https://github.

[GitHub] [hadoop] arp7 commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#discussion_r316474797 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA

[jira] [Commented] (HADOOP-16485) Remove dependency on jackson

2019-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912860#comment-16912860 ] Duo Zhang commented on HADOOP-16485: OK, sometimes in the past we upgraded the jack

[jira] [Commented] (HADOOP-16494) Add SHA-256 or SHA-512 checksum to release artifacts to comply with the release distribution policy

2019-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912858#comment-16912858 ] Hudson commented on HADOOP-16494: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[jira] [Updated] (HADOOP-16494) Add SHA-256 or SHA-512 checksum to release artifacts to comply with the release distribution policy

2019-08-21 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16494: --- Fix Version/s: 3.1.3 2.9.3 3.2.1 2.

[GitHub] [hadoop] aajisaka closed pull request #1243: HADOOP-16494. Add SHA-512 checksum to release artifact to comply with the release distribution policy

2019-08-21 Thread GitBox
aajisaka closed pull request #1243: HADOOP-16494. Add SHA-512 checksum to release artifact to comply with the release distribution policy URL: https://github.com/apache/hadoop/pull/1243 This is an automated message from the

[GitHub] [hadoop] aajisaka commented on issue #1243: HADOOP-16494. Add SHA-512 checksum to release artifact to comply with the release distribution policy

2019-08-21 Thread GitBox
aajisaka commented on issue #1243: HADOOP-16494. Add SHA-512 checksum to release artifact to comply with the release distribution policy URL: https://github.com/apache/hadoop/pull/1243#issuecomment-523715860 Thanks @ctubbsii and @steveloughran for reviewing this. Committed. ---

[jira] [Created] (HADOOP-16526) Support LDAP authenticaition (bind) via GSSAPI

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16526: Summary: Support LDAP authenticaition (bind) via GSSAPI Key: HADOOP-16526 URL: https://issues.apache.org/jira/browse/HADOOP-16526 Project: Hadoop Common Issu

[GitHub] [hadoop] anuengineer commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-21 Thread GitBox
anuengineer commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523691615 Committed to trunk. Thanks for the reviews and Contribution. -

[GitHub] [hadoop] anuengineer closed pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-21 Thread GitBox
anuengineer closed pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263 This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop] anuengineer commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-21 Thread GitBox
anuengineer commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523684615 +1, I have verified the test failures and at a high level does not seem to be related to this patch. I am goi

[GitHub] [hadoop] anuengineer commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient

2019-08-21 Thread GitBox
anuengineer commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient URL: https://github.com/apache/hadoop/pull/1329#issuecomment-523683749 There are some minor issues, otherwise, it looks quite good. 1. Unit test failure looks connected to this patch. ```

[jira] [Commented] (HADOOP-16517) Allow optional mutual TLS in HttpServer2

2019-08-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912758#comment-16912758 ] Hadoop QA commented on HADOOP-16517: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#issuecomment-523675019 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912735#comment-16912735 ] Todd Lipcon commented on HADOOP-16525: -- Worth noting that this case isn't handled

[GitHub] [hadoop] hanishakoneru commented on issue #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts.

2019-08-21 Thread GitBox
hanishakoneru commented on issue #1130: HDDS-1827. Load Snapshot info when OM Ratis server starts. URL: https://github.com/apache/hadoop/pull/1130#issuecomment-523669837 /retest This is an automated message from the Apache Gi

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912726#comment-16912726 ] Todd Lipcon commented on HADOOP-16525: -- One potential wrinkle in this patch: do we

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912723#comment-16912723 ] Todd Lipcon commented on HADOOP-16525: -- Attached a preliminary patch here -- missi

[jira] [Updated] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HADOOP-16525: - Attachment: hadoop-16525.txt > LDAP group mapping should include primary posix group >

[jira] [Created] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16525: Summary: LDAP group mapping should include primary posix group Key: HADOOP-16525 URL: https://issues.apache.org/jira/browse/HADOOP-16525 Project: Hadoop Common

[jira] [Commented] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912710#comment-16912710 ] Wei-Chiu Chuang commented on HADOOP-16524: -- Should it retry immediately upon a

[GitHub] [hadoop] hadoop-yetus commented on issue #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#issuecomment-523656816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Commented] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912685#comment-16912685 ] Hadoop QA commented on HADOOP-16524: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390671 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/Ozone

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390872 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/reque

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316397152 ## File path: hadoop-hdds/docs/content/security/SecurityAcls.md ## @@ -63,23 +63,20 @@ volume and

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390872 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/reque

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390872 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/reque

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390872 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/reque

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316390840 ## File path: hadoop-hdds/docs/content/security/SecuringTDE.md ## @@ -22,20 +22,19 @@ icon: lock

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316390671 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/Ozone

[GitHub] [hadoop] hadoop-yetus commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-523637550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316387503 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/secu

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316385562 ## File path: hadoop-hdds/docs/content/recipe/SparkOzoneFSK8S.md ## @@ -64,18 +64,22 @@ Create a

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316384457 ## File path: hadoop-hdds/docs/content/interface/S3.md ## @@ -116,7 +116,7 @@ aws s3api --endpoin

[GitHub] [hadoop] arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
arp7 commented on a change in pull request #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#discussion_r316384114 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.ja

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#discussion_r316383515 ## File path: hadoop-hdds/docs/content/interface/S3.md ## @@ -93,7 +93,7 @@ If security is not en

[GitHub] [hadoop] hadoop-yetus commented on issue #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331#issuecomment-523625247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hadoop] anuengineer closed pull request #1180: HDDS-1871. Remove anti-affinity rules from k8s minkube example

2019-08-21 Thread GitBox
anuengineer closed pull request #1180: HDDS-1871. Remove anti-affinity rules from k8s minkube example URL: https://github.com/apache/hadoop/pull/1180 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523611418 Thanks @bharatviswa504 for review/commit. -

[GitHub] [hadoop] bharatviswa504 merged pull request #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
bharatviswa504 merged pull request #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327 This is an automated message from the Apache Git Servic

[GitHub] [hadoop] adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523606639 @elek @vivekratnavel breaking the dependency is fine, but can we please get rid of the acceptance test

[jira] [Updated] (HADOOP-16438) Introduce a config to control SSL Channel mode in Azure DataLake Store Gen1

2019-08-21 Thread Sneha Vijayarajan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sneha Vijayarajan updated HADOOP-16438: --- Attachment: HADOOP-16438.001.patch > Introduce a config to control SSL Channel mode

[GitHub] [hadoop] bharatviswa504 merged pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-21 Thread GitBox
bharatviswa504 merged pull request #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316 This is an automated message from the Apache Git S

[GitHub] [hadoop] bharatviswa504 commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-21 Thread GitBox
bharatviswa504 commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#issuecomment-523604746 Test failures are not related to this patch. Thank You @arp7 and @xiaoyuyao for the review.

[GitHub] [hadoop] bharatviswa504 commented on issue #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM.

2019-08-21 Thread GitBox
bharatviswa504 commented on issue #670: HDDS-1347. In OM HA getS3Secret call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/670#issuecomment-523603281 Rebased this. It is ready for review. This is an

[jira] [Comment Edited] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912590#comment-16912590 ] Kihwal Lee edited comment on HADOOP-16524 at 8/21/19 6:37 PM: ---

[jira] [Commented] (HADOOP-16445) Allow separate custom signing algorithms for S3 and DDB

2019-08-21 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912592#comment-16912592 ] Siddharth Seth commented on HADOOP-16445: - Have posted a PR. On the STS questi

[jira] [Commented] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912590#comment-16912590 ] Kihwal Lee commented on HADOOP-16524: - This does not cover DataNode, since its fron

[jira] [Updated] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16524: Assignee: Kihwal Lee Status: Patch Available (was: Open) > Automatic keystore reloading fo

[jira] [Updated] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16524: Description: Jetty 9 simplified reloading of keystore.   This allows hadoop daemon's SSL cert to

[jira] [Updated] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16524: Attachment: HADOOP-16524.patch > Automatic keystore reloading for HttpServer2 > -

[GitHub] [hadoop] sidseth opened a new pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-08-21 Thread GitBox
sidseth opened a new pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332 This is very similar to the original patch. In terms of testing - have run tests against a bucket in us-east-1 (including with t

[GitHub] [hadoop] vivekratnavel commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
vivekratnavel commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523591186 I agree with @elek. We should have a copy of all the static dependencies inside HDDS and not depend

[jira] [Created] (HADOOP-16524) Automatic keystore reloading for HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
Kihwal Lee created HADOOP-16524: --- Summary: Automatic keystore reloading for HttpServer2 Key: HADOOP-16524 URL: https://issues.apache.org/jira/browse/HADOOP-16524 Project: Hadoop Common Issue Ty

[jira] [Commented] (HADOOP-16517) Allow optional mutual TLS in HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912585#comment-16912585 ] Kihwal Lee commented on HADOOP-16517: - Added a support for YARN. Tested on a small

[jira] [Updated] (HADOOP-16517) Allow optional mutual TLS in HttpServer2

2019-08-21 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16517: Attachment: HADOOP-16517.1.patch > Allow optional mutual TLS in HttpServer2 > ---

[GitHub] [hadoop] adoroszlai commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai…

2019-08-21 Thread GitBox
adoroszlai commented on issue #1328: HDDS-1998. TestSecureContainerServer#testClientServerRatisGrpc is fai… URL: https://github.com/apache/hadoop/pull/1328#issuecomment-523584365 /label ozone This is an automated message from

[GitHub] [hadoop] nandakumar131 opened a new pull request #1331: HDDS-2002. Update documentation for 0.4.1 release.

2019-08-21 Thread GitBox
nandakumar131 opened a new pull request #1331: HDDS-2002. Update documentation for 0.4.1 release. URL: https://github.com/apache/hadoop/pull/1331 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hadoop] elek edited a comment on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
elek edited a comment on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523559049 HDDS-2000 is also related but I would like to remove the dependencies between HDFS and HDDS web pages.

[GitHub] [hadoop] elek commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
elek commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523559049 HDDS-2000 is also related but I would like to remove the dependencies between HDFS and HDDS web pages. -

[GitHub] [hadoop] adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
adoroszlai commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523557696 @vivekratnavel @elek please review Thi

[GitHub] [hadoop] xkrogen commented on issue #1320: HDFS-14755. [Dynamometer] Hadoop-2 DataNode fail to start

2019-08-21 Thread GitBox
xkrogen commented on issue #1320: HDFS-14755. [Dynamometer] Hadoop-2 DataNode fail to start URL: https://github.com/apache/hadoop/pull/1320#issuecomment-523549105 Can you explain why it works? This is the code `MiniDFSCluster` uses to parse it (within `GenericTestUtils`): ``` publi

[GitHub] [hadoop] xiaoyuyao commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-21 Thread GitBox
xiaoyuyao commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#issuecomment-523547291 +1 from me as well. Seems the CI is broken pending fix from HDDS-1999/2000. -

[jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

2019-08-21 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912498#comment-16912498 ] Erik Krogen commented on HADOOP-16268: -- Great [~crh]! Thanks for the new changes.

[GitHub] [hadoop] bharatviswa504 commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer.

2019-08-21 Thread GitBox
bharatviswa504 commented on issue #1316: HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1316#issuecomment-523542524 @xiaoyuyao Can I proceed with commit?

[GitHub] [hadoop] bharatviswa504 commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-21 Thread GitBox
bharatviswa504 commented on issue #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#issuecomment-523541572 +1. Once can you verify test results? For acceptance, it is opening in GitHub, so not able to verify the

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri…

2019-08-21 Thread GitBox
xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… URL: https://github.com/apache/hadoop/pull/1263#discussion_r316275771 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmK

[GitHub] [hadoop] XBaith commented on issue #1325: Fix a typo in TextInputFormat.java

2019-08-21 Thread GitBox
XBaith commented on issue #1325: Fix a typo in TextInputFormat.java URL: https://github.com/apache/hadoop/pull/1325#issuecomment-523523575 Very thankful.I didn't find the right way until you told me. 下次我会注意的,谢谢 This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1327: HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade URL: https://github.com/apache/hadoop/pull/1327#issuecomment-523514702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] hadoop-yetus commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#issuecomment-523513326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] viczsaurav commented on a change in pull request #1280: HADOOP-16505. Add ability to register custom signer with AWS SignerFactory

2019-08-21 Thread GitBox
viczsaurav commented on a change in pull request #1280: HADOOP-16505. Add ability to register custom signer with AWS SignerFactory URL: https://github.com/apache/hadoop/pull/1280#discussion_r316255348 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/Test

[GitHub] [hadoop] elek commented on issue #1310: HDDS-1978. Create helper script to run blockade tests.

2019-08-21 Thread GitBox
elek commented on issue #1310: HDDS-1978. Create helper script to run blockade tests. URL: https://github.com/apache/hadoop/pull/1310#issuecomment-523496415 Looks good to me. Let me test it with starting the blockade test on the CI server.

[GitHub] [hadoop] hadoop-yetus commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

2019-08-21 Thread GitBox
hadoop-yetus commented on issue #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#issuecomment-523493279 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] elek opened a new pull request #1330: HDDS-2000. Don't depend on bootstrap/jquery versions from hadoop-trunk snapshot

2019-08-21 Thread GitBox
elek opened a new pull request #1330: HDDS-2000. Don't depend on bootstrap/jquery versions from hadoop-trunk snapshot URL: https://github.com/apache/hadoop/pull/1330 The OM/SCM web pages are broken due to the upgrade in HDFS-14729 (which is a great patch on the Hadoop side). To have more s

[GitHub] [hadoop] supratimdeka commented on a change in pull request #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state

2019-08-21 Thread GitBox
supratimdeka commented on a change in pull request #1319: HDDS-1981: Datanode should sync db when container is moved to CLOSED or QUASI_CLOSED state URL: https://github.com/apache/hadoop/pull/1319#discussion_r316139740 ## File path: hadoop-hdds/container-service/src/main/java/org/a

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1318: HDDS-1753. Datanode unable to find chunk while replication data using ratis.

2019-08-21 Thread GitBox
lokeshj1703 commented on a change in pull request #1318: HDDS-1753. Datanode unable to find chunk while replication data using ratis. URL: https://github.com/apache/hadoop/pull/1318#discussion_r316175405 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/oz

  1   2   >