[GitHub] [hadoop] adoroszlai commented on issue #1357: HDDS-2042. Avoid log on console with Ozone shell

2019-08-30 Thread GitBox
adoroszlai commented on issue #1357: HDDS-2042. Avoid log on console with Ozone shell URL: https://github.com/apache/hadoop/pull/1357#issuecomment-526802057 Thanks @anuengineer for committing it. This is an automated message

[GitHub] [hadoop] adoroszlai commented on issue #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky

2019-08-30 Thread GitBox
adoroszlai commented on issue #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky URL: https://github.com/apache/hadoop/pull/1378#issuecomment-526801933 Thanks @anuengineer for reviewing and committing it. This is an

[GitHub] [hadoop] adoroszlai commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields

2019-08-30 Thread GitBox
adoroszlai commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields URL: https://github.com/apache/hadoop/pull/1382#issuecomment-526801811 Thanks @bharatviswa504 for reviewing and committing it.

[GitHub] [hadoop] adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526801717 Thanks @bharatviswa504 for committing it. This is an

[jira] [Commented] (HADOOP-16255) ChecksumFS.Make FileSystem.rename(path, path, options) doesn't rename checksum

2019-08-30 Thread Jungtaek Lim (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920017#comment-16920017 ] Jungtaek Lim commented on HADOOP-16255: --- [https://github.com/apache/hadoop/pull/1388] >

[GitHub] [hadoop] HeartSaVioR opened a new pull request #1388: HADOOP-16225. Add ChecksumFs.rename(path, path, boolean) to rename crc file as well when FileContext.rename(path, path, options) is calle

2019-08-30 Thread GitBox
HeartSaVioR opened a new pull request #1388: HADOOP-16225. Add ChecksumFs.rename(path, path, boolean) to rename crc file as well when FileContext.rename(path, path, options) is called. URL: https://github.com/apache/hadoop/pull/1388 Please refer

[GitHub] [hadoop] HeartSaVioR commented on issue #1388: HADOOP-16225. Add ChecksumFs.rename(path, path, boolean) to rename crc file as well when FileContext.rename(path, path, options) is called.

2019-08-30 Thread GitBox
HeartSaVioR commented on issue #1388: HADOOP-16225. Add ChecksumFs.rename(path, path, boolean) to rename crc file as well when FileContext.rename(path, path, options) is called. URL: https://github.com/apache/hadoop/pull/1388#issuecomment-526798609 cc. @steveloughran to ask for reviewing.

[GitHub] [hadoop] anuengineer commented on issue #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky

2019-08-30 Thread GitBox
anuengineer commented on issue #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky URL: https://github.com/apache/hadoop/pull/1378#issuecomment-526788398 Thank you for your contribution. I have committed this patch to the trunk.

[GitHub] [hadoop] anuengineer closed pull request #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky

2019-08-30 Thread GitBox
anuengineer closed pull request #1378: HDDS-1413. TestCloseContainerCommandHandler is flaky URL: https://github.com/apache/hadoop/pull/1378 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-16255) ChecksumFS.Make FileSystem.rename(path, path, options) doesn't rename checksum

2019-08-30 Thread Jungtaek Lim (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919986#comment-16919986 ] Jungtaek Lim commented on HADOOP-16255: --- Ah OK. Good to know that 2.7.x is EOL. Spark 3.0 is

[GitHub] [hadoop] anuengineer commented on issue #1357: HDDS-2042. Avoid log on console with Ozone shell

2019-08-30 Thread GitBox
anuengineer commented on issue #1357: HDDS-2042. Avoid log on console with Ozone shell URL: https://github.com/apache/hadoop/pull/1357#issuecomment-526785922 Thank you for your contribution. I have committed this to the trunk branch. @bharatviswa504 Thanks for the review.

[GitHub] [hadoop] anuengineer closed pull request #1357: HDDS-2042. Avoid log on console with Ozone shell

2019-08-30 Thread GitBox
anuengineer closed pull request #1357: HDDS-2042. Avoid log on console with Ozone shell URL: https://github.com/apache/hadoop/pull/1357 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-16276) Fix jsvc startup command in hadoop-functions.sh due to jsvc >= 1.0.11 changed default current working directory

2019-08-30 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919980#comment-16919980 ] Hadoop QA commented on HADOOP-16276: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16276) Fix jsvc startup command in hadoop-functions.sh due to jsvc >= 1.0.11 changed default current working directory

2019-08-30 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919979#comment-16919979 ] Wei-Chiu Chuang commented on HADOOP-16276: -- +1 > Fix jsvc startup command in

[GitHub] [hadoop] hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526780015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1387: HDDS-2065. Implement OMNodeDetails#toString

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1387: HDDS-2065. Implement OMNodeDetails#toString URL: https://github.com/apache/hadoop/pull/1387#discussion_r319696118 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMNodeDetails.java

[GitHub] [hadoop] smengcl commented on issue #1387: HDDS-2065. Implement OMNodeDetails#toString

2019-08-30 Thread GitBox
smengcl commented on issue #1387: HDDS-2065. Implement OMNodeDetails#toString URL: https://github.com/apache/hadoop/pull/1387#issuecomment-526773258 /label ozone This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] smengcl opened a new pull request #1387: HDDS-2065. Implement OMNodeDetails#toString

2019-08-30 Thread GitBox
smengcl opened a new pull request #1387: HDDS-2065. Implement OMNodeDetails#toString URL: https://github.com/apache/hadoop/pull/1387 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] dineshchitlangia opened a new pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-08-30 Thread GitBox
dineshchitlangia opened a new pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386 This is an automated message from the Apache Git

[GitHub] [hadoop] dineshchitlangia commented on issue #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-08-30 Thread GitBox
dineshchitlangia commented on issue #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#issuecomment-526765073 /label ozone This is an automated

[GitHub] [hadoop] bharatviswa504 removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-525076456 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526763716 Fixed s3 test failure. This is an automated message from the

[GitHub] [hadoop] bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526763732 /retest This is an automated message from the Apache Git Service.

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526762273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526762273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 merged pull request #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields

2019-08-30 Thread GitBox
bharatviswa504 merged pull request #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields URL: https://github.com/apache/hadoop/pull/1382 This is an automated message from the

[GitHub] [hadoop] bharatviswa504 merged pull request #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
bharatviswa504 merged pull request #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] bharatviswa504 edited a comment on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
bharatviswa504 edited a comment on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526719128 Thank You @adoroszlai for the fix. It really helps, as after running tests, this file will be created, and

[GitHub] [hadoop] bharatviswa504 commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526719128 Thank You @adoroszlai for the fix. It really helps, as after running tests, this file will be created, and to

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526117907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526717831 /retest This is an automated message from the Apache Git Service.

[GitHub] [hadoop] bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526717734 Thank You @arp7 for the review. I have addressed the review comments.

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319645182 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319645128 ## File path:

[GitHub] [hadoop] hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber

2019-08-30 Thread GitBox
hgadre commented on a change in pull request #1154: [HDDS-1200] Add support for checksum verification in data scrubber URL: https://github.com/apache/hadoop/pull/1154#discussion_r319630085 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319619840 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields URL: https://github.com/apache/hadoop/pull/1382#issuecomment-526698745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
hadoop-yetus removed a comment on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#issuecomment-526006541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319619784 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319620266 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319620120 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319619784 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319619840 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319616825 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319616882 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319614977 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319615261 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319615012 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319615012 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319615012 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319614505 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319614660 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319614212 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319614439 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319613353 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319613602 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319613652 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319613270 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319612984 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319612132 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319611648 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319611525 ## File path:

[GitHub] [hadoop] dineshchitlangia commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
dineshchitlangia commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526686400 Confirmed. Integration test failures are unrelated to the patch 

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319611132 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319611068 ## File path:

[GitHub] [hadoop] dineshchitlangia commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR

2019-08-30 Thread GitBox
dineshchitlangia commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR URL: https://github.com/apache/hadoop/pull/1362#issuecomment-526685722 Thank you @bharatviswa504 and @anuengineer This is an automated

[GitHub] [hadoop] nandakumar131 commented on issue #1376: HDDS-2058. Remove hadoop dependencies in ozone build.

2019-08-30 Thread GitBox
nandakumar131 commented on issue #1376: HDDS-2058. Remove hadoop dependencies in ozone build. URL: https://github.com/apache/hadoop/pull/1376#issuecomment-526684960 @elek Thanks for the review and commit. This is an

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319607737 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319607368 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319606440 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319605560 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-08-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#discussion_r319605573 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319605357 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java ##

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319605162 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java ##

[GitHub] [hadoop] arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-08-30 Thread GitBox
arp7 commented on a change in pull request #1225: HDDS-1909. Use new HA code for Non-HA in OM. URL: https://github.com/apache/hadoop/pull/1225#discussion_r319605037 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java

[GitHub] [hadoop] hadoop-yetus commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526676831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR

2019-08-30 Thread GitBox
anuengineer commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR URL: https://github.com/apache/hadoop/pull/1362#issuecomment-526676344 @bharatviswa504 Thanks for the reviews. @dineshchitlangia Thank you for the contribution. I have committed this to the trunk.

[GitHub] [hadoop] hadoop-yetus commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected URL: https://github.com/apache/hadoop/pull/1375#issuecomment-526674394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] bharatviswa504 merged pull request #1362: HDDS-2014. Create Symmetric Key for GDPR

2019-08-30 Thread GitBox
bharatviswa504 merged pull request #1362: HDDS-2014. Create Symmetric Key for GDPR URL: https://github.com/apache/hadoop/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] bharatviswa504 commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR

2019-08-30 Thread GitBox
bharatviswa504 commented on issue #1362: HDDS-2014. Create Symmetric Key for GDPR URL: https://github.com/apache/hadoop/pull/1362#issuecomment-526673622 Thank You @dineshchitlangia for the contribution. I have committed this to the trunk.

[GitHub] [hadoop] adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526670554 Thanks for the review @dineshchitlangia. Integration test failures are unrelated (one of them is being fixed in

[GitHub] [hadoop] xiaoyuyao merged pull request #1379: HDDS-2047. Datanodes fail to come up after 10 retries in a secure env…

2019-08-30 Thread GitBox
xiaoyuyao merged pull request #1379: HDDS-2047. Datanodes fail to come up after 10 retries in a secure env… URL: https://github.com/apache/hadoop/pull/1379 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1377: HDDS-2057. Incorrect Default OM Port in Ozone FS URI Error Message. Contributed by Supratim Deka

2019-08-30 Thread GitBox
bharatviswa504 commented on a change in pull request #1377: HDDS-2057. Incorrect Default OM Port in Ozone FS URI Error Message. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/1377#discussion_r319579030 ## File path:

[GitHub] [hadoop] anuengineer commented on issue #1385: HDDS-2060. Create Ozone specific LICENSE file for the Ozone source package

2019-08-30 Thread GitBox
anuengineer commented on issue #1385: HDDS-2060. Create Ozone specific LICENSE file for the Ozone source package URL: https://github.com/apache/hadoop/pull/1385#issuecomment-526652770 Rat issues? This is an automated

[GitHub] [hadoop] hadoop-yetus commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#issuecomment-526647601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#issuecomment-526633786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] elek opened a new pull request #1385: HDDS-2060. Create Ozone specific LICENSE file for the Ozone source package

2019-08-30 Thread GitBox
elek opened a new pull request #1385: HDDS-2060. Create Ozone specific LICENSE file for the Ozone source package URL: https://github.com/apache/hadoop/pull/1385 With HDDS-2058 the Ozone (source) release package doesn't contains the hadoop sources any more. We need to create an adjusted

[GitHub] [hadoop] hadoop-yetus commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields

2019-08-30 Thread GitBox
hadoop-yetus commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata as exception to TestOzoneConfigurationFields URL: https://github.com/apache/hadoop/pull/1382#issuecomment-526619113 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hadoop] dineshchitlangia commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
dineshchitlangia commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526613939 @adoroszlai Thanks for filing the jira and posting a patch. +1 LGTM (pending CI)

[jira] [Comment Edited] (HADOOP-16540) Pluggable Filesystem Caching Support in FileSystem Class

2019-08-30 Thread Arun Ravi M V (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919525#comment-16919525 ] Arun Ravi M V edited comment on HADOOP-16540 at 8/30/19 1:14 PM: - Yes,

[jira] [Comment Edited] (HADOOP-16540) Pluggable Filesystem Caching Support in FileSystem Class

2019-08-30 Thread Arun Ravi M V (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919525#comment-16919525 ] Arun Ravi M V edited comment on HADOOP-16540 at 8/30/19 1:11 PM: - Yes,

[jira] [Commented] (HADOOP-16540) Pluggable Filesystem Caching Support in FileSystem Class

2019-08-30 Thread Arun Ravi M V (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919525#comment-16919525 ] Arun Ravi M V commented on HADOOP-16540: Yes, you are right, the main reason for this ticket is

[GitHub] [hadoop] adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
adoroszlai commented on issue #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384#issuecomment-526586734 /label ozone This is an automated message from the

[GitHub] [hadoop] adoroszlai opened a new pull request #1384: HDDS-2063. Integration tests create untracked file audit.log

2019-08-30 Thread GitBox
adoroszlai opened a new pull request #1384: HDDS-2063. Integration tests create untracked file audit.log URL: https://github.com/apache/hadoop/pull/1384 ## What changes were proposed in this pull request? `audit.log` is only tested by `TestOzoneRpcClientForAclAuditLog`, but its

[jira] [Commented] (HADOOP-16540) Pluggable Filesystem Caching Support in FileSystem Class

2019-08-30 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919497#comment-16919497 ] Steve Loughran commented on HADOOP-16540: - * its (user, prefix, auth) not just prefix and auth,

[jira] [Updated] (HADOOP-16540) Pluggable Filesystem Caching Support in FileSystem Class

2019-08-30 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16540: Affects Version/s: 3.3.0 > Pluggable Filesystem Caching Support in FileSystem Class >

[GitHub] [hadoop] wilderchen commented on issue #404: HDFS-13771. Fix enableManagedDfsDirsRedundancy typo in creating MiniDFSCluster

2019-08-30 Thread GitBox
wilderchen commented on issue #404: HDFS-13771. Fix enableManagedDfsDirsRedundancy typo in creating MiniDFSCluster URL: https://github.com/apache/hadoop/pull/404#issuecomment-526574334 Seems all tests haven been passed. This

[GitHub] [hadoop] echohlne opened a new pull request #1383: If finishTime is 0, 'NA' should be displayed at this time, indicating that the task is not finished yet

2019-08-30 Thread GitBox
echohlne opened a new pull request #1383: If finishTime is 0, 'NA' should be displayed at this time, indicating that the task is not finished yet URL: https://github.com/apache/hadoop/pull/1383 When a app is running, the finishTime returned by the server is always 0, so the Finished time

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1348: HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts

2019-08-30 Thread GitBox
adoroszlai commented on a change in pull request #1348: HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts URL: https://github.com/apache/hadoop/pull/1348#discussion_r319459002 ## File path: hadoop-ozone/dev-support/checks/_mvn_unit_report.sh ##

[GitHub] [hadoop] adoroszlai commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata to ozone-default.xml

2019-08-30 Thread GitBox
adoroszlai commented on issue #1382: HDDS-2061. Add hdds.container.chunk.persistdata to ozone-default.xml URL: https://github.com/apache/hadoop/pull/1382#issuecomment-526550898 @supratimdeka please review This is an

  1   2   >