[jira] [Updated] (HADOOP-16553) ipc.client.connect.max.retries.on.timeouts default value is too many

2019-09-19 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lisheng Sun updated HADOOP-16553: - Attachment: HADOOP-16553.002.patch > ipc.client.connect.max.retries.on.timeouts default value i

[jira] [Updated] (HADOOP-16585) [Tool:NNloadGeneratorMR] Multiple threads are using same id for creating file LoadGenerator#write

2019-09-19 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranith Sardar updated HADOOP-16585: --- Attachment: HADOOP-16585.001.patch > [Tool:NNloadGeneratorMR] Multiple threads are using s

[jira] [Updated] (HADOOP-16585) [Tool:NNloadGeneratorMR] Multiple threads are using same id for creating file LoadGenerator#write

2019-09-19 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranith Sardar updated HADOOP-16585: --- Status: Patch Available (was: Open) > [Tool:NNloadGeneratorMR] Multiple threads are using

[jira] [Commented] (HADOOP-16553) ipc.client.connect.max.retries.on.timeouts default value is too many

2019-09-19 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933111#comment-16933111 ] Lisheng Sun commented on HADOOP-16553: -- hi [~elgoiri], [~ayushtkn] [~xkrogen] [~jo

[GitHub] [hadoop] vivekratnavel opened a new pull request #1473: HDDS-2101. Ozone filesystem provider doesn't exist

2019-09-19 Thread GitBox
vivekratnavel opened a new pull request #1473: HDDS-2101. Ozone filesystem provider doesn't exist URL: https://github.com/apache/hadoop/pull/1473 Ozone did not have a filesystem provider in META-INF and this PR adds a filesystem provider for both ozonefs-lib-legacy and ozonefs-lib-current.

[GitHub] [hadoop] vivekratnavel commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist

2019-09-19 Thread GitBox
vivekratnavel commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist URL: https://github.com/apache/hadoop/pull/1473#issuecomment-533002998 @elek @anuengineer Please review This is an automated message f

[GitHub] [hadoop] vivekratnavel commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist

2019-09-19 Thread GitBox
vivekratnavel commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist URL: https://github.com/apache/hadoop/pull/1473#issuecomment-533002895 /label ozone This is an automated message from the Apache G

[GitHub] [hadoop] elek closed pull request #1464: HDDS-730. Ozone fs cli prints hadoop fs in usage.

2019-09-19 Thread GitBox
elek closed pull request #1464: HDDS-730. Ozone fs cli prints hadoop fs in usage. URL: https://github.com/apache/hadoop/pull/1464 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [hadoop] elek commented on issue #1464: HDDS-730. Ozone fs cli prints hadoop fs in usage.

2019-09-19 Thread GitBox
elek commented on issue #1464: HDDS-730. Ozone fs cli prints hadoop fs in usage. URL: https://github.com/apache/hadoop/pull/1464#issuecomment-533005884 Merged. Thanks @cxorm the contribution. This is an automated message from

[GitHub] [hadoop] ChenSammi commented on issue #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology

2019-09-19 Thread GitBox
ChenSammi commented on issue #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology URL: https://github.com/apache/hadoop/pull/1194#issuecomment-533012656 Thanks @xiaoyuyao for the code review and @elek for monitor the build result. --

[GitHub] [hadoop] hadoop-yetus commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist URL: https://github.com/apache/hadoop/pull/1473#issuecomment-533018777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[GitHub] [hadoop] sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533021249 Tested against us-east-2 and ap-south-1 (-Ds3guard -Ddynamo -Dauth). There's a standard set of test failures with a

[GitHub] [hadoop] bshashikant opened a new pull request #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader.

2019-09-19 Thread GitBox
bshashikant opened a new pull request #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader. URL: https://github.com/apache/hadoop/pull/1474 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull

[jira] [Commented] (HADOOP-16585) [Tool:NNloadGeneratorMR] Multiple threads are using same id for creating file LoadGenerator#write

2019-09-19 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933165#comment-16933165 ] Ranith Sardar commented on HADOOP-16585: Attached the initial patch. > [Tool:

[GitHub] [hadoop] elek closed pull request #1470: HDDS-2147. Include dumpstream in test report

2019-09-19 Thread GitBox
elek closed pull request #1470: HDDS-2147. Include dumpstream in test report URL: https://github.com/apache/hadoop/pull/1470 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [hadoop] adoroszlai commented on issue #1470: HDDS-2147. Include dumpstream in test report

2019-09-19 Thread GitBox
adoroszlai commented on issue #1470: HDDS-2147. Include dumpstream in test report URL: https://github.com/apache/hadoop/pull/1470#issuecomment-533032996 Thanks @elek for reviewing and merging it. This is an automated message

[GitHub] [hadoop] elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation.

2019-09-19 Thread GitBox
elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-533041700 Currently all the checkstyle checks are showing false negative answers. I will commit t

[GitHub] [hadoop] elek edited a comment on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation.

2019-09-19 Thread GitBox
elek edited a comment on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-533041700 Currently all the checkstyle checks are showing false negative answers. I will c

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1472: HDDS-2150. Update dependency versions to avoid security vulnerabilities.

2019-09-19 Thread GitBox
adoroszlai commented on a change in pull request #1472: HDDS-2150. Update dependency versions to avoid security vulnerabilities. URL: https://github.com/apache/hadoop/pull/1472#discussion_r326073658 ## File path: pom.ozone.xml ## @@ -127,6 +127,9 @@ xsi:schemaLocation="htt

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-19 Thread GitBox
mukund-thakur commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#discussion_r326082051 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/Test

[jira] [Commented] (HADOOP-16553) ipc.client.connect.max.retries.on.timeouts default value is too many

2019-09-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933220#comment-16933220 ] Hadoop QA commented on HADOOP-16553: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] elek closed pull request #1458: HDDS-2016. Add option to enforce gdpr in Bucket Create command.

2019-09-19 Thread GitBox
elek closed pull request #1458: HDDS-2016. Add option to enforce gdpr in Bucket Create command. URL: https://github.com/apache/hadoop/pull/1458 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] hadoop-yetus commented on issue #1277: HDDS-1054. List Multipart uploads in a bucket

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1277: HDDS-1054. List Multipart uploads in a bucket URL: https://github.com/apache/hadoop/pull/1277#issuecomment-533058852 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-19 Thread GitBox
mukund-thakur commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#discussion_r326090915 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/Test

[GitHub] [hadoop] elek closed pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation.

2019-09-19 Thread GitBox
elek closed pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435 This is an automated message from the Apach

[GitHub] [hadoop] hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-533063582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hadoop] elek opened a new pull request #1475: HDDS-2154. Fix Checkstyle issues

2019-09-19 Thread GitBox
elek opened a new pull request #1475: HDDS-2154. Fix Checkstyle issues URL: https://github.com/apache/hadoop/pull/1475 Unfortunately checkstyle checks didn't work well from HDDS-2106 to HDDS-2119. This patch fixes all the issues which are accidentally merged in the mean time.

[GitHub] [hadoop] hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#issuecomment-533064098 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HADOOP-16585) [Tool:NNloadGeneratorMR] Multiple threads are using same id for creating file LoadGenerator#write

2019-09-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933249#comment-16933249 ] Hadoop QA commented on HADOOP-16585: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] elek closed pull request #1471: HDDS-2148. Remove redundant code in CreateBucketHandler.java

2019-09-19 Thread GitBox
elek closed pull request #1471: HDDS-2148. Remove redundant code in CreateBucketHandler.java URL: https://github.com/apache/hadoop/pull/1471 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933265#comment-16933265 ] Steve Loughran commented on HADOOP-16587: - this relate to HADOOP-16498? > Make

[GitHub] [hadoop] lokeshj1703 commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader.

2019-09-19 Thread GitBox
lokeshj1703 commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader. URL: https://github.com/apache/hadoop/pull/1474#issuecomment-533074738 @bshashikant Thanks for working on this! The changes look good to me. +1. Pending jenkins. ---

[jira] [Commented] (HADOOP-16586) ITestS3GuardFsck, others fails when nun using a local metastore

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933267#comment-16933267 ] Steve Loughran commented on HADOOP-16586: - * ITestS3GuardFsck looks like an ext

[jira] [Commented] (HADOOP-16577) Build fails as can't retrieve websocket-servlet

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933268#comment-16933268 ] Steve Loughran commented on HADOOP-16577: - * let me rm that file from my cache

[GitHub] [hadoop] timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-19 Thread GitBox
timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-533075841 /retest This is an automated message from the Apac

[GitHub] [hadoop] hadoop-yetus commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader.

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader. URL: https://github.com/apache/hadoop/pull/1474#issuecomment-533080522 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] hadoop-yetus commented on issue #1475: HDDS-2154. Fix Checkstyle issues

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1475: HDDS-2154. Fix Checkstyle issues URL: https://github.com/apache/hadoop/pull/1475#issuecomment-533091052 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[GitHub] [hadoop] steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533094205 last two are intermittent and we should have a go at fixing (longer timeouts, more retries). other on

[jira] [Commented] (HADOOP-16577) Build fails as can't retrieve websocket-servlet

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933304#comment-16933304 ] Steve Loughran commented on HADOOP-16577: - I deleted the file and did a rerun a

[jira] [Updated] (HADOOP-16577) Build fails as can't retrieve websocket-servlet

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16577: Attachment: websocket-server-9.3.27.v20190418.jar > Build fails as can't retrieve websock

[jira] [Updated] (HADOOP-16577) Build fails as can't retrieve websocket-servlet

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16577: Attachment: (was: websocket-server-9.3.27.v20190418.jar) > Build fails as can't retri

[jira] [Commented] (HADOOP-16577) Build fails as can't retrieve websocket-servlet

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933307#comment-16933307 ] Steve Loughran commented on HADOOP-16577: - your maven client should be skipping

[GitHub] [hadoop] hadoop-yetus commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-533096789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] elek commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-19 Thread GitBox
elek commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#issuecomment-533099312 LGTM If I understood well everybody agreed with this approach and AFAIK all of the comments are addres

[GitHub] [hadoop] elek commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-19 Thread GitBox
elek commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#issuecomment-533099643 @sodonnel Can you please rebase and push (some of the integration tests are fixed on trunk, we can double che

[GitHub] [hadoop] elek closed pull request #1462: HDDS-2141. Missing total number of operations

2019-09-19 Thread GitBox
elek closed pull request #1462: HDDS-2141. Missing total number of operations URL: https://github.com/apache/hadoop/pull/1462 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] adoroszlai commented on issue #1462: HDDS-2141. Missing total number of operations

2019-09-19 Thread GitBox
adoroszlai commented on issue #1462: HDDS-2141. Missing total number of operations URL: https://github.com/apache/hadoop/pull/1462#issuecomment-533102961 Thanks @elek for reviewing and merging it. This is an automated message

[jira] [Commented] (HADOOP-16570) S3A committers leak threads/raises OOM on job/task commit at scale

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933323#comment-16933323 ] Steve Loughran commented on HADOOP-16570: - h2. Plan h3. now: * listPendingUp

[jira] [Assigned] (HADOOP-16544) update io.netty in branch-2

2019-09-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki reassigned HADOOP-16544: - Assignee: Masatake Iwasaki > update io.netty in branch-2 > ---

[GitHub] [hadoop] hadoop-yetus commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader.

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1474: HDDS-2153. Add a config to tune max pending requests in Ratis leader. URL: https://github.com/apache/hadoop/pull/1474#issuecomment-53311 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] elek opened a new pull request #1476: HDDS-2127. Detailed Tools doc not reachable

2019-09-19 Thread GitBox
elek opened a new pull request #1476: HDDS-2127. Detailed Tools doc not reachable URL: https://github.com/apache/hadoop/pull/1476 There are two doc pages for tools: * docs/beyond/tools.html * docs/tools.html The latter is more detailed (has subpages for several tools), but it

[jira] [Updated] (HADOOP-16544) update io.netty in branch-2

2019-09-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-16544: -- Attachment: HADOOP-16544-branch-2.001.patch > update io.netty in branch-2 > -

[jira] [Commented] (HADOOP-16544) update io.netty in branch-2

2019-09-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933347#comment-16933347 ] Masatake Iwasaki commented on HADOOP-16544: --- I'm attaching the patch which is

[jira] [Updated] (HADOOP-16544) update io.netty in branch-2

2019-09-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-16544: -- Status: Patch Available (was: Open) > update io.netty in branch-2 >

[GitHub] [hadoop] hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-533121382 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hadoop] adoroszlai opened a new pull request #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level

2019-09-19 Thread GitBox
adoroszlai opened a new pull request #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level URL: https://github.com/apache/hadoop/pull/1477 ## What changes were proposed in this pull request? Remove byte data from container command request before logging it (a

[GitHub] [hadoop] adoroszlai commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level

2019-09-19 Thread GitBox
adoroszlai commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level URL: https://github.com/apache/hadoop/pull/1477#issuecomment-533122964 /label ozone This is an automated message from

[jira] [Updated] (HADOOP-16582) LocalFileSystem's mkdirs() does not work as expected under viewfs.

2019-09-19 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16582: Fix Version/s: 3.2.2 3.1.3 2.9.3 2.8.6

[jira] [Updated] (HADOOP-16582) LocalFileSystem's mkdirs() does not work as expected under viewfs.

2019-09-19 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kihwal Lee updated HADOOP-16582: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [hadoop] hadoop-yetus commented on issue #1476: HDDS-2127. Detailed Tools doc not reachable

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1476: HDDS-2127. Detailed Tools doc not reachable URL: https://github.com/apache/hadoop/pull/1476#issuecomment-533136748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hadoop] dineshchitlangia commented on issue #1471: HDDS-2148. Remove redundant code in CreateBucketHandler.java

2019-09-19 Thread GitBox
dineshchitlangia commented on issue #1471: HDDS-2148. Remove redundant code in CreateBucketHandler.java URL: https://github.com/apache/hadoop/pull/1471#issuecomment-533138999 Thanks @elek & @adoroszlai for reviewing, @elek for committing. --

[GitHub] [hadoop] dineshchitlangia commented on issue #1475: HDDS-2154. Fix Checkstyle issues

2019-09-19 Thread GitBox
dineshchitlangia commented on issue #1475: HDDS-2154. Fix Checkstyle issues URL: https://github.com/apache/hadoop/pull/1475#issuecomment-533140298 +1 (non-binding) , thanks for filing the patch This is an automated message fro

[GitHub] [hadoop] dineshchitlangia commented on issue #1458: HDDS-2016. Add option to enforce gdpr in Bucket Create command.

2019-09-19 Thread GitBox
dineshchitlangia commented on issue #1458: HDDS-2016. Add option to enforce gdpr in Bucket Create command. URL: https://github.com/apache/hadoop/pull/1458#issuecomment-533142150 @elek thanks for review and commit. Yes, HDDS-2140 will address the test needs. Regarding the placement of

[jira] [Commented] (HADOOP-16582) LocalFileSystem's mkdirs() does not work as expected under viewfs.

2019-09-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933405#comment-16933405 ] Hudson commented on HADOOP-16582: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] adoroszlai commented on issue #1365: HDDS-1949. Missing or error-prone test cleanup

2019-09-19 Thread GitBox
adoroszlai commented on issue #1365: HDDS-1949. Missing or error-prone test cleanup URL: https://github.com/apache/hadoop/pull/1365#issuecomment-533148984 Thanks @arp7 for the review. Conflict is now resolved. This is an aut

[GitHub] [hadoop] Cosss7 commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-19 Thread GitBox
Cosss7 commented on a change in pull request #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#discussion_r326208650 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyMap

[GitHub] [hadoop] steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533158590 tests all went well for me This is an automa

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326209693 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Signer

[GitHub] [hadoop] hadoop-yetus commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level URL: https://github.com/apache/hadoop/pull/1477#issuecomment-533160601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] hadoop-yetus commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#issuecomment-533162016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533162661 I think you've managed to get stuff into the latest commit which weren't there earlier (SignerManager). Was t

[jira] [Commented] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933451#comment-16933451 ] Steve Loughran commented on HADOOP-16579: - what are the transitive dependency c

[GitHub] [hadoop] steveloughran commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions

2019-09-19 Thread GitBox
steveloughran commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions URL: https://github.com/apache/hadoop/pull/1467#issuecomment-533165186 -1 All the options you have documented are set by specific profiles you can enable with -Ds3guard, -Dscale etc. But:

[GitHub] [hadoop] steveloughran commented on issue #1450: MAPREDUCE-7234. Fixed typo in isSplitable methods

2019-09-19 Thread GitBox
steveloughran commented on issue #1450: MAPREDUCE-7234. Fixed typo in isSplitable methods URL: https://github.com/apache/hadoop/pull/1450#issuecomment-533167830 -1, with the reason being "yes, we agree its wrong, but its out in the wild and we are trapped" FileInputFormat is tagged

[GitHub] [hadoop] steveloughran commented on a change in pull request #1428: HADOOP-16556. Fix some alerts raised by LGTM

2019-09-19 Thread GitBox
steveloughran commented on a change in pull request #1428: HADOOP-16556. Fix some alerts raised by LGTM URL: https://github.com/apache/hadoop/pull/1428#discussion_r326220436 ## File path: hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util

[GitHub] [hadoop] HorizonNet commented on issue #1450: MAPREDUCE-7234. Fixed typo in isSplitable methods

2019-09-19 Thread GitBox
HorizonNet commented on issue #1450: MAPREDUCE-7234. Fixed typo in isSplitable methods URL: https://github.com/apache/hadoop/pull/1450#issuecomment-533169163 @steveloughran Totally understand it. How about closing this PR, as well as the underlying Jira ticket? ---

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE

2019-09-19 Thread GitBox
hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE URL: https://github.com/apache/hadoop/pull/1302#issuecomment-527944423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE

2019-09-19 Thread GitBox
hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE URL: https://github.com/apache/hadoop/pull/1302#issuecomment-521656984 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] dineshchitlangia commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level

2019-09-19 Thread GitBox
dineshchitlangia commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level URL: https://github.com/apache/hadoop/pull/1477#issuecomment-533171126 @adoroszlai thanks for filing the patch. Overall +1 (non-binding), pending Jenkins. However, I do see che

[GitHub] [hadoop] steveloughran commented on issue #1428: HADOOP-16556. Fix some alerts raised by LGTM

2019-09-19 Thread GitBox
steveloughran commented on issue #1428: HADOOP-16556. Fix some alerts raised by LGTM URL: https://github.com/apache/hadoop/pull/1428#issuecomment-533172330 +1, merged into trunk. Thanks! This is an automated message from the

[jira] [Updated] (HADOOP-16556) Fix some LGTM alerts

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16556: Affects Version/s: 3.3.0 > Fix some LGTM alerts > > >

[jira] [Updated] (HADOOP-16556) Fix some LGTM alerts

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16556: Component/s: common > Fix some LGTM alerts > > > Key

[jira] [Updated] (HADOOP-16556) Fix some LGTM alerts

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16556: Priority: Minor (was: Major) > Fix some LGTM alerts > > >

[jira] [Resolved] (HADOOP-16556) Fix some LGTM alerts

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16556. - Fix Version/s: 3.3.0 Assignee: Malcolm Taylor Resolution: Fixed > Fix s

[jira] [Commented] (HADOOP-16570) S3A committers leak threads/raises OOM on job/task commit at scale

2019-09-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933487#comment-16933487 ] Steve Loughran commented on HADOOP-16570: - note: one other aspect of the issue

[GitHub] [hadoop] steveloughran commented on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE

2019-09-19 Thread GitBox
steveloughran commented on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE URL: https://github.com/apache/hadoop/pull/1302#issuecomment-533180196 LGTM, some minor typos and style +1 pending those changes looking at the mkdir() code, i can

[GitHub] [hadoop] bgaborg commented on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE

2019-09-19 Thread GitBox
bgaborg commented on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE URL: https://github.com/apache/hadoop/pull/1302#issuecomment-533181106 > looking at the mkdir() code, i can see that it raises a PathIOE on failure without any text. Do you think we s

[GitHub] [hadoop] sidseth commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
sidseth commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326241845 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/SignerManage

[GitHub] [hadoop] sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-19 Thread GitBox
sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533187731 The change the latest commit (SignerManager) removes the code from S3AUtils and moves it to a SignerManager class (

[jira] [Commented] (HADOOP-16581) ValueQueue does not trigger an async refill when number of values falls below watermark

2019-09-19 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933525#comment-16933525 ] Erik Krogen commented on HADOOP-16581: -- Got a clean Jenkins run. +1 from me, will

[GitHub] [hadoop] hadoop-yetus commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level

2019-09-19 Thread GitBox
hadoop-yetus commented on issue #1477: HDDS-2151. Ozone client logs the entire request payload at DEBUG level URL: https://github.com/apache/hadoop/pull/1477#issuecomment-533194489 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HADOOP-16544) update io.netty in branch-2

2019-09-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933533#comment-16933533 ] Hadoop QA commented on HADOOP-16544: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] anuengineer commented on issue #1463: HADOOP-16581. Revise ValueQueue to correctly replenish queues that go…

2019-09-19 Thread GitBox
anuengineer commented on issue #1463: HADOOP-16581. Revise ValueQueue to correctly replenish queues that go… URL: https://github.com/apache/hadoop/pull/1463#issuecomment-533203392 +1. Changes look good to me. Thanks for pinging me. @xkrogen.

[GitHub] [hadoop] anuengineer commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-19 Thread GitBox
anuengineer commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#issuecomment-533205315 > @anuengineer @nandakumar131 please let us now if you have any further comments. > > I am plan

[GitHub] [hadoop] anuengineer closed pull request #1448: HDDS-2110. Arbitrary file can be downloaded with the help of ProfilerServlet

2019-09-19 Thread GitBox
anuengineer closed pull request #1448: HDDS-2110. Arbitrary file can be downloaded with the help of ProfilerServlet URL: https://github.com/apache/hadoop/pull/1448 This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-16556) Fix some LGTM alerts

2019-09-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933577#comment-16933577 ] Hudson commented on HADOOP-16556: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] anuengineer commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist

2019-09-19 Thread GitBox
anuengineer commented on issue #1473: HDDS-2101. Ozone filesystem provider doesn't exist URL: https://github.com/apache/hadoop/pull/1473#issuecomment-533215665 Changes look good to me. Once @elek comments are addressed, I think we will be able to commit this. Thanks for getting this done.

[GitHub] [hadoop] anuengineer closed pull request #1476: HDDS-2127. Detailed Tools doc not reachable

2019-09-19 Thread GitBox
anuengineer closed pull request #1476: HDDS-2127. Detailed Tools doc not reachable URL: https://github.com/apache/hadoop/pull/1476 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] anuengineer commented on issue #1476: HDDS-2127. Detailed Tools doc not reachable

2019-09-19 Thread GitBox
anuengineer commented on issue #1476: HDDS-2127. Detailed Tools doc not reachable URL: https://github.com/apache/hadoop/pull/1476#issuecomment-533218797 +1. I have committed this patch to the trunk. Thank you for the contribution. ---

[GitHub] [hadoop] xiaoyuyao commented on issue #1369: HDDS-2020. Remove mTLS from Ozone GRPC. Contributed by Xiaoyu Yao.

2019-09-19 Thread GitBox
xiaoyuyao commented on issue #1369: HDDS-2020. Remove mTLS from Ozone GRPC. Contributed by Xiaoyu Yao. URL: https://github.com/apache/hadoop/pull/1369#issuecomment-533220964 Test the two failed unit tests locally and they don't repro. --

  1   2   >