[jira] [Commented] (HADOOP-16512) [hadoop-tools] Fix order of actual and expected expression in assert statements

2019-10-06 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945630#comment-16945630 ] Akira Ajisaka commented on HADOOP-16512: LGTM, +1 > [hadoop-tools] Fix order o

[jira] [Commented] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-10-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945629#comment-16945629 ] Hadoop QA commented on HADOOP-16587: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows

2019-10-06 Thread GitBox
hadoop-yetus commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#issuecomment-538861597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |

[GitHub] [hadoop] bshashikant closed pull request #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-06 Thread GitBox
bshashikant closed pull request #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517 This is an automated message from the Apache Git Service. To res

[GitHub] [hadoop] bshashikant commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis

2019-10-06 Thread GitBox
bshashikant commented on issue #1517: HDDS-2169. Avoid buffer copies while submitting client requests in Ratis URL: https://github.com/apache/hadoop/pull/1517#issuecomment-538832263 Thanks @szetszwo for working on this. I have added the relavent change below as well while submitting the c

[GitHub] [hadoop] bshashikant commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used

2019-10-06 Thread GitBox
bshashikant commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used URL: https://github.com/apache/hadoop/pull/1596#issuecomment-538829264 Thanks @fapifta for working on this. In addition to Mukul's comments, I feel ByteBuffer to byteS

[GitHub] [hadoop] bshashikant commented on a change in pull request #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used

2019-10-06 Thread GitBox
bshashikant commented on a change in pull request #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used URL: https://github.com/apache/hadoop/pull/1596#discussion_r331837192 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used

2019-10-06 Thread GitBox
mukul1987 commented on a change in pull request #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used URL: https://github.com/apache/hadoop/pull/1596#discussion_r331835518 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/sc

[jira] [Resolved] (HADOOP-16628) Always use current year in website.

2019-10-06 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-16628. Fix Version/s: asf-site Resolution: Fixed Merged. Thanks! > Always use current ye

[GitHub] [hadoop] hadoop-yetus commented on issue #1605: HDDS-2259. Container Data Scrubber computes wrong checksum

2019-10-06 Thread GitBox
hadoop-yetus commented on issue #1605: HDDS-2259. Container Data Scrubber computes wrong checksum URL: https://github.com/apache/hadoop/pull/1605#issuecomment-538725824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|-

[GitHub] [hadoop] adoroszlai opened a new pull request #1605: HDDS-2259. Container Data Scrubber computes wrong checksum

2019-10-06 Thread GitBox
adoroszlai opened a new pull request #1605: HDDS-2259. Container Data Scrubber computes wrong checksum URL: https://github.com/apache/hadoop/pull/1605 ## What changes were proposed in this pull request? Compute checksum in container scrubber only for the actual length of data read.

[GitHub] [hadoop] adoroszlai commented on issue #1605: HDDS-2259. Container Data Scrubber computes wrong checksum

2019-10-06 Thread GitBox
adoroszlai commented on issue #1605: HDDS-2259. Container Data Scrubber computes wrong checksum URL: https://github.com/apache/hadoop/pull/1605#issuecomment-538722906 /label ozone This is an automated message from the Apache