[jira] [Commented] (HADOOP-17011) Tolerate leading and trailing spaces in fs.defaultFS

2020-04-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093075#comment-17093075 ] Ayush Saxena commented on HADOOP-17011: --- For me {{TestSnappyCompressorDecompresso

[jira] [Created] (HADOOP-17016) Adding Common Counters in ABFS

2020-04-27 Thread Mehakmeet Singh (Jira)
Mehakmeet Singh created HADOOP-17016: Summary: Adding Common Counters in ABFS Key: HADOOP-17016 URL: https://issues.apache.org/jira/browse/HADOOP-17016 Project: Hadoop Common Issue Type:

[jira] [Commented] (HADOOP-17016) Adding Common Counters in ABFS

2020-04-27 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093124#comment-17093124 ] Mehakmeet Singh commented on HADOOP-17016: -- CC [~mukund-thakur], [~ste...@apac

[GitHub] [hadoop] yuyang733 commented on pull request #1952: HDFS-1820. FTPFileSystem attempts to close the outputstream even when it is not initialised.

2020-04-27 Thread GitBox
yuyang733 commented on pull request #1952: URL: https://github.com/apache/hadoop/pull/1952#issuecomment-619804438 > @mpryahin I will assist ChenSammi to check and fix this issue on the trunk branch as soon as possible. > > Thanks for your feedback. This issue has been solved.

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-04-27 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r415614919 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java ## @@ -481,6 +483,15 @@ public SinglePendi

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-04-27 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r415617818 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java ## @@ -384,6 +387,7 @@ public void abortMulti

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1944: HADOOP-16900. Very large files can be truncated when written through S3AFileSystem

2020-04-27 Thread GitBox
mukund-thakur commented on a change in pull request #1944: URL: https://github.com/apache/hadoop/pull/1944#discussion_r415618656 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java ## @@ -400,18 +406,22 @@ public UploadPartReq

[jira] [Created] (HADOOP-17017) S3A client retries on SSL Auth exceptions triggered by "." bucket names

2020-04-27 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-17017: --- Summary: S3A client retries on SSL Auth exceptions triggered by "." bucket names Key: HADOOP-17017 URL: https://issues.apache.org/jira/browse/HADOOP-17017 Proje

[jira] [Commented] (HADOOP-17017) S3A client retries on SSL Auth exceptions triggered by "." bucket names

2020-04-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093293#comment-17093293 ] Steve Loughran commented on HADOOP-17017: - Full Stack {code} 2020-04-27 10:54:3

[jira] [Commented] (HADOOP-17017) S3A client retries on SSL Auth exceptions triggered by "." bucket names

2020-04-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093296#comment-17093296 ] Steve Loughran commented on HADOOP-17017: - also, that debug level "retrying" me

[GitHub] [hadoop] hadoop-yetus commented on pull request #1952: HDFS-1820. FTPFileSystem attempts to close the outputstream even when it is not initialised.

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1952: URL: https://github.com/apache/hadoop/pull/1952#issuecomment-619888797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 22m 9

[GitHub] [hadoop] hadoop-yetus commented on pull request #1970: HADOOP-17004. ABFS: Improve the ABFS driver documentation

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1970: URL: https://github.com/apache/hadoop/pull/1970#issuecomment-619954961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 22m 38

[jira] [Commented] (HADOOP-17015) ABFS: Make PUT and POST operations idempotent

2020-04-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093453#comment-17093453 ] Steve Loughran commented on HADOOP-17015: - I'm going to point you at org.apache

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #1952: HDFS-1820. FTPFileSystem attempts to close the outputstream even when it is not initialised.

2020-04-27 Thread GitBox
hadoop-yetus removed a comment on pull request #1952: URL: https://github.com/apache/hadoop/pull/1952#issuecomment-616654493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #1952: HDFS-1820. FTPFileSystem attempts to close the outputstream even when it is not initialised.

2020-04-27 Thread GitBox
hadoop-yetus removed a comment on pull request #1952: URL: https://github.com/apache/hadoop/pull/1952#issuecomment-616555963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Deleted] (HADOOP-17013) this bug is bla bla bla

2020-04-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran deleted HADOOP-17013: > this bug is bla bla bla > --- > > Key: HADOOP-17013 >

[GitHub] [hadoop] belugabehr commented on a change in pull request #1974: HADOOP-17009: Embrace Immutability of Java Collections

2020-04-27 Thread GitBox
belugabehr commented on a change in pull request #1974: URL: https://github.com/apache/hadoop/pull/1974#discussion_r415831875 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java ## @@ -196,10 +196,8 @@ protected Node getNo

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
mukund-thakur commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r412295588 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/impl/DynamicIOStatistics.java ## @@ -0,0 +1,114 @@ +

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
mukund-thakur commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r412295588 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/impl/DynamicIOStatistics.java ## @@ -0,0 +1,114 @@ +

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
hadoop-yetus removed a comment on pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#issuecomment-613542774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r415857318 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/IOStatistics.java ## @@ -0,0 +1,142 @@ +/* + * Licen

[GitHub] [hadoop] steveloughran commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r415857404 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/impl/DynamicIOStatistics.java ## @@ -0,0 +1,114 @@ +

[GitHub] [hadoop] steveloughran commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r415863782 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/IOStatisticsSupport.java ## @@ -0,0 +1,37 @@ +/* + *

[GitHub] [hadoop] steveloughran commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r415894394 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/impl/DynamicIOStatisticsBuilder.java ## @@ -0,0 +1,1

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
hadoop-yetus removed a comment on pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#issuecomment-618620734 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
hadoop-yetus removed a comment on pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#issuecomment-618042975 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#discussion_r415900512 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/statistics/TestEmptyIOStatistics.java ## @@ -0,0 +1,82 @@ +/* +

[GitHub] [hadoop] steveloughran commented on pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
steveloughran commented on pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#issuecomment-620053085 @mukund-thakur thanks for the review -tried to address your comments. Look in the package-info for some docs on how I imagine these to be used. Because the code doesn

[GitHub] [hadoop] steveloughran commented on pull request #1834: HADOOP-16848. Experimental directory marker optimization.

2020-04-27 Thread GitBox
steveloughran commented on pull request #1834: URL: https://github.com/apache/hadoop/pull/1834#issuecomment-620062213 superceded by #1861 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] hadoop-yetus commented on pull request #1974: HADOOP-17009: Embrace Immutability of Java Collections

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1974: URL: https://github.com/apache/hadoop/pull/1974#issuecomment-620072129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44

[jira] [Commented] (HADOOP-17009) Embrace Immutability of Java Collections

2020-04-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093659#comment-17093659 ] Hadoop QA commented on HADOOP-17009: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-17011) Tolerate leading and trailing spaces in fs.defaultFS

2020-04-27 Thread Ctest (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093682#comment-17093682 ] Ctest commented on HADOOP-17011: [~ayushtkn] I tried to run hadoop.io.compress.TestCom

[GitHub] [hadoop] aryangupta1998 opened a new pull request #1980: HDFS-15301. statfs function in hdfs-fuse not working - fixed.

2020-04-27 Thread GitBox
aryangupta1998 opened a new pull request #1980: URL: https://github.com/apache/hadoop/pull/1980 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e

[GitHub] [hadoop] sunchao commented on a change in pull request #1977: HADOOP-17010. Add queue capacity support for FairCallQueue

2020-04-27 Thread GitBox
sunchao commented on a change in pull request #1977: URL: https://github.com/apache/hadoop/pull/1977#discussion_r416001217 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java ## @@ -101,11 +111,18 @@ public FairCallQueue(int

[GitHub] [hadoop] hadoop-yetus commented on pull request #1820: HADOOP-16830. Add public IOStatistics API + S3A implementation

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1820: URL: https://github.com/apache/hadoop/pull/1820#issuecomment-620123790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hadoop] hadoop-yetus commented on pull request #1970: HADOOP-17004. ABFS: Improve the ABFS driver documentation

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1970: URL: https://github.com/apache/hadoop/pull/1970#issuecomment-620125242 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hadoop] hadoop-yetus commented on pull request #1980: HDFS-15301. statfs function in hdfs-fuse not working - fixed.

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1980: URL: https://github.com/apache/hadoop/pull/1980#issuecomment-620147874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[GitHub] [hadoop] smengcl opened a new pull request #1981: HADOOP-17014. Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread GitBox
smengcl opened a new pull request #1981: URL: https://github.com/apache/hadoop/pull/1981 https://issues.apache.org/jira/browse/HADOOP-17014 To branch-3.2 This is an automated message from the Apache Git Service. To res

[jira] [Commented] (HADOOP-17014) Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093865#comment-17093865 ] Wei-Chiu Chuang commented on HADOOP-17014: -- I don't think jackson-databind 2.1

[GitHub] [hadoop] steveloughran commented on pull request #1898: HADOOP-16852: Report read-ahead error back

2020-04-27 Thread GitBox
steveloughran commented on pull request #1898: URL: https://github.com/apache/hadoop/pull/1898#issuecomment-620195669 things aren't building because the change made to the abfs constructor is breaking it. Sorry. That refactoring was done to try and reduce change conflict in future.

[GitHub] [hadoop] steveloughran commented on a change in pull request #1978: HDFS-15168: ABFS enhancement to translate AAD to Linux identities.

2020-04-27 Thread GitBox
steveloughran commented on a change in pull request #1978: URL: https://github.com/apache/hadoop/pull/1978#discussion_r416101568 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/IdentityTransformerInterface.java ## @@ -0,0 +1,62 @@ +/*

[jira] [Commented] (HADOOP-17014) Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093891#comment-17093891 ] Siyao Meng commented on HADOOP-17014: - [~weichiu] Agree. Patch posted: https://gith

[jira] [Updated] (HADOOP-17014) Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-17014: Description: trunk (3.3.0) now has HADOOP-16905. But branch 3.2/3.1/.. still uses jackson-databi

[jira] [Updated] (HADOOP-17014) Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-17014: Status: Patch Available (was: Open) > Upgrade jackson-databind to 2.9.10.4 > ---

[GitHub] [hadoop] hadoop-yetus commented on pull request #1981: HADOOP-17014. Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1981: URL: https://github.com/apache/hadoop/pull/1981#issuecomment-620207324 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 15m 22

[GitHub] [hadoop] jojochuang commented on pull request #1980: HDFS-15301. statfs function in hdfs-fuse not working - fixed.

2020-04-27 Thread GitBox
jojochuang commented on pull request #1980: URL: https://github.com/apache/hadoop/pull/1980#issuecomment-620207139 Thanks for the patch. It's a shame such a simple error exists. Have you verified the fix? Do you think it's possible to add a test?

[GitHub] [hadoop] smengcl commented on pull request #1981: HADOOP-17014. Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread GitBox
smengcl commented on pull request #1981: URL: https://github.com/apache/hadoop/pull/1981#issuecomment-620219392 Merged. Thanks @jojochuang for reviewing. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] steveloughran opened a new pull request #1982: HADOOP-16830. IOStatistics API.

2020-04-27 Thread GitBox
steveloughran opened a new pull request #1982: URL: https://github.com/apache/hadoop/pull/1982 Contributed by Steve Loughran. This patch adds to hadoop-common an API For querying IO classes (Especially input and output streams) for statistics. It includes a big rework of

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-04-27 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-620220105 Successor to #1820. regarding AWS metric failures, when enabled code which goes near landat and common crawl buckets are failing, even when the default endpoint is b

[jira] [Updated] (HADOOP-17014) Upgrade jackson-databind to 2.9.10.4

2020-04-27 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-17014: Fix Version/s: 3.2.2 3.1.4 Resolution: Fixed Status: Resolved

[GitHub] [hadoop] amarnathkarthik commented on a change in pull request #1978: HDFS-15168: ABFS enhancement to translate AAD to Linux identities.

2020-04-27 Thread GitBox
amarnathkarthik commented on a change in pull request #1978: URL: https://github.com/apache/hadoop/pull/1978#discussion_r416143207 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TextFileBasedIdentityHandler.java ## @@ -0,0 +1,194 @@ +

[GitHub] [hadoop] amarnathkarthik commented on a change in pull request #1978: HDFS-15168: ABFS enhancement to translate AAD to Linux identities.

2020-04-27 Thread GitBox
amarnathkarthik commented on a change in pull request #1978: URL: https://github.com/apache/hadoop/pull/1978#discussion_r416143075 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/IdentityTransformerInterface.java ## @@ -0,0 +1,62 @@ +

[GitHub] [hadoop] hadoop-yetus commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-620272003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[GitHub] [hadoop] hadoop-yetus commented on pull request #1977: HADOOP-17010. Add queue capacity support for FairCallQueue

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1977: URL: https://github.com/apache/hadoop/pull/1977#issuecomment-620277199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0

[GitHub] [hadoop] aryangupta1998 commented on pull request #1980: HDFS-15301. statfs function in hdfs-fuse not working - fixed.

2020-04-27 Thread GitBox
aryangupta1998 commented on pull request #1980: URL: https://github.com/apache/hadoop/pull/1980#issuecomment-620293931 > Thanks for the patch. It's a shame such a simple error exists. > Have you verified the fix? Do you think it's possible to add a test? Yeah I have verified the fi

[GitHub] [hadoop] hadoop-yetus commented on pull request #1978: HDFS-15168: ABFS enhancement to translate AAD to Linux identities.

2020-04-27 Thread GitBox
hadoop-yetus commented on pull request #1978: URL: https://github.com/apache/hadoop/pull/1978#issuecomment-620322634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 3

[GitHub] [hadoop] liusheng commented on pull request #1967: YARN-9898. Workaround of Netty-all dependency aarch64 support

2020-04-27 Thread GitBox
liusheng commented on pull request #1967: URL: https://github.com/apache/hadoop/pull/1967#issuecomment-620338853 hmm. I am not sure why the CI cannot be triggered, let me try to open another PR. This is an automated message

[GitHub] [hadoop] liusheng opened a new pull request #1983: YARN-9898. Workaround of Netty-all dependency aarch64 support

2020-04-27 Thread GitBox
liusheng opened a new pull request #1983: URL: https://github.com/apache/hadoop/pull/1983 The YARM CSI client now depend on the netty-all 4.1.48.Final which is lack of aarch64 support, We have tried to promote aarch64 support in Netty community, see[1], but still in review progress. Fo

[GitHub] [hadoop] liusheng commented on pull request #1983: YARN-9898. Workaround of Netty-all dependency aarch64 support

2020-04-27 Thread GitBox
liusheng commented on pull request #1983: URL: https://github.com/apache/hadoop/pull/1983#issuecomment-620346499 Not sure why the PR https://github.com/apache/hadoop/pull/1967 cannot trigger CI, so here re open an new PR. Th

[GitHub] [hadoop] amarnathkarthik commented on pull request #1978: HDFS-15168: ABFS enhancement to translate AAD to Linux identities.

2020-04-27 Thread GitBox
amarnathkarthik commented on pull request #1978: URL: https://github.com/apache/hadoop/pull/1978#issuecomment-620372020 @steveloughran Thanks on review this PR, addressed below review comments: 1. Trailing "." 2. Import ordering 3. Formatting of ternary operator 4. Changing to de

[GitHub] [hadoop] amarnathkarthik commented on pull request #1918: HADOOP-16910: ABFS Streams to update FileSystem.Statistics counters on IO.

2020-04-27 Thread GitBox
amarnathkarthik commented on pull request #1918: URL: https://github.com/apache/hadoop/pull/1918#issuecomment-620379729 @mehakmeet Integration test fails when running against ABS East US. **Command:** `mvn -T 1C -Dparallel-tests=abfs clean verify` `[INFO] Tests run: 63, Failure

[GitHub] [hadoop] iwasakims commented on a change in pull request #1950: HADOOP-16586. ITestS3GuardFsck, others fails when run using a local m…

2020-04-27 Thread GitBox
iwasakims commented on a change in pull request #1950: URL: https://github.com/apache/hadoop/pull/1950#discussion_r416331324 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java ## @@ -54,7 +54,12 @@ import static o

[GitHub] [hadoop] iwasakims commented on a change in pull request #1950: HADOOP-16586. ITestS3GuardFsck, others fails when run using a local m…

2020-04-27 Thread GitBox
iwasakims commented on a change in pull request #1950: URL: https://github.com/apache/hadoop/pull/1950#discussion_r416336379 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java ## @@ -97,7 +98,6 @@ public void testImp

[GitHub] [hadoop] iwasakims commented on a change in pull request #1950: HADOOP-16586. ITestS3GuardFsck, others fails when run using a local m…

2020-04-27 Thread GitBox
iwasakims commented on a change in pull request #1950: URL: https://github.com/apache/hadoop/pull/1950#discussion_r416341013 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java ## @@ -97,7 +98,6 @@ public void testImp

[GitHub] [hadoop] iwasakims commented on a change in pull request #1950: HADOOP-16586. ITestS3GuardFsck, others fails when run using a local m…

2020-04-27 Thread GitBox
iwasakims commented on a change in pull request #1950: URL: https://github.com/apache/hadoop/pull/1950#discussion_r416346311 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java ## @@ -165,18 +165,19 @@ public void tes

[GitHub] [hadoop] iwasakims commented on a change in pull request #1950: HADOOP-16586. ITestS3GuardFsck, others fails when run using a local m…

2020-04-27 Thread GitBox
iwasakims commented on a change in pull request #1950: URL: https://github.com/apache/hadoop/pull/1950#discussion_r416354605 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java ## @@ -165,18 +165,19 @@ public void tes