[GitHub] [hadoop] mehakmeet commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mehakmeet commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058316 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java ## @@ -34,33 +41,24 @@ public TestAbfsStatis

[GitHub] [hadoop] mehakmeet commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mehakmeet commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058232 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -133,59 +159,48 @@ public void testDe

[GitHub] [hadoop] mehakmeet commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mehakmeet commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427058041 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -32,10 +32,54 @@ public class ITestA

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427053193 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java ## @@ -23,9 +23,16 @@ import org.juni

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427053540 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsStatistics.java ## @@ -34,33 +41,24 @@ public TestAbfsSt

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052835 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -249,32 +252,44 @@ public void te

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052492 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -133,59 +159,48 @@ public void te

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052757 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -200,41 +215,29 @@ public void te

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1991: HADOOP-17016. Adding Common Counters in ABFS

2020-05-18 Thread GitBox
mukund-thakur commented on a change in pull request #1991: URL: https://github.com/apache/hadoop/pull/1991#discussion_r427051819 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java ## @@ -32,10 +32,54 @@ public class IT

[jira] [Commented] (HADOOP-17024) ListStatus on ViewFS root (ls "/") should list the linkFallBack root (configured target root).

2020-05-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110869#comment-17110869 ] Hudson commented on HADOOP-17024: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Co

[jira] [Resolved] (HADOOP-17024) ListStatus on ViewFS root (ls "/") should list the linkFallBack root (configured target root).

2020-05-18 Thread Uma Maheswara Rao G (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G resolved HADOOP-17024. -- Fix Version/s: 3.4.0 Hadoop Flags: Incompatible change,Reviewed Rele

[GitHub] [hadoop] umamaheswararao commented on pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-18 Thread GitBox
umamaheswararao commented on pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#issuecomment-630589188 Thank you @abhishekdas99 for the contribution. I have just committed this to trunk. This is an automated

[GitHub] [hadoop] umamaheswararao merged pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-18 Thread GitBox
umamaheswararao merged pull request #2010: URL: https://github.com/apache/hadoop/pull/2010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-17047) TODO comments exist in trunk while the related issues are already fixed.

2020-05-18 Thread Rungroj Maipradit (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110856#comment-17110856 ] Rungroj Maipradit commented on HADOOP-17047: Thank you. I added a patch to

[jira] [Commented] (HADOOP-17049) javax.activation-api and jakarta.activation-api define overlapping classes

2020-05-18 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110851#comment-17110851 ] Wei-Chiu Chuang commented on HADOOP-17049: -- IIRC jakarta.activation-api was in

[jira] [Created] (HADOOP-17049) javax.activation-api and jakarta.activation-api define overlapping classes

2020-05-18 Thread Akira Ajisaka (Jira)
Akira Ajisaka created HADOOP-17049: -- Summary: javax.activation-api and jakarta.activation-api define overlapping classes Key: HADOOP-17049 URL: https://issues.apache.org/jira/browse/HADOOP-17049 Proj

[jira] [Updated] (HADOOP-17047) TODO comments exist in trunk while the related issues are already fixed.

2020-05-18 Thread Rungroj Maipradit (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rungroj Maipradit updated HADOOP-17047: --- Attachment: HADOOP-17047.001.patch > TODO comments exist in trunk while the related

[GitHub] [hadoop] hadoop-yetus commented on pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#issuecomment-630571098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m 36

[jira] [Commented] (HADOOP-17004) ABFS: Improve the ABFS driver documentation

2020-05-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110831#comment-17110831 ] Hudson commented on HADOOP-17004: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] DadanielZ commented on pull request #2021: Hadoop-17015. ABFS: Handling Rename and Delete idempotency

2020-05-18 Thread GitBox
DadanielZ commented on pull request #2021: URL: https://github.com/apache/hadoop/pull/2021#issuecomment-630564371 Looks good! @snvijaya please resolve the conflicts then I will help to commit. This is an automated message fr

[jira] [Created] (HADOOP-17048) Increase number of IPC calls and lock creating contention for low latency queries

2020-05-18 Thread Ramesh Kumar Thangarajan (Jira)
Ramesh Kumar Thangarajan created HADOOP-17048: - Summary: Increase number of IPC calls and lock creating contention for low latency queries Key: HADOOP-17048 URL: https://issues.apache.org/jira/browse/H

[GitHub] [hadoop] DadanielZ merged pull request #1970: HADOOP-17004. ABFS: Improve the ABFS driver documentation

2020-05-18 Thread GitBox
DadanielZ merged pull request #1970: URL: https://github.com/apache/hadoop/pull/1970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] abhishekdas99 commented on pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-18 Thread GitBox
abhishekdas99 commented on pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#issuecomment-630551187 > Thank you @abhishekdas99 for addressing all the comments. Nice work! > +1 on latest changes and pending CI results. Thanks Thanks @umamaheswararao for your guidan

[GitHub] [hadoop] hadoop-yetus commented on pull request #2012: HADOOP-16888. [JDK11] Support JDK11 in the precommit job

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2012: URL: https://github.com/apache/hadoop/pull/2012#issuecomment-630541375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 26m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2012: HADOOP-16888. [JDK11] Support JDK11 in the precommit job

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2012: URL: https://github.com/apache/hadoop/pull/2012#issuecomment-630522815 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.

[GitHub] [hadoop] hadoop-yetus commented on pull request #2013: [DO NOT MERGE] Testing HADOOP-16888

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2013: URL: https://github.com/apache/hadoop/pull/2013#issuecomment-630522972 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.

[GitHub] [hadoop] umamaheswararao commented on pull request #2010: HADOOP-17024. ListStatus on ViewFS root should list the linkFallBack root

2020-05-18 Thread GitBox
umamaheswararao commented on pull request #2010: URL: https://github.com/apache/hadoop/pull/2010#issuecomment-630519719 Thank you @abhishekdas99 for addressing all the comments. Nice work! +1 on latest changes and pending CI results. Thanks --

[jira] [Commented] (HADOOP-17047) TODO comments exist in trunk while the related issues are already fixed.

2020-05-18 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110637#comment-17110637 ] Mingliang Liu commented on HADOOP-17047: Thanks for the findings, [~rungroj].

[GitHub] [hadoop] hadoop-yetus commented on pull request #1999: HADOOP-14566. Add seek support for SFTP FileSystem.

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #1999: URL: https://github.com/apache/hadoop/pull/1999#issuecomment-630415369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 3

[GitHub] [hadoop] steveloughran commented on pull request #1982: HADOOP-16830. IOStatistics API.

2020-05-18 Thread GitBox
steveloughran commented on pull request #1982: URL: https://github.com/apache/hadoop/pull/1982#issuecomment-630284411 This patch adds LocalFS/RawLocalFS/ChecksummedFileSystem statistics passthrough and collection. Getting everything passed through is actually the harder part of the

[GitHub] [hadoop] steveloughran closed pull request #2022: Revert "HADOOP-14557. Document HADOOP-8143 (Change distcp to have -pb on by default)."

2020-05-18 Thread GitBox
steveloughran closed pull request #2022: URL: https://github.com/apache/hadoop/pull/2022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] steveloughran commented on a change in pull request #1111: HDFS-9913 DistCp to add -useTrash to move deleted files to Trash

2020-05-18 Thread GitBox
steveloughran commented on a change in pull request #: URL: https://github.com/apache/hadoop/pull/#discussion_r426735880 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java ## @@ -355,8 +355,7 @@ prote

[GitHub] [hadoop] steveloughran closed pull request #2023: Revert "HADOOP-8143. Change distcp to have -pb on by default."

2020-05-18 Thread GitBox
steveloughran closed pull request #2023: URL: https://github.com/apache/hadoop/pull/2023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] jojochuang commented on pull request #2016: HDFS-15202 Boost short circuit cache (rebase PR-1884)

2020-05-18 Thread GitBox
jojochuang commented on pull request #2016: URL: https://github.com/apache/hadoop/pull/2016#issuecomment-630204147 No I think you're fine. You probably need to rebase the PR to use the new docker. But I'll merge this one. Th

[GitHub] [hadoop] jojochuang merged pull request #2016: HDFS-15202 Boost short circuit cache (rebase PR-1884)

2020-05-18 Thread GitBox
jojochuang merged pull request #2016: URL: https://github.com/apache/hadoop/pull/2016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop] hadoop-yetus commented on pull request #2016: HDFS-15202 Boost short circuit cache (rebase PR-1884)

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2016: URL: https://github.com/apache/hadoop/pull/2016#issuecomment-630184095 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0

[GitHub] [hadoop] hadoop-yetus commented on pull request #1999: HADOOP-14566. Add seek support for SFTP FileSystem.

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #1999: URL: https://github.com/apache/hadoop/pull/1999#issuecomment-630176761 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[jira] [Comment Edited] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2020-05-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110202#comment-17110202 ] Steve Loughran edited comment on HADOOP-13887 at 5/18/20, 12:17 PM: -

[jira] [Issue Comment Deleted] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2020-05-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-13887: Comment: was deleted (was: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsys

[jira] [Issue Comment Deleted] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2020-05-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-13887: Comment: was deleted (was: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsys

[jira] [Issue Comment Deleted] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2020-05-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-13887: Comment: was deleted (was: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsys

[jira] [Commented] (HADOOP-13887) Encrypt S3A data client-side with AWS SDK (S3-CSE)

2020-05-18 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110202#comment-17110202 ] Steve Loughran commented on HADOOP-13887: - S3 now supports unpadded CSE, so cli

[GitHub] [hadoop] hadoop-yetus commented on pull request #2012: HADOOP-16888. [JDK11] Support JDK11 in the precommit job

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2012: URL: https://github.com/apache/hadoop/pull/2012#issuecomment-630062949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 29m 1

[jira] [Commented] (HADOOP-16686) Review Writable Classes

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110063#comment-17110063 ] Hadoop QA commented on HADOOP-16686: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16692) UserGroupInformation Sets kerberosMinSecondsBeforeRelogin as Millis

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110053#comment-17110053 ] Hadoop QA commented on HADOOP-16692: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on pull request #2013: [DO NOT MERGE] Testing HADOOP-16888

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2013: URL: https://github.com/apache/hadoop/pull/2013#issuecomment-630026500 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.

[GitHub] [hadoop] hadoop-yetus commented on pull request #2012: HADOOP-16888. [JDK11] Support JDK11 in the precommit job

2020-05-18 Thread GitBox
hadoop-yetus commented on pull request #2012: URL: https://github.com/apache/hadoop/pull/2012#issuecomment-630026424 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.

[jira] [Created] (HADOOP-17047) TODO comments exist in trunk while the related issues are already fixed.

2020-05-18 Thread Rungroj Maipradit (Jira)
Rungroj Maipradit created HADOOP-17047: -- Summary: TODO comments exist in trunk while the related issues are already fixed. Key: HADOOP-17047 URL: https://issues.apache.org/jira/browse/HADOOP-17047

[GitHub] [hadoop] aajisaka commented on pull request #2013: [DO NOT MERGE] Testing HADOOP-16888

2020-05-18 Thread GitBox
aajisaka commented on pull request #2013: URL: https://github.com/apache/hadoop/pull/2013#issuecomment-630023999 The precommit job ran more than 10 hours and aborted. This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-16322) FileNotFoundException for checksum file from hadoop-maven-plugins

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110013#comment-17110013 ] Hadoop QA commented on HADOOP-16322: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16694) Use Objects requireNonNull Where Appropriate

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109951#comment-17109951 ] Hadoop QA commented on HADOOP-16694: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16693) Review InterruptedException Handling

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109950#comment-17109950 ] Hadoop QA commented on HADOOP-16693: | (x) *{color:red}-1 overall{color}* | \\ \\ |