[jira] [Updated] (HADOOP-17235) Erasure Coding: Remove dead code from common side

2020-08-31 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He updated HADOOP-17235: - Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Status:

[GitHub] [hadoop] shanemkm commented on a change in pull request #2246: Hadoop-17215. ABFS: Disable default create overwrite

2020-08-31 Thread GitBox
shanemkm commented on a change in pull request #2246: URL: https://github.com/apache/hadoop/pull/2246#discussion_r480718575 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -271,10 +272,67 @@ public

[GitHub] [hadoop] shanemkm commented on a change in pull request #2246: Hadoop-17215. ABFS: Disable default create overwrite

2020-08-31 Thread GitBox
shanemkm commented on a change in pull request #2246: URL: https://github.com/apache/hadoop/pull/2246#discussion_r480718118 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -271,10 +272,67 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
hadoop-yetus commented on pull request #2244: URL: https://github.com/apache/hadoop/pull/2244#issuecomment-684145641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] tasanuma commented on pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
tasanuma commented on pull request #2244: URL: https://github.com/apache/hadoop/pull/2244#issuecomment-684141475 Thanks for your review, @aajisaka! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] tasanuma merged pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
tasanuma merged pull request #2244: URL: https://github.com/apache/hadoop/pull/2244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] aajisaka commented on pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
aajisaka commented on pull request #2244: URL: https://github.com/apache/hadoop/pull/2244#issuecomment-684139593 +1 I'd like to change the log dir to `target/`, however, it seems that there is no available option to change the log dir via pom.xml.

[GitHub] [hadoop] tasanuma commented on pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
tasanuma commented on pull request #2244: URL: https://github.com/apache/hadoop/pull/2244#issuecomment-684133882 Rebased the latest trunk. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tasanuma commented on pull request #2244: YARN-10407. Add phantomjsdriver.log to gitignore.

2020-08-31 Thread GitBox
tasanuma commented on pull request #2244: URL: https://github.com/apache/hadoop/pull/2244#issuecomment-684132643 Thanks for your review, @jiwq. But I think I need an approve to merge it. This is an automated message from the

[jira] [Commented] (HADOOP-17169) Remove whitelist/blacklist terminology from Hadoop Common

2020-08-31 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188012#comment-17188012 ] Eric Badger commented on HADOOP-17169: -- HadoopQA + HDFS is pretty unstable it looks like. The cc

[GitHub] [hadoop] hadoop-yetus commented on pull request #2255: HDFS-15545 - Allow WebHdfsFileSystem to read a new delegation token f…

2020-08-31 Thread GitBox
hadoop-yetus commented on pull request #2255: URL: https://github.com/apache/hadoop/pull/2255#issuecomment-684042566 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] DadanielZ commented on a change in pull request #2246: Hadoop-17215. ABFS: Disable default create overwrite

2020-08-31 Thread GitBox
DadanielZ commented on a change in pull request #2246: URL: https://github.com/apache/hadoop/pull/2246#discussion_r480281889 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -271,10 +272,67 @@ public

[GitHub] [hadoop] DadanielZ commented on a change in pull request #2246: Hadoop-17215. ABFS: Disable default create overwrite

2020-08-31 Thread GitBox
DadanielZ commented on a change in pull request #2246: URL: https://github.com/apache/hadoop/pull/2246#discussion_r480281889 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -271,10 +272,67 @@ public

[GitHub] [hadoop] DadanielZ commented on pull request #2246: Hadoop-17215. ABFS: Disable default create overwrite

2020-08-31 Thread GitBox
DadanielZ commented on pull request #2246: URL: https://github.com/apache/hadoop/pull/2246#issuecomment-683922533 If the main purpose is to resolve the potential race condition, this fix seems not enough as the race condition can still happen in the retry process for the second "create

[GitHub] [hadoop] hadoop-yetus commented on pull request #2235: HDFS-15484. Add new method batchRename for DistributedFileSystem and W…

2020-08-31 Thread GitBox
hadoop-yetus commented on pull request #2235: URL: https://github.com/apache/hadoop/pull/2235#issuecomment-683852266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 28m

[jira] [Commented] (HADOOP-17235) Erasure Coding: Remove dead code from common side

2020-08-31 Thread Takanobu Asanuma (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187795#comment-17187795 ] Takanobu Asanuma commented on HADOOP-17235: --- +1. Thanks for your contribution. > Erasure

[jira] [Commented] (HADOOP-17235) Erasure Coding: Remove dead code from common side

2020-08-31 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187679#comment-17187679 ] Xiaoqiao He commented on HADOOP-17235: -- Thanks [~ferhui] for your contribution. To be honest, I

[jira] [Commented] (HADOOP-17235) Erasure Coding: Remove dead code from common side

2020-08-31 Thread Fei Hui (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187594#comment-17187594 ] Fei Hui commented on HADOOP-17235: -- [~hexiaoqiao][~weichiu][~ayushtkn] Could you please take a look?

[jira] [Commented] (HADOOP-17236) Bump up snakeyaml to 1.26 to mitigate CVE-2017-18640

2020-08-31 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187488#comment-17187488 ] Hadoop QA commented on HADOOP-17236: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-17235) Erasure Coding: Remove dead code from common side

2020-08-31 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187454#comment-17187454 ] Hadoop QA commented on HADOOP-17235: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] bshashikant commented on pull request #2258: HDFS-15539. When disallowing snapshot on a dir, throw exception if its trash root is not empty

2020-08-31 Thread GitBox
bshashikant commented on pull request #2258: URL: https://github.com/apache/hadoop/pull/2258#issuecomment-683578915 Thanks @smengcl for working on this,. The test failures like TestDistributedFileSystem#testGetTrashRoots look related. Can you plz verify?

[GitHub] [hadoop] bshashikant commented on pull request #2251: HDFS-15542. Add identified snapshot corruption tests for ordered snapshot deletion

2020-08-31 Thread GitBox
bshashikant commented on pull request #2251: URL: https://github.com/apache/hadoop/pull/2251#issuecomment-683572317 Thanks @szetszwo for the review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] bshashikant merged pull request #2251: HDFS-15542. Add identified snapshot corruption tests for ordered snapshot deletion

2020-08-31 Thread GitBox
bshashikant merged pull request #2251: URL: https://github.com/apache/hadoop/pull/2251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go