steveloughran commented on a change in pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#discussion_r565187998
##
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/FileOutputC
hadoop-yetus commented on pull request #2655:
URL: https://github.com/apache/hadoop/pull/2655#issuecomment-768192307
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565220614
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
##
@@ -45,6 +45,8 @@
import org.apache.co
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542761
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565221339
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListStatusRemoteIterator.java
##
@@ -0,0 +1,156 @@
+/*
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565221875
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListStatusRemoteIterator.java
##
@@ -0,0 +1,151 @@
+/*
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542763
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542762
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565222324
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListStatusRemoteIterator.java
##
@@ -0,0 +1,151 @@
+/*
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r56529
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListStatusRemoteIterator.java
##
@@ -0,0 +1,151 @@
+/*
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542764
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542765
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565222998
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusIterator.java
##
@@ -0,0 +1,339 @@
+/**
+ * Lice
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542767
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565223412
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsListStatusRemoteIterator.java
##
@@ -0,0 +1,151 @@
+/*
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565223843
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsListStatusIterator.java
##
@@ -0,0 +1,339 @@
+/**
+ * Lice
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542769
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542768
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
bilaharith commented on a change in pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#discussion_r565225564
##
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
##
@@ -37,6 +37,8 @@
import java.util.con
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542771
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
Sushmasree-28 commented on pull request #2645:
URL: https://github.com/apache/hadoop/pull/2645#issuecomment-768226751
@smengcl @iwasakims Thank you for the work here
I have taken your latest patch, compiled and trying to verify trace feature.
Just wanted to confirm, As per the PR, Tr
[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=542775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542775
]
ASF GitHub Bot logged work on HADOOP-17424:
---
Author: ASF GitHub B
HeartSaVioR commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768248565
Ah OK. Good to know. I didn't realize it prints two times for entrance and
exit. Will fix. Probably I'll have to go back to use `from` instead of
`from.getPath()` then.
---
smengcl commented on pull request #2645:
URL: https://github.com/apache/hadoop/pull/2645#issuecomment-768251870
> @smengcl @iwasakims Thank you for the work here
> I have taken your latest patch, compiled and trying to verify trace
feature.
> Just wanted to confirm, As per the PR, Tra
[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=542792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542792
]
ASF GitHub Bot logged work on HADOOP-17424:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#issuecomment-768268126
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=542809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542809
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
steveloughran commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768283949
Yeah, that's good. we don't build the string unless its being logged, (and
its only done at the start, not re-evaluated later), so keeping it efficient is
nice.
LGTM
hadoop-yetus commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768295570
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
Steve Loughran created HADOOP-17499:
---
Summary: AbstractContractStreamIOStatisticsTest fails if read
buffer not full
Key: HADOOP-17499
URL: https://issues.apache.org/jira/browse/HADOOP-17499
Project:
[
https://issues.apache.org/jira/browse/HADOOP-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272928#comment-17272928
]
Steve Loughran commented on HADOOP-17499:
-
{code}
[ERROR]
testInputStreamStati
steveloughran opened a new pull request #2656:
URL: https://github.com/apache/hadoop/pull/2656
* core-default.xml updated
* CommitConstants updated
* All tests which previously enabled the magic commiter now rely on
default settings. This helps make sure it is enabled.
* Docs c
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=542891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542891
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
steveloughran commented on pull request #2656:
URL: https://github.com/apache/hadoop/pull/2656#issuecomment-768368118
Tested: S3 london `-Dparallel-tests -DtestsThreadCount=6 -Dmarkers=keep`
Unbuffer test failure; also triggered a related failure in
ITestS3AContractStreamIOStatistics
steveloughran closed pull request #2637:
URL: https://github.com/apache/hadoop/pull/2637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
steveloughran commented on pull request #2637:
URL: https://github.com/apache/hadoop/pull/2637#issuecomment-768368611
Closing, superceded by #2656
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=542892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542892
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=542893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542893
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=542894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542894
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
steveloughran merged pull request #2649:
URL: https://github.com/apache/hadoop/pull/2649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/HADOOP-17493?focusedWorklogId=542915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542915
]
ASF GitHub Bot logged work on HADOOP-17493:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-17493.
-
Fix Version/s: 3.3.1
Resolution: Fixed
> renaming S3A Statistic DELEGATION_TOKEN
[
https://issues.apache.org/jira/browse/HADOOP-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-17493:
Affects Version/s: (was: 3.3.0)
3.3.1
> renaming S3A Statistic
[
https://issues.apache.org/jira/browse/HADOOP-17079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273000#comment-17273000
]
Ahmed Hussein commented on HADOOP-17079:
I suggest we approach this optimizatio
Nargeshdb commented on a change in pull request #2652:
URL: https://github.com/apache/hadoop/pull/2652#discussion_r565486885
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
##
@@ -269,14 +269,20 @@ p
steveloughran merged pull request #2656:
URL: https://github.com/apache/hadoop/pull/2656
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=543007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543007
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
steveloughran commented on pull request #2656:
URL: https://github.com/apache/hadoop/pull/2656#issuecomment-768506035
thanks. merged to 3.3+
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=543011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543011
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-17483.
-
Fix Version/s: 3.3.1
Assignee: Steve Loughran
Resolution: Fixed
> magic
steveloughran merged pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
HeartSaVioR commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768515963
Thanks for reviewing and merging!
This is an automated message from the Apache Git Service.
To respond to the
hadoop-yetus commented on pull request #2656:
URL: https://github.com/apache/hadoop/pull/2656#issuecomment-768518659
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=543022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543022
]
ASF GitHub Bot logged work on HADOOP-17483:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #2567:
URL: https://github.com/apache/hadoop/pull/2567#issuecomment-768528104
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
hadoop-yetus commented on pull request #2567:
URL: https://github.com/apache/hadoop/pull/2567#issuecomment-768532520
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
[
https://issues.apache.org/jira/browse/HADOOP-17482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273142#comment-17273142
]
David Mollitor commented on HADOOP-17482:
-
[~elgoiri] Do you have any cycles to
goiri commented on a change in pull request #2633:
URL: https://github.com/apache/hadoop/pull/2633#discussion_r565650951
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
##
@@ -3391,15 +3391,7 @@ private static void loadFileS
[
https://issues.apache.org/jira/browse/HADOOP-17482?focusedWorklogId=543103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543103
]
ASF GitHub Bot logged work on HADOOP-17482:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/HADOOP-17482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273156#comment-17273156
]
Íñigo Goiri commented on HADOOP-17482:
--
Yes, those test are clearly flaky,
I'm fin
Pedro Tôrres created HADOOP-17500:
-
Summary: S3A doesn't calculate Content-MD5 on uploads
Key: HADOOP-17500
URL: https://issues.apache.org/jira/browse/HADOOP-17500
Project: Hadoop Common
Issu
hadoop-yetus commented on pull request #2645:
URL: https://github.com/apache/hadoop/pull/2645#issuecomment-768627815
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=543157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543157
]
ASF GitHub Bot logged work on HADOOP-17424:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #2650:
URL: https://github.com/apache/hadoop/pull/2650#issuecomment-768635544
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
Konstantin Shvachko created HADOOP-17501:
Summary: Fix logging typo in ShutdownHookManager
Key: HADOOP-17501
URL: https://issues.apache.org/jira/browse/HADOOP-17501
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Shvachko updated HADOOP-17501:
-
Description: Three log messages in {{ShutdownHookManager}} have a typo,
saying
[
https://issues.apache.org/jira/browse/HADOOP-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fengnan Li reassigned HADOOP-17501:
---
Assignee: Fengnan Li
> Fix logging typo in ShutdownHookManager
> -
[
https://issues.apache.org/jira/browse/HADOOP-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273219#comment-17273219
]
Fengnan Li commented on HADOOP-17501:
-
Thanks [~shv] to report this. I will fix it.
joshelser commented on pull request #2587:
URL: https://github.com/apache/hadoop/pull/2587#issuecomment-768714175
> you are still going to need some robust storage, RAID-1+ or similar, but
we are getting sync all the way through, and you can query the streams to make
sure they say they sup
[
https://issues.apache.org/jira/browse/HADOOP-13327?focusedWorklogId=543269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543269
]
ASF GitHub Bot logged work on HADOOP-13327:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #2587:
URL: https://github.com/apache/hadoop/pull/2587#issuecomment-768757128
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
[
https://issues.apache.org/jira/browse/HADOOP-13327?focusedWorklogId=543332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543332
]
ASF GitHub Bot logged work on HADOOP-13327:
---
Author: ASF GitHub B
GauthamBanasandra commented on pull request #2567:
URL: https://github.com/apache/hadoop/pull/2567#issuecomment-768764746
@aajisaka Could you please review my PR?
This is an automated message from the Apache Git Service.
To r
crossfire opened a new pull request #2657:
URL: https://github.com/apache/hadoop/pull/2657
…ed by exception.
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding J
hadoop-yetus commented on pull request #2591:
URL: https://github.com/apache/hadoop/pull/2591#issuecomment-768821108
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
mehakmeet commented on a change in pull request #2648:
URL: https://github.com/apache/hadoop/pull/2648#discussion_r565828388
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java
##
@@ -114,4 +118,19 @@ public
[
https://issues.apache.org/jira/browse/HADOOP-15710?focusedWorklogId=543400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543400
]
ASF GitHub Bot logged work on HADOOP-15710:
---
Author: ASF GitHub B
crossfire commented on a change in pull request #2657:
URL: https://github.com/apache/hadoop/pull/2657#discussion_r565850014
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
##
@@ -503,6 +503,7 @@ void
bilaharith removed a comment on pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#issuecomment-760367373
> rs propagate the IOStatisticsSource interface, so when the innermost
iterator collects cost/count of list calls, the stats will be visible to and
collectable
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=543405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543405
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
Bilahari T H created HADOOP-17502:
-
Summary: IOStatistics collection for listStatusIterator()
Key: HADOOP-17502
URL: https://issues.apache.org/jira/browse/HADOOP-17502
Project: Hadoop Common
bilaharith commented on pull request #2548:
URL: https://github.com/apache/hadoop/pull/2548#issuecomment-768841035
Hi @steveloughran
I have created a separate JIRA for IOStatistics collection and linked the
same with HADOOP-17475. We will be picking the same afterwards.
--
[
https://issues.apache.org/jira/browse/HADOOP-17475?focusedWorklogId=543407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543407
]
ASF GitHub Bot logged work on HADOOP-17475:
---
Author: ASF GitHub B
83 matches
Mail list logo