[GitHub] [hadoop] liuml07 commented on pull request #1942: MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English.

2021-03-19 Thread GitBox
liuml07 commented on pull request #1942: URL: https://github.com/apache/hadoop/pull/1942#issuecomment-803240984 Have triggered another run manually: https://ci-hadoop.apache.org/job/hadoop-multibranch/view/change-requests/job/PR-1942/8/ FWIW, the way I trigger it is by logging into

[GitHub] [hadoop] liuml07 commented on pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
liuml07 commented on pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#issuecomment-803238936 comments: failing tests were not related or due to testing machine out of memory error. We have so many intermittent failures in HDFS tests. Glad to see bug fixes like

[GitHub] [hadoop] liuml07 merged pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
liuml07 merged pull request #2785: URL: https://github.com/apache/hadoop/pull/2785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #2784: HDFS-15850. Superuser actions should be reported to external enforcers

2021-03-19 Thread GitBox
xiaoyuyao commented on a change in pull request #2784: URL: https://github.com/apache/hadoop/pull/2784#discussion_r597962113 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java ## @@ -82,15 +82,24 @@ static

[GitHub] [hadoop] hadoop-yetus commented on pull request #2790: HDFS-15908. Possible Resource Leak in org.apache.hadoop.hdfs.qjournal.server.Journal

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2790: URL: https://github.com/apache/hadoop/pull/2790#issuecomment-803210360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#issuecomment-803199865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2789: YARN-10493: RunC container repository v2

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2789: URL: https://github.com/apache/hadoop/pull/2789#issuecomment-803153432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=569048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569048 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2675: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2675: URL: https://github.com/apache/hadoop/pull/2675#issuecomment-803043261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] Nargeshdb opened a new pull request #2790: HDFS-15908. Possible Resource Leak in org.apache.hadoop.hdfs.qjournal.server.Journal

2021-03-19 Thread GitBox
Nargeshdb opened a new pull request #2790: URL: https://github.com/apache/hadoop/pull/2790 This PR fixes the issue mentioned [here](https://issues.apache.org/jira/browse/HDFS-15908). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-17133) Implement HttpServer2 metrics

2021-03-19 Thread Jing Zhao (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305111#comment-17305111 ] Jing Zhao commented on HADOOP-17133: Thank you for working this, [~aajisaka] ! This is a very

[jira] [Work logged] (HADOOP-17133) Implement HttpServer2 metrics

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17133?focusedWorklogId=569040=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569040 ] ASF GitHub Bot logged work on HADOOP-17133: --- Author: ASF GitHub Bot

[jira] [Updated] (HADOOP-17133) Implement HttpServer2 metrics

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17133: Labels: pull-request-available (was: ) > Implement HttpServer2 metrics >

[GitHub] [hadoop] Jing9 commented on a change in pull request #2145: HADOOP-17133. Implement HttpServer2 metrics

2021-03-19 Thread GitBox
Jing9 commented on a change in pull request #2145: URL: https://github.com/apache/hadoop/pull/2145#discussion_r597886565 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java ## @@ -669,6 +674,16 @@ private void

[GitHub] [hadoop] hadoop-yetus commented on pull request #2789: YARN-10493: RunC container repository v2

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2789: URL: https://github.com/apache/hadoop/pull/2789#issuecomment-803018277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani commented on pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
virajjasani commented on pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#issuecomment-803005167 Majority test failures are due to timeout. Let me trigger build one more time? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=568998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568998 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2675: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2675: URL: https://github.com/apache/hadoop/pull/2675#issuecomment-802967314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2788: HDFS-15906. Close FSImage and FSNamesystem after formatting is complete

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2788: URL: https://github.com/apache/hadoop/pull/2788#issuecomment-802964038 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17531) DistCp: Reduce memory usage on copying huge directories

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17531?focusedWorklogId=568995=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568995 ] ASF GitHub Bot logged work on HADOOP-17531: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2732: HADOOP-17531. DistCp: Reduce memory usage on copying huge directories.

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2732: URL: https://github.com/apache/hadoop/pull/2732#issuecomment-802961338 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#issuecomment-802925668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] mbsharp opened a new pull request #2789: YARN-10493: RunC container repository v2

2021-03-19 Thread GitBox
mbsharp opened a new pull request #2789: URL: https://github.com/apache/hadoop/pull/2789 A new version of the image container repository. This aligns with the format that is used in the new Java CLI tool in YARN-10494. -- This is an automated message from the Apache Git Service. To

[jira] [Work logged] (HADOOP-17531) DistCp: Reduce memory usage on copying huge directories

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17531?focusedWorklogId=568929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568929 ] ASF GitHub Bot logged work on HADOOP-17531: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2732: HADOOP-17531. DistCp: Reduce memory usage on copying huge directories.

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2732: URL: https://github.com/apache/hadoop/pull/2732#issuecomment-802794723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17287) Support new Instance by non default constructor by ReflectionUtils

2021-03-19 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304867#comment-17304867 ] Stephen O'Donnell commented on HADOOP-17287: This seems to be on trunk and branch 3.2,

[GitHub] [hadoop] tomscut commented on pull request #2788: HDFS-15906. Close FSImage and FSNamesystem after formatting is complete

2021-03-19 Thread GitBox
tomscut commented on pull request #2788: URL: https://github.com/apache/hadoop/pull/2788#issuecomment-802771948 Hi @tasanuma @JunpingDu , could you please help review the code? Thank you very mush. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tomscut commented on a change in pull request #2748: HDFS-15879. Exclude slow nodes when choose targets for blocks

2021-03-19 Thread GitBox
tomscut commented on a change in pull request #2748: URL: https://github.com/apache/hadoop/pull/2748#discussion_r597610655 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyExcludeSlowNodes.java ##

[GitHub] [hadoop] tomscut commented on pull request #2748: HDFS-15879. Exclude slow nodes when choose targets for blocks

2021-03-19 Thread GitBox
tomscut commented on pull request #2748: URL: https://github.com/apache/hadoop/pull/2748#issuecomment-802766175 > +1 LGTM, thank you for making the changes. > I will leave it open for a few other folks to review this. Thanks @dineshchitlangia for your careful review. -- This is

[GitHub] [hadoop] tomscut opened a new pull request #2788: HDFS-15906. Close FSImage and FSNamesystem after formatting is complete

2021-03-19 Thread GitBox
tomscut opened a new pull request #2788: URL: https://github.com/apache/hadoop/pull/2788 JIRA: [HDFS-15906](https://issues.apache.org/jira/browse/HDFS-15906) We should close FSImage and FSNamesystem after formatting is complete. -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-13551) Collect AwsSdkMetrics in S3A FileSystem IOStatistics

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13551?focusedWorklogId=568911=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568911 ] ASF GitHub Bot logged work on HADOOP-13551: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2687: HADOOP-13551. Wire up AWS SDK metrics to IOStatistics

2021-03-19 Thread GitBox
steveloughran commented on pull request #2687: URL: https://github.com/apache/hadoop/pull/2687#issuecomment-802758846 See #2778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] bibinchundatt merged pull request #2674: YARN-10476. Queue metrics for Unmanaged applications

2021-03-19 Thread GitBox
bibinchundatt merged pull request #2674: URL: https://github.com/apache/hadoop/pull/2674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HADOOP-17594) DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-17594. --- Fix Version/s: 3.2.3 3.1.5 3.4.0

[jira] [Commented] (HADOOP-17594) DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304746#comment-17304746 ] Ayush Saxena commented on HADOOP-17594: --- Committed to trunk, branch-3.3,3.2 and 3.1 > DistCp:

[jira] [Work logged] (HADOOP-17594) DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17594?focusedWorklogId=568843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568843 ] ASF GitHub Bot logged work on HADOOP-17594: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ayushtkn commented on pull request #2786: HADOOP-17594. DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread GitBox
ayushtkn commented on pull request #2786: URL: https://github.com/apache/hadoop/pull/2786#issuecomment-802673826 Committed all the way to 3.1, Thanx @liuml07 and @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HADOOP-17595) Add ApacheCon Event Banner to website

2021-03-19 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated HADOOP-17595: Description: We should add an ApacheCon Event Banner to our website. -

[jira] [Created] (HADOOP-17595) Add ApacheCon Event Banner to website

2021-03-19 Thread Tsz-wo Sze (Jira)
Tsz-wo Sze created HADOOP-17595: --- Summary: Add ApacheCon Event Banner to website Key: HADOOP-17595 URL: https://issues.apache.org/jira/browse/HADOOP-17595 Project: Hadoop Common Issue Type:

[jira] [Work logged] (HADOOP-17594) DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17594?focusedWorklogId=568831=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568831 ] ASF GitHub Bot logged work on HADOOP-17594: --- Author: ASF GitHub Bot

[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2741: HDFS-15855.Solve the problem of incorrect EC progress when loading FsImage.

2021-03-19 Thread GitBox
Hexiaoqiao commented on a change in pull request #2741: URL: https://github.com/apache/hadoop/pull/2741#discussion_r597498170 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java ## @@ -482,11

[GitHub] [hadoop] ayushtkn merged pull request #2786: HADOOP-17594. DistCp: Expose the JobId for applications executing through run method

2021-03-19 Thread GitBox
ayushtkn merged pull request #2786: URL: https://github.com/apache/hadoop/pull/2786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] Hexiaoqiao commented on pull request #2736: HDFS-15868. Possible Resource Leak in EditLogFileOutputStream

2021-03-19 Thread GitBox
Hexiaoqiao commented on pull request #2736: URL: https://github.com/apache/hadoop/pull/2736#issuecomment-802653766 LGTM.+1 from my side. Committed to trunk! Thanks @Nargeshdb for your contributions and double checks. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] Hexiaoqiao merged pull request #2736: HDFS-15868. Possible Resource Leak in EditLogFileOutputStream

2021-03-19 Thread GitBox
Hexiaoqiao merged pull request #2736: URL: https://github.com/apache/hadoop/pull/2736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HADOOP-17428) ABFS: Implementation for getContentSummary

2021-03-19 Thread Sumangala Patki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304706#comment-17304706 ] Sumangala Patki commented on HADOOP-17428: -- ABFS is currently doing a breadth-first search in

[GitHub] [hadoop] liuml07 commented on pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
liuml07 commented on pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#issuecomment-802615115 Will commit after a good QA. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] hadoop-yetus commented on pull request #2784: HDFS-15850. Superuser actions should be reported to external enforcers

2021-03-19 Thread GitBox
hadoop-yetus commented on pull request #2784: URL: https://github.com/apache/hadoop/pull/2784#issuecomment-802607660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani commented on a change in pull request #2785: HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

2021-03-19 Thread GitBox
virajjasani commented on a change in pull request #2785: URL: https://github.com/apache/hadoop/pull/2785#discussion_r597445601 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java ## @@ -2297,7 +2297,9 @@ public