GauthamBanasandra opened a new pull request #2853:
URL: https://github.com/apache/hadoop/pull/2853
* Need to ensure that the destination
buffer size is greater the source content.
Truncation could happen otherwise.
* snprintf returns the size to be written
when we pass NULL
GauthamBanasandra commented on pull request #2853:
URL: https://github.com/apache/hadoop/pull/2853#issuecomment-812396703
This PR fixes the warnings reported as part of
https://github.com/apache/hadoop/pull/2792 in CI run
https://github.com/apache/hadoop/pull/2792#issuecomment-812174669
tasanuma opened a new pull request #2854:
URL: https://github.com/apache/hadoop/pull/2854
JIRA: https://issues.apache.org/jira/browse/HDFS-15945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hadoop-yetus commented on pull request #2850:
URL: https://github.com/apache/hadoop/pull/2850#issuecomment-812446467
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
hadoop-yetus commented on pull request #2784:
URL: https://github.com/apache/hadoop/pull/2784#issuecomment-812446608
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
[
https://issues.apache.org/jira/browse/HADOOP-17614?focusedWorklogId=575988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575988
]
ASF GitHub Bot logged work on HADOOP-17614:
---
Author: ASF GitHub B
tomscut opened a new pull request #2855:
URL: https://github.com/apache/hadoop/pull/2855
JIRA: [HDFS-15946](https://issues.apache.org/jira/browse/HDFS-15946)
Fix java doc for
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker#hasAclPermission.
--
This is an automated messa
hadoop-yetus commented on pull request #2853:
URL: https://github.com/apache/hadoop/pull/2853#issuecomment-812454579
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :o
hadoop-yetus commented on pull request #2851:
URL: https://github.com/apache/hadoop/pull/2851#issuecomment-812488205
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
qizhu-lucas edited a comment on pull request #2833:
URL: https://github.com/apache/hadoop/pull/2833#issuecomment-809439075
@Hexiaoqiao @ayushtkn @liuml07
Could you help review this, when you are free?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond t
hadoop-yetus commented on pull request #2854:
URL: https://github.com/apache/hadoop/pull/2854#issuecomment-812605266
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
goiri merged pull request #2853:
URL: https://github.com/apache/hadoop/pull/2853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
hadoop-yetus commented on pull request #2855:
URL: https://github.com/apache/hadoop/pull/2855#issuecomment-812617967
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
liuml07 merged pull request #2855:
URL: https://github.com/apache/hadoop/pull/2855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
GauthamBanasandra opened a new pull request #2856:
URL: https://github.com/apache/hadoop/pull/2856
* Used the appropriate Protobuf APIs to
replace those which are on the path to
deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the messa
GauthamBanasandra commented on pull request #2856:
URL: https://github.com/apache/hadoop/pull/2856#issuecomment-812647587
This PR fixes some of the warnings of the following kind that were reported
in PR https://github.com/apache/hadoop/pull/2792.
```
[ 48%] Building CXX object
m
hadoop-yetus commented on pull request #2856:
URL: https://github.com/apache/hadoop/pull/2856#issuecomment-812688003
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
hadoop-yetus commented on pull request #2792:
URL: https://github.com/apache/hadoop/pull/2792#issuecomment-812723722
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
sunchao commented on pull request #2611:
URL: https://github.com/apache/hadoop/pull/2611#issuecomment-812730610
> I think so. Previously people may include hadoop-common and expect
snappy/lz4 codec there. Where should we notify the people? release-note?
Perhaps we should create a pag
[
https://issues.apache.org/jira/browse/HADOOP-17464?focusedWorklogId=576335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576335
]
ASF GitHub Bot logged work on HADOOP-17464:
---
Author: ASF GitHub B
hadoop-yetus commented on pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#issuecomment-812755686
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
hadoop-yetus commented on pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#issuecomment-812773315
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok
tomscut commented on pull request #2855:
URL: https://github.com/apache/hadoop/pull/2855#issuecomment-812803557
Thanks @liuml07 for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
GauthamBanasandra opened a new pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857
* There are some instance where
the overflow is deliberately
done in order to get the lower
bound. This results in an
overflow warning.
* We fix this by using the min
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812819946
This PR fixes some warnings reported as part of
https://github.com/apache/hadoop/pull/2792.
```
[ 63%] Building CXX object
main/native/libhdfspp/tests/CMakeFi
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812820088
I was able to verify this change using the following standalone C++ program -
```cpp
#include
#include
#include
int main(int argc, char *argv[]) {
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812820177
We can observe that `Max int64_t + 1` and `Min int64_t` are equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
27 matches
Mail list logo
