[GitHub] [hadoop] hadoop-yetus commented on pull request #2819: HDFS-15923. RBF: Authentication failed when rename accross sub clusters.

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2819: URL: https://github.com/apache/hadoop/pull/2819#issuecomment-825405745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17620) DistCp: Use Iterator for listing target directory as well

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17620?focusedWorklogId=587626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587626 ] ASF GitHub Bot logged work on HADOOP-17620: --- Author: ASF GitHub Bot

[GitHub] [hadoop] vinayakumarb commented on pull request #2861: HADOOP-17620. DistCp: Use Iterator for listing target directory as well.

2021-04-22 Thread GitBox
vinayakumarb commented on pull request #2861: URL: https://github.com/apache/hadoop/pull/2861#issuecomment-825381821 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-17505) public interface GroupMappingServiceProvider needs default impl for getGroupsSet()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17505?focusedWorklogId=587625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587625 ] ASF GitHub Bot logged work on HADOOP-17505: --- Author: ASF GitHub Bot

[GitHub] [hadoop] vinayakumarb commented on pull request #2661: HADOOP-17505. public interface GroupMappingServiceProvider needs default impl for getGroupsSet()

2021-04-22 Thread GitBox
vinayakumarb commented on pull request #2661: URL: https://github.com/apache/hadoop/pull/2661#issuecomment-825378360 Thanks @ayushtkn @sodonnel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2767: HDFS-15790. Make ProtobufRpcEngineProtos and ProtobufRpcEngineProtos2 Co-Exist

2021-04-22 Thread GitBox
vinayakumarb commented on a change in pull request #2767: URL: https://github.com/apache/hadoop/pull/2767#discussion_r618930701 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java ## @@ -179,10 +281,41 @@ public void

[GitHub] [hadoop] tasanuma commented on pull request #2944: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma commented on pull request #2944: URL: https://github.com/apache/hadoop/pull/2944#issuecomment-825376607 Merged. Thanks for your contribution, @virajjasani! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] tasanuma merged pull request #2944: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma merged pull request #2944: URL: https://github.com/apache/hadoop/pull/2944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] tasanuma commented on pull request #2944: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma commented on pull request #2944: URL: https://github.com/apache/hadoop/pull/2944#issuecomment-825375289 Somehow Jenkins didn't work. But it just deleted the unused import from the last report of Jenkins and I think the latest commit is valid. I confirmed `mvn clean install

[GitHub] [hadoop] hadoop-yetus commented on pull request #2055: HDFS-15393: Review of PendingReconstructionBlocks

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2055: URL: https://github.com/apache/hadoop/pull/2055#issuecomment-825371322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tasanuma merged pull request #2943: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma merged pull request #2943: URL: https://github.com/apache/hadoop/pull/2943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] bshashikant commented on a change in pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-22 Thread GitBox
bshashikant commented on a change in pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#discussion_r618922109 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java ## @@ -98,6 +98,7 @@ public

[GitHub] [hadoop] tasanuma commented on pull request #2942: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma commented on pull request #2942: URL: https://github.com/apache/hadoop/pull/2942#issuecomment-825368238 Merged. Thanks, @virajjasani! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] tasanuma merged pull request #2942: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma merged pull request #2942: URL: https://github.com/apache/hadoop/pull/2942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] TJJack commented on pull request #2803: YARN-10708. Remove NULL checks before instanceof

2021-04-22 Thread GitBox
TJJack commented on pull request #2803: URL: https://github.com/apache/hadoop/pull/2803#issuecomment-825351031 Thanks @virajjasani, please help to merge, the check failures should not be related to these code changes. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] tasanuma commented on pull request #2942: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma commented on pull request #2942: URL: https://github.com/apache/hadoop/pull/2942#issuecomment-825322491 I confirmed TestBalancer and TestBalancerLongRunningTasks succeeded in my local environment. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587594=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587594 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] aajisaka commented on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
aajisaka commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825321708 > If you are fine, I can create PR with this enforcer in parallel? Yes. Thank you! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] zhuxiangyi commented on pull request #2915: HDFS-15974. RBF: Unable to display the datanode UI of the router

2021-04-22 Thread GitBox
zhuxiangyi commented on pull request #2915: URL: https://github.com/apache/hadoop/pull/2915#issuecomment-825320338 > Merged. Thanks for your contribution, @zhuxiangyi. Thanks for your reviews, @goiri. Thanks a lot, @goiri @tasanuma . -- This is an automated message from the

[GitHub] [hadoop] tasanuma commented on pull request #2915: HDFS-15974. RBF: Unable to display the datanode UI of the router

2021-04-22 Thread GitBox
tasanuma commented on pull request #2915: URL: https://github.com/apache/hadoop/pull/2915#issuecomment-825316164 Merged. Thanks for your contribution, @zhuxiangyi. Thanks for your reviews, @goiri. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tasanuma merged pull request #2915: HDFS-15974. RBF: Unable to display the datanode UI of the router

2021-04-22 Thread GitBox
tasanuma merged pull request #2915: URL: https://github.com/apache/hadoop/pull/2915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop] smengcl commented on pull request #2946: YARN-10747. Bump YARN CSI protobuf version to 3.7.1

2021-04-22 Thread GitBox
smengcl commented on pull request #2946: URL: https://github.com/apache/hadoop/pull/2946#issuecomment-825206321 This is weird. The second commit essentially translate into the same thing as the first one, but now it gets mvninstall -1 for Dependency convergence error: ```

[GitHub] [hadoop] hadoop-yetus commented on pull request #2942: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2942: URL: https://github.com/apache/hadoop/pull/2942#issuecomment-825200562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2946: YARN-10747. Bump YARN CSI protobuf version to 3.7.1

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2946: URL: https://github.com/apache/hadoop/pull/2946#issuecomment-825191564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2943: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2943: URL: https://github.com/apache/hadoop/pull/2943#issuecomment-825178660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] smengcl commented on pull request #2946: YARN-10747. Bump YARN CSI protobuf version to 3.7.1

2021-04-22 Thread GitBox
smengcl commented on pull request #2946: URL: https://github.com/apache/hadoop/pull/2946#issuecomment-825136131 > I think `hadoop.protobuf.version` in hadoop-project/pom.xml can be used instead of defining the version in hadoop-yarn-csi module. Good point! Done. -- This is an

[jira] [Work logged] (HADOOP-17650) Fails to build using Maven 3.8.1

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17650?focusedWorklogId=587445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587445 ] ASF GitHub Bot logged work on HADOOP-17650: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2939: HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1

2021-04-22 Thread GitBox
virajjasani commented on pull request #2939: URL: https://github.com/apache/hadoop/pull/2939#issuecomment-825105337 Nice question @smengcl. I think we should update compatibility guidelines (release notes in Jira) stating that since we are upgrading SolrJ to 8.8.2, it's good to upgrade

[jira] [Work logged] (HADOOP-17597) Add option to downgrade S3A rejection of Syncable to warning

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17597?focusedWorklogId=587432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587432 ] ASF GitHub Bot logged work on HADOOP-17597: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2801: HADOOP-17597. Optionally downgrade on S3A Syncable calls

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2801: URL: https://github.com/apache/hadoop/pull/2801#discussion_r618655930 ## File path: hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md ## @@ -1036,6 +1036,39 @@ This includes resilient

[jira] [Work logged] (HADOOP-17536) ABFS: Suport for customer provided encrption key

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17536?focusedWorklogId=587431=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587431 ] ASF GitHub Bot logged work on HADOOP-17536: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2707: HADOOP-17536. ABFS: Supporting customer provided encryption key

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2707: URL: https://github.com/apache/hadoop/pull/2707#discussion_r618646291 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestCustomerProvidedKey.java ## @@ -0,0 +1,957 @@ +/** + *

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587428 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825093160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587375 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani edited a comment on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
virajjasani edited a comment on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825016629 > > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus would be great > >

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587372 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
virajjasani commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825016629 > > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus would be great > > We can

[GitHub] [hadoop] aajisaka edited a comment on pull request #2910: HDFS-15810. RBF: Use BigInteger for Router capacity metrics

2021-04-22 Thread GitBox
aajisaka edited a comment on pull request #2910: URL: https://github.com/apache/hadoop/pull/2910#issuecomment-822196865 Would you update the web UI to use the new metrics?

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587369=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587369 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] aajisaka commented on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
aajisaka commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825009245 > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus would be great We can warn the

[jira] [Work logged] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=587367=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587367 ] ASF GitHub Bot logged work on HADOOP-17649: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani edited a comment on pull request #2932: HADOOP-17649. Upgrade wildfly openssl to 2.1.3.Final due to security vulnerabilities

2021-04-22 Thread GitBox
virajjasani edited a comment on pull request #2932: URL: https://github.com/apache/hadoop/pull/2932#issuecomment-824996410 Btw, the main reason behind this upgrade is CVE: https://nvd.nist.gov/vuln/detail/CVE-2020-25644 ``` A memory leak flaw was found in WildFly OpenSSL in versions

[jira] [Work logged] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=587357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587357 ] ASF GitHub Bot logged work on HADOOP-17649: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ayushtkn commented on a change in pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-22 Thread GitBox
ayushtkn commented on a change in pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#discussion_r618435518 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java ## @@ -8575,22 +8587,21 @@ public

[GitHub] [hadoop] virajjasani commented on pull request #2932: HADOOP-17649. Upgrade wildfly openssl to 2.1.3.Final due to security vulnerabilities

2021-04-22 Thread GitBox
virajjasani commented on pull request #2932: URL: https://github.com/apache/hadoop/pull/2932#issuecomment-824996410 Btw, the main reason behind this upgrade is CVE: https://nvd.nist.gov/vuln/detail/CVE-2020-25644 ``` A memory leak flaw was found in WildFly OpenSSL in versions prior

[jira] [Work logged] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=587351=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587351 ] ASF GitHub Bot logged work on HADOOP-17649: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2932: HADOOP-17649. Upgrade wildfly openssl to 2.1.3.Final due to security vulnerabilities

2021-04-22 Thread GitBox
virajjasani commented on pull request #2932: URL: https://github.com/apache/hadoop/pull/2932#issuecomment-824987122 > The reason we use wildfly in the azure and -aws JARs is for performance by picking up those native bindings. if you use wildfly ssl as your socket factory, when openssl

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-811485602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-806832078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=587331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587331 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=587330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587330 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=587324=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587324 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=587323=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587323 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-805988234 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-805044041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-17618) ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587315=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587315 ] ASF GitHub Bot logged work on HADOOP-17618: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2845: HADOOP-17618. ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#discussion_r618504576 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java ## @@ -227,11 +229,30 @@ public

[jira] [Work logged] (HADOOP-17618) ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587297 ] ASF GitHub Bot logged work on HADOOP-17618: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17618) ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587298 ] ASF GitHub Bot logged work on HADOOP-17618: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17618) ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587296 ] ASF GitHub Bot logged work on HADOOP-17618: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2845: HADOOP-17618. ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#issuecomment-816990399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2845: HADOOP-17618. ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#issuecomment-821037219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2845: HADOOP-17618. ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread GitBox
hadoop-yetus removed a comment on pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#issuecomment-822809327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=587292=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587292 ] ASF GitHub Bot logged work on HADOOP-17649: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2932: HADOOP-17649. Upgrade wildfly openssl to 2.1.3.Final due to security vulnerabilities

2021-04-22 Thread GitBox
steveloughran commented on pull request #2932: URL: https://github.com/apache/hadoop/pull/2932#issuecomment-824936606 The reason we use wildfly in the azure and -aws JARs is for performance by picking up those native bindings. if you use wildfly ssl as your socket factory, when openssl

[GitHub] [hadoop] tasanuma commented on pull request #2942: HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime()

2021-04-22 Thread GitBox
tasanuma commented on pull request #2942: URL: https://github.com/apache/hadoop/pull/2942#issuecomment-824934699 @virajjasani Thanks for the PRs. Could you remove unused imports in `TestBalancerLongRunningTasks`? There are the same unused imports in the PRs for branch-3.2 and branch-3.1.

[jira] [Work logged] (HADOOP-17471) ABFS to collect IOStatistics

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17471?focusedWorklogId=587289=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587289 ] ASF GitHub Bot logged work on HADOOP-17471: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#discussion_r618495982 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java ## @@ -167,12 +167,30 @@ String

[jira] [Work logged] (HADOOP-17471) ABFS to collect IOStatistics

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17471?focusedWorklogId=587285=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587285 ] ASF GitHub Bot logged work on HADOOP-17471: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#discussion_r618493561 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsOutputStreamStatistics.java ## @@ -241,10 +247,13 @@

[jira] [Updated] (HADOOP-11219) [Umbrella] Upgrade to netty 4

2021-04-22 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szilard Nemeth updated HADOOP-11219: Summary: [Umbrella] Upgrade to netty 4 (was: Upgrade to netty 4) > [Umbrella] Upgrade

[jira] [Created] (HADOOP-17654) abfs incremental listing to support many active listings

2021-04-22 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-17654: --- Summary: abfs incremental listing to support many active listings Key: HADOOP-17654 URL: https://issues.apache.org/jira/browse/HADOOP-17654 Project: Hadoop

[jira] [Commented] (HADOOP-17475) ABFS : add high performance listStatusIterator

2021-04-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329098#comment-17329098 ] Steve Loughran commented on HADOOP-17475: - Hey, I've just noticed the listings are going into

[GitHub] [hadoop] virajjasani edited a comment on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
virajjasani edited a comment on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-824752061 > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus would be great

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587177=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587177 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587171=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587171 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
virajjasani commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-824752061 > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus would be great @steveloughran

[jira] [Commented] (HADOOP-17639) Restrict the "-skipTrash" param for accidentally deletes data

2021-04-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327713#comment-17327713 ] Viraj Jasani commented on HADOOP-17639: --- {quote}We already have snapshots, protected directories

[jira] [Work logged] (HADOOP-17653) Do not use guava's Files.createTempDir()

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587167=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587167 ] ASF GitHub Bot logged work on HADOOP-17653: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().

2021-04-22 Thread GitBox
steveloughran commented on a change in pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#discussion_r618302465 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/blockaliasmap/impl/TestLevelDbMockAliasMapClient.java

[GitHub] [hadoop] hadoop-yetus commented on pull request #2819: HDFS-15923. Authentication failed when rename accross sub clusters.

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2819: URL: https://github.com/apache/hadoop/pull/2819#issuecomment-824732441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Commented] (HADOOP-17639) Restrict the "-skipTrash" param for accidentally deletes data

2021-04-22 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327265#comment-17327265 ] Stephen O'Donnell commented on HADOOP-17639: The trash interval is used to purge the trash

[jira] [Commented] (HADOOP-12431) NameNode should bind on both IPv6 and IPv4 if running on dual-stack machine and IPv6 enabled

2021-04-22 Thread ANANDA G B (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327260#comment-17327260 ] ANANDA G B commented on HADOOP-12431: - [~eclark] We are also working on NameNode to bind on both

[jira] [Commented] (HADOOP-17639) Restrict the "-skipTrash" param for accidentally deletes data

2021-04-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327248#comment-17327248 ] Viraj Jasani commented on HADOOP-17639: --- Sounds good, I think yes it makes sense to continue

[GitHub] [hadoop] bshashikant commented on pull request #2881: HDFS-15961. standby namenode failed to start ordered snapshot deletion is enabled while having snapshottable directories

2021-04-22 Thread GitBox
bshashikant commented on pull request #2881: URL: https://github.com/apache/hadoop/pull/2881#issuecomment-824649349 @ayushtkn /@smengcl any further thoughts/reviews? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Work logged] (HADOOP-17618) ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587115 ] ASF GitHub Bot logged work on HADOOP-17618: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #2845: HADOOP-17618. ABFS: Partially obfuscate SAS object IDs in Logs

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#issuecomment-824633241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data on the Web UI must be saved to the trash

2021-04-22 Thread GitBox
virajjasani commented on pull request #2927: URL: https://github.com/apache/hadoop/pull/2927#issuecomment-824604340 @jojochuang if you have some cycles to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HADOOP-17112) whitespace not allowed in paths when saving files to s3a via committer

2021-04-22 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327138#comment-17327138 ] Wei-Chiu Chuang commented on HADOOP-17112: -- [~ste...@apache.org] do you think we can fix this

[GitHub] [hadoop] hadoop-yetus commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "--delete …

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-824585598 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2946: YARN-10747. Bump YARN CSI protobuf version to 3.7.1

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2946: URL: https://github.com/apache/hadoop/pull/2946#issuecomment-824576213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "--delete …

2021-04-22 Thread GitBox
hadoop-yetus commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-824568557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17650) Fails to build using Maven 3.8.1

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17650?focusedWorklogId=587072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587072 ] ASF GitHub Bot logged work on HADOOP-17650: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #2939: HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1

2021-04-22 Thread GitBox
virajjasani commented on pull request #2939: URL: https://github.com/apache/hadoop/pull/2939#issuecomment-824564927 @smengcl could you please review the PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use