[GitHub] [hadoop] aajisaka commented on a change in pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-23 Thread GitBox
aajisaka commented on a change in pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#discussion_r637728863 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap/InMemoryAliasMap.java ## @@ -320,21 +320,18 @@ static

[GitHub] [hadoop] hadoop-yetus commented on pull request #3023: HDFS-16028. Add a configuration item for special trash dir

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3023: URL: https://github.com/apache/hadoop/pull/3023#issuecomment-846806097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#issuecomment-846772078 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] haiyang1987 commented on pull request #3036: HDFS-15998. Fix NullPointException In listOpenFiles

2021-05-23 Thread GitBox
haiyang1987 commented on pull request #3036: URL: https://github.com/apache/hadoop/pull/3036#issuecomment-846720962 @jojochuang Thanks for comments. Later, I'll try to add a unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (HADOOP-17717) Update wildfly openssl to 1.1.3.Final

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17717: - Target Version/s: 3.3.2 (was: 3.3.1) > Update wildfly openssl to 1.1.3.Final > ---

[GitHub] [hadoop] zhuxiangyi commented on a change in pull request #2981: HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router

2021-05-23 Thread GitBox
zhuxiangyi commented on a change in pull request #2981: URL: https://github.com/apache/hadoop/pull/2981#discussion_r637659170 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java ## @@ -1036,6 +1057,83 @@ priv

[jira] [Updated] (HADOOP-17699) Remove hardcoded SunX509 usage from SSLFactory

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17699: - Target Version/s: 3.3.2 > Remove hardcoded SunX509 usage from SSLFactory >

[jira] [Updated] (HADOOP-14254) Add a Distcp option to preserve Erasure Coding attributes

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-14254: - Target Version/s: 3.4.0, 3.3.2 (was: 3.4.0) > Add a Distcp option to preserve Erasure

[jira] [Updated] (HADOOP-17208) LoadBalanceKMSClientProvider#deleteKey should invalidateCache via all KMSClientProvider instances

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17208: - Target Version/s: 3.3.2 > LoadBalanceKMSClientProvider#deleteKey should invalidateCache

[jira] [Updated] (HADOOP-17341) Upgrade commons-codec to 1.15

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17341: - Target Version/s: 3.3.2 > Upgrade commons-codec to 1.15 > -

[jira] [Updated] (HADOOP-17259) Allow SSLFactory fallback to input config if ssl-*.xml fail to load from classpath

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17259: - Target Version/s: 3.3.2 > Allow SSLFactory fallback to input config if ssl-*.xml fail t

[jira] [Updated] (HADOOP-17282) libzstd-dev should be used instead of libzstd1-dev on Ubuntu 18.04 or higher

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17282: - Target Version/s: 3.3.2 > libzstd-dev should be used instead of libzstd1-dev on Ubuntu

[jira] [Updated] (HADOOP-17552) Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17552: - Target Version/s: 3.3.2 > Change ipc.client.rpc-timeout.ms from 0 to 12 by default

[jira] [Updated] (HADOOP-17044) Revert "HADOOP-8143. Change distcp to have -pb on by default"

2021-05-23 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-17044: - Release Note: Distcp block size is not preserved by default, unless -pb is specified. T

[GitHub] [hadoop] Nargeshdb commented on pull request #3027: HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap

2021-05-23 Thread GitBox
Nargeshdb commented on pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#issuecomment-846635685 > Thanks for the patch. @aajisaka Thanks for the feedback. > We should use try-with-resources to close the resources. https://github.com/apache/hadoop/pull/3027/commits

[GitHub] [hadoop] hadoop-yetus commented on pull request #3044: Revert "Revert "HDFS-15971. Make mkstemp cross platform (#2898)""

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3044: URL: https://github.com/apache/hadoop/pull/3044#issuecomment-846616162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600955 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846601944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] GauthamBanasandra closed pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-23 Thread GitBox
GauthamBanasandra closed pull request #3014: URL: https://github.com/apache/hadoop/pull/3014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [hadoop] GauthamBanasandra commented on pull request #3014: HDFS-16026. Restore cross platform mkstemp

2021-05-23 Thread GitBox
GauthamBanasandra commented on pull request #3014: URL: https://github.com/apache/hadoop/pull/3014#issuecomment-846593890 Abandoning this. Will be handled in https://github.com/apache/hadoop/pull/3044. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hadoop] hadoop-yetus commented on pull request #2767: HDFS-15790. Make ProtobufRpcEngineProtos and ProtobufRpcEngineProtos2 Co-Exist

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #2767: URL: https://github.com/apache/hadoop/pull/2767#issuecomment-846593536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600945 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846593246 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[GitHub] [hadoop] GauthamBanasandra opened a new pull request #3044: Revert "Revert "HDFS-15971. Make mkstemp cross platform (#2898)""

2021-05-23 Thread GitBox
GauthamBanasandra opened a new pull request #3044: URL: https://github.com/apache/hadoop/pull/3044 * This reverts commit aed13f0f42fefe30a53eb73c65c2072a031f173e. * Verified by building locally on Centos 7 that Hadoop builds fine with this PR. * Build log - https://issue

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600936 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846574131 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600935 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846574028 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600931 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846568988 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2767: HDFS-15790. Make ProtobufRpcEngineProtos and ProtobufRpcEngineProtos2 Co-Exist

2021-05-23 Thread GitBox
vinayakumarb commented on a change in pull request #2767: URL: https://github.com/apache/hadoop/pull/2767#discussion_r637551571 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java ## @@ -937,11 +937,18 @@ public int hashCode() {

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2767: HDFS-15790. Make ProtobufRpcEngineProtos and ProtobufRpcEngineProtos2 Co-Exist

2021-05-23 Thread GitBox
vinayakumarb commented on a change in pull request #2767: URL: https://github.com/apache/hadoop/pull/2767#discussion_r637551551 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine2.java ## @@ -495,6 +524,7 @@ private static P

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=600927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600927 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3041: HADOOP-17725. Improve error message for token providers in ABFS

2021-05-23 Thread GitBox
virajjasani commented on pull request #3041: URL: https://github.com/apache/hadoop/pull/3041#issuecomment-846559147 > I would appreciate it if you could address the comments, thanks. Thanks for the review @sadikovi, I missed out of on other token providers initially. Please take a lo

[jira] [Comment Edited] (HADOOP-17725) Improve error message for token providers in ABFS

2021-05-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350021#comment-17350021 ] Viraj Jasani edited comment on HADOOP-17725 at 5/23/21, 12:55 PM: ---

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600925 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846556840 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[jira] [Work logged] (HADOOP-17727) Modularize docker images

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=600924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600924 ] ASF GitHub Bot logged work on HADOOP-17727: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3043: HADOOP-17727. Modularize docker images

2021-05-23 Thread GitBox
hadoop-yetus commented on pull request #3043: URL: https://github.com/apache/hadoop/pull/3043#issuecomment-846555857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For que

[jira] [Commented] (HADOOP-17725) Improve error message for token providers in ABFS

2021-05-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350021#comment-17350021 ] Viraj Jasani commented on HADOOP-17725: --- [~ste...@apache.org] Would you like to t

[GitHub] [hadoop] jojochuang commented on a change in pull request #2767: HDFS-15790. Make ProtobufRpcEngineProtos and ProtobufRpcEngineProtos2 Co-Exist

2021-05-23 Thread GitBox
jojochuang commented on a change in pull request #2767: URL: https://github.com/apache/hadoop/pull/2767#discussion_r637485155 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine2.java ## @@ -495,6 +524,7 @@ private static Pro

[jira] [Work logged] (HADOOP-17511) Add an Audit plugin point for S3A auditing/context

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=600922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600922 ] ASF GitHub Bot logged work on HADOOP-17511: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-05-23 Thread GitBox
steveloughran commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-846551528 thank's for the reviews, comments, votes etc. I'll address all of @mehakmeet's little details, push up a rebased/squashed PR to force it through yetus, then merge -- T

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=600921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600921 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread GitBox
steveloughran commented on pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#issuecomment-846551321 I'm going to pull @liuml07 in to help review this, as it's a bit of code they've gone near in the past and weak reference queues are new to me -- This is an automated mes

[jira] [Work logged] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?focusedWorklogId=600920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600920 ] ASF GitHub Bot logged work on HADOOP-17728: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on a change in pull request #3042: HDFS-16033 Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread GitBox
steveloughran commented on a change in pull request #3042: URL: https://github.com/apache/hadoop/pull/3042#discussion_r637533874 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ## @@ -4004,12 +4004,14 @@ public void cleanUp(

[jira] [Updated] (HADOOP-17728) Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17728: Summary: Deadlock in FileSystem StatisticsDataReferenceCleaner cleanUp (was: Fix issue o

[jira] [Moved] (HADOOP-17728) Fix issue of the StatisticsDataReferenceCleaner cleanUp

2021-05-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran moved HDFS-16033 to HADOOP-17728: Component/s: (was: hdfs) fs