[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3110: HADOOP-17250 Lot of short reads can be merged with readahead.

2021-07-04 Thread GitBox
hadoop-yetus removed a comment on pull request #3110: URL: https://github.com/apache/hadoop/pull/3110#issuecomment-873849595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-17250) ABFS: Random read perf improvement

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17250?focusedWorklogId=618552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618552 ] ASF GitHub Bot logged work on HADOOP-17250: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3110: HADOOP-17250 Lot of short reads can be merged with readahead.

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3110: URL: https://github.com/apache/hadoop/pull/3110#issuecomment-873853190 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17250) ABFS: Random read perf improvement

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17250?focusedWorklogId=618550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618550 ] ASF GitHub Bot logged work on HADOOP-17250: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3110: HADOOP-17250 Lot of short reads can be merged with readahead.

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3110: URL: https://github.com/apache/hadoop/pull/3110#issuecomment-873849595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#issuecomment-873841548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3176: HADDOP-7351 - CleanupJob during handle of SIGTERM signal

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3176: URL: https://github.com/apache/hadoop/pull/3176#issuecomment-873839583 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17749) Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17749?focusedWorklogId=618528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618528 ] ASF GitHub Bot logged work on HADOOP-17749: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3080: HADOOP-17749. Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3080: URL: https://github.com/apache/hadoop/pull/3080#issuecomment-873809787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] shubhamod opened a new pull request #3176: HADDOP-7351 - CleanupJob during handle of SIGTERM signal

2021-07-04 Thread GitBox
shubhamod opened a new pull request #3176: URL: https://github.com/apache/hadoop/pull/3176 Currently MR CleanupJob happens when the job is either successful or fail. But during kill, it is not handled. This leaves all the temporary folders under the output path. JIRA: https://issues

[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618519 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3153: HADOOP-17765. ABFS: Use Unique File Paths in Tests

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-873783795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17749) Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17749?focusedWorklogId=618515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618515 ] ASF GitHub Bot logged work on HADOOP-17749: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka commented on a change in pull request #3080: HADOOP-17749. Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread GitBox
aajisaka commented on a change in pull request #3080: URL: https://github.com/apache/hadoop/pull/3080#discussion_r663635590 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java ## @@ -426,34 +408,41 @@ private synchroni

[GitHub] [hadoop] tomscut commented on pull request #3174: HDFS-16110. Remove unused method reportChecksumFailure in DFSClient

2021-07-04 Thread GitBox
tomscut commented on pull request #3174: URL: https://github.com/apache/hadoop/pull/3174#issuecomment-873767890 Hi @aajisaka @tasanuma @jojochuang @ferhui , could you please review the code? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618496 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub B

[GitHub] [hadoop] sumangala-patki commented on a change in pull request #3153: HADOOP-17765. ABFS: Use Unique File Paths in Tests

2021-07-04 Thread GitBox
sumangala-patki commented on a change in pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#discussion_r663618585 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java ## @@ -25,6 +25,8 @@ import

[GitHub] [hadoop] ferhui commented on pull request #3140: HDFS-16088. Standby NameNode process getLiveDatanodeStorageReport req…

2021-07-04 Thread GitBox
ferhui commented on pull request #3140: URL: https://github.com/apache/hadoop/pull/3140#issuecomment-873759215 LGTM. @Hexiaoqiao Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Work logged] (HADOOP-17749) Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17749?focusedWorklogId=618490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618490 ] ASF GitHub Bot logged work on HADOOP-17749: --- Author: ASF GitHub B

[GitHub] [hadoop] liangxs commented on a change in pull request #3080: HADOOP-17749. Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread GitBox
liangxs commented on a change in pull request #3080: URL: https://github.com/apache/hadoop/pull/3080#discussion_r663608673 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java ## @@ -426,34 +408,41 @@ private synchroniz

[jira] [Work logged] (HADOOP-17749) Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17749?focusedWorklogId=618489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618489 ] ASF GitHub Bot logged work on HADOOP-17749: --- Author: ASF GitHub B

[GitHub] [hadoop] liangxs commented on a change in pull request #3080: HADOOP-17749. Remove lock contention in SelectorPool of SocketIOWithTimeout

2021-07-04 Thread GitBox
liangxs commented on a change in pull request #3080: URL: https://github.com/apache/hadoop/pull/3080#discussion_r663608644 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/SocketIOWithTimeout.java ## @@ -426,34 +408,41 @@ private synchroniz

[GitHub] [hadoop] hadoop-yetus commented on pull request #3174: HDFS-16110. Remove unused method reportChecksumFailure in DFSClient

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3174: URL: https://github.com/apache/hadoop/pull/3174#issuecomment-873738971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] tomscut commented on pull request #3140: HDFS-16088. Standby NameNode process getLiveDatanodeStorageReport req…

2021-07-04 Thread GitBox
tomscut commented on pull request #3140: URL: https://github.com/apache/hadoop/pull/3140#issuecomment-873724526 Hi @ferhui @Hexiaoqiao , I extracted a new method and added an seperate UT. Could you please review again? Thanks a lot. -- This is an automated message from the Apache Git Ser

[GitHub] [hadoop] hadoop-yetus commented on pull request #3140: HDFS-16088. Standby NameNode process getLiveDatanodeStorageReport req…

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3140: URL: https://github.com/apache/hadoop/pull/3140#issuecomment-873723601 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] ferhui merged pull request #3169: HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer

2021-07-04 Thread GitBox
ferhui merged pull request #3169: URL: https://github.com/apache/hadoop/pull/3169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-un

[GitHub] [hadoop] ferhui commented on pull request #3169: HDFS-16108. Fix incorrect log placeholders used in JournalNodeSyncer

2021-07-04 Thread GitBox
ferhui commented on pull request #3169: URL: https://github.com/apache/hadoop/pull/3169#issuecomment-873715651 @virajjasani Thanks for contribution. @aajisaka @tomscut Thanks for review. Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] aajisaka merged pull request #3172: HDFS-16109. Fix flaky some unit tests since they offen timeout

2021-07-04 Thread GitBox
aajisaka merged pull request #3172: URL: https://github.com/apache/hadoop/pull/3172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[GitHub] [hadoop] zhihaixu2012 opened a new pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-04 Thread GitBox
zhihaixu2012 opened a new pull request #3175: URL: https://github.com/apache/hadoop/pull/3175 …avoid failed volumes at datanodes. Change-Id: Iead25812d4073e3980893e3e76f7d2b03b57442a JIRA: https://issues.apache.org/jira/browse/HDFS-16111 there is a potential bug when pic

[GitHub] [hadoop] hadoop-yetus commented on pull request #3174: HDFS-16110. Remove unused method reportChecksumFailure in DFSClient

2021-07-04 Thread GitBox
hadoop-yetus commented on pull request #3174: URL: https://github.com/apache/hadoop/pull/3174#issuecomment-873669979 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17250) ABFS: Random read perf improvement

2021-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17250?focusedWorklogId=618453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618453 ] ASF GitHub Bot logged work on HADOOP-17250: --- Author: ASF GitHub B

[GitHub] [hadoop] snvijaya commented on a change in pull request #3110: HADOOP-17250 Lot of short reads can be merged with readahead.

2021-07-04 Thread GitBox
snvijaya commented on a change in pull request #3110: URL: https://github.com/apache/hadoop/pull/3110#discussion_r663552686 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java ## @@ -207,6 +215,28 @@ public synchron

[GitHub] [hadoop] tomscut opened a new pull request #3174: HDFS-16110. Remove unused method reportChecksumFailure in DFSClient

2021-07-04 Thread GitBox
tomscut opened a new pull request #3174: URL: https://github.com/apache/hadoop/pull/3174 JIRA: [HDFS-16110](https://issues.apache.org/jira/browse/HDFS-16110) Remove unused method reportChecksumFailure and fix some code styles by the way in DFSClient. -- This is an automated messag

[GitHub] [hadoop] tomscut commented on pull request #3172: HDFS-16109. Fix flaky some unit tests since they offen timeout

2021-07-04 Thread GitBox
tomscut commented on pull request #3172: URL: https://github.com/apache/hadoop/pull/3172#issuecomment-873557085 Thanks @aajisaka and @ayushtkn for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Comment Edited] (HADOOP-17787) Refactor fetching of credentials in Jenkins

2021-07-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374212#comment-17374212 ] Ayush Saxena edited comment on HADOOP-17787 at 7/4/21, 7:35 AM: -

[jira] [Comment Edited] (HADOOP-17787) Refactor fetching of credentials in Jenkins

2021-07-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374212#comment-17374212 ] Ayush Saxena edited comment on HADOOP-17787 at 7/4/21, 7:24 AM: -

[jira] [Commented] (HADOOP-17787) Refactor fetching of credentials in Jenkins

2021-07-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374212#comment-17374212 ] Ayush Saxena commented on HADOOP-17787: --- It is executing this command: {noformat}

[jira] [Commented] (HADOOP-17787) Refactor fetching of credentials in Jenkins

2021-07-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374209#comment-17374209 ] Ayush Saxena commented on HADOOP-17787: --- Any pointers what broke it? It can not b